From: Simon Horman <horms@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
dmitry.bezrukov@aquantia.com, marcinguy@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCHv2] USB: gl620a: check for rx buffer overflow
Date: Fri, 24 Nov 2023 11:53:07 +0000 [thread overview]
Message-ID: <20231124115307.GP50352@kernel.org> (raw)
In-Reply-To: <2338f70a-1823-47ad-8302-7fb62481f736@suse.com>
On Wed, Nov 22, 2023 at 11:20:47AM +0100, Oliver Neukum wrote:
>
>
> On 22.11.23 11:07, Sergei Shtylyov wrote:
> > On 11/22/23 1:04 PM, Oliver Neukum wrote:
> >
> > [...]
> > > > > The driver checks for a single package overflowing
> > > >
> > > > Maybe packet?
> > >
> > > No, that would be read as network packet, which
> > > is precisely what this not not and should not
> > > be mistaken for.
> >
> > But "package" hardly fits either. Is it a USB packet or something else?
>
> Technically the content of the buffer associated
> with a single URB. Which on USB physically can be multiple
> packets. The network packets arrive together in a package.
> That is how this and related drivers operate.
I think it would be useful to include information along the lines
of the above in the patch description.
next prev parent reply other threads:[~2023-11-24 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 9:52 [PATCHv2] USB: gl620a: check for rx buffer overflow Oliver Neukum
2023-11-22 9:55 ` Sergey Shtylyov
2023-11-22 10:04 ` Oliver Neukum
2023-11-22 10:07 ` Sergei Shtylyov
2023-11-22 10:20 ` Oliver Neukum
2023-11-24 11:53 ` Simon Horman [this message]
2023-11-30 9:38 ` Oliver Neukum
2023-11-30 16:42 ` Simon Horman
2023-12-05 8:04 ` Paolo Abeni
2023-12-05 10:21 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124115307.GP50352@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dmitry.bezrukov@aquantia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcinguy@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.