From: Simon Horman <horms@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
dmitry.bezrukov@aquantia.com, marcinguy@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCHv2] USB: gl620a: check for rx buffer overflow
Date: Thu, 30 Nov 2023 16:42:57 +0000 [thread overview]
Message-ID: <20231130164257.GD32077@kernel.org> (raw)
In-Reply-To: <794803a2-3084-4591-b91f-6c7cc7a3dbe9@suse.com>
On Thu, Nov 30, 2023 at 10:38:09AM +0100, Oliver Neukum wrote:
> On 24.11.23 12:53, Simon Horman wrote:
> >
> >
> > I think it would be useful to include information along the lines
> > of the above in the patch description.
>
> Hi,
>
> I see why you want this information to be available.
> So I thought about it and I think this should be
> either in Documentation or in a comment in usbnet,
> so that new drivers include the necessary checks
> from the start. What do you think?
Hi Oliver,
yes, now you mention it that does seem appropriate.
And I don't think that doing so gates this patch.
Reviewed-by: Simon Horman <horms@kernel.org>
--
pw-bot: under-review
next prev parent reply other threads:[~2023-11-30 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 9:52 [PATCHv2] USB: gl620a: check for rx buffer overflow Oliver Neukum
2023-11-22 9:55 ` Sergey Shtylyov
2023-11-22 10:04 ` Oliver Neukum
2023-11-22 10:07 ` Sergei Shtylyov
2023-11-22 10:20 ` Oliver Neukum
2023-11-24 11:53 ` Simon Horman
2023-11-30 9:38 ` Oliver Neukum
2023-11-30 16:42 ` Simon Horman [this message]
2023-12-05 8:04 ` Paolo Abeni
2023-12-05 10:21 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130164257.GD32077@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dmitry.bezrukov@aquantia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcinguy@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.