All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@infradead.org, ming.lei@redhat.com, axboe@kernel.dk,
	roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com,
	joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com,
	hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
	jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com,
	josef@toxicpanda.com, dsterba@suse.com, brauner@kernel.org,
	nico@fluxnic.net, xiang@kernel.org, chao@kernel.org,
	tytso@mit.edu, adilger.kernel@dilger.ca, agruenba@redhat.com,
	jack@suse.com, konishi.ryusuke@gmail.com, dchinner@redhat.com,
	linux@weissschuh.net, min15.li@samsung.com, yukuai3@huawei.com,
	dlemoal@kernel.org, willy@infradead.org,
	akpm@linux-foundation.org, hare@suse.de, p.raghav@samsung.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
	gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' from block_device
Date: Mon, 27 Nov 2023 06:47:37 +0000	[thread overview]
Message-ID: <20231127064737.GH38156@ZenIV> (raw)
In-Reply-To: <20231127062116.2355129-1-yukuai1@huaweicloud.com>

On Mon, Nov 27, 2023 at 02:21:00PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v2:
>  - split different portions into different patches, as greg k-h
>  suggested.
>  - use container_of() instead of "bdev + 1" to get the address of
>  bd_inode in the new helper, as grep k-h suggested.

You might have misinterpreted gregkh - in your place I would rather
do a one-patch never-rebased branch (introduction of bdev_inode() in
form that returns bdev->bd_inode), with followup in your branch that
switches it to your variant.  Then conversions of ->bd_inode users,
to be either picked by individual filesystems of staying in your branch.
Any filesystem tree could merge from your never-rebased branch, after
which they could switch their ->bd_inode uses to the new helper, without
introducing any bisection hazards or interdependencies.
After the next -rc1, once all ->bd_inode users are gone from the tree -
remove the field.

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hoeppner@linux.ibm.com, vigneshr@ti.com, yi.zhang@huawei.com,
	linux-kernel@vger.kernel.org, gfs2@lists.linux.dev, clm@fb.com,
	adilger.kernel@dilger.ca, miquel.raynal@bootlin.com,
	agordeev@linux.ibm.com, linux-s390@vger.kernel.org,
	linux-nilfs@vger.kernel.org, agruenba@redhat.com,
	linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org,
	richard@nod.at, willy@infradead.org, hch@infradead.org,
	xen-devel@lists.xenproject.org, yukuai3@huawei.com,
	linux-ext4@vger.kernel.org, jejb@linux.ibm.com,
	p.raghav@samsung.com, gor@linux.ibm.com, hca@linux.ibm.com,
	joern@lazybastard.org, josef@toxicpanda.com, colyli@suse.de,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	dlemoal@kernel.org, sth@linux.ibm.com, dchinner@redhat.com,
	dsterba@suse.com, ming.lei@redhat.com, konishi.ryusuke@gmail.com,
	axboe@kernel.dk, brauner@kernel.org, tytso@mit.edu,
	martin.petersen@oracle.com, nico@fluxnic.net,
	linux-erofs@lists.ozlabs.org, yangerkun@huawei.com,
	linux@weissschuh.net, kent.overstreet@gma il.com, hare@suse.de,
	jack@suse.com, linux-fsdevel@vger.kernel.org,
	linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
	min15.li@samsung.com, linux-btrfs@vger.kernel.org,
	roger.pau@citrix.com
Subject: Re: [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' from block_device
Date: Mon, 27 Nov 2023 06:47:37 +0000	[thread overview]
Message-ID: <20231127064737.GH38156@ZenIV> (raw)
In-Reply-To: <20231127062116.2355129-1-yukuai1@huaweicloud.com>

On Mon, Nov 27, 2023 at 02:21:00PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v2:
>  - split different portions into different patches, as greg k-h
>  suggested.
>  - use container_of() instead of "bdev + 1" to get the address of
>  bd_inode in the new helper, as grep k-h suggested.

You might have misinterpreted gregkh - in your place I would rather
do a one-patch never-rebased branch (introduction of bdev_inode() in
form that returns bdev->bd_inode), with followup in your branch that
switches it to your variant.  Then conversions of ->bd_inode users,
to be either picked by individual filesystems of staying in your branch.
Any filesystem tree could merge from your never-rebased branch, after
which they could switch their ->bd_inode uses to the new helper, without
introducing any bisection hazards or interdependencies.
After the next -rc1, once all ->bd_inode users are gone from the tree -
remove the field.

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@infradead.org, ming.lei@redhat.com, axboe@kernel.dk,
	roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com,
	joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com,
	hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
	jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com,
	josef@toxicpanda.com, dsterba@suse.com, brauner@kernel.org,
	nico@fluxnic.net, xiang@kernel.org, chao@kernel.org,
	tytso@mit.edu, adilger.kernel@dilger.ca, agruenba@redhat.com,
	jack@suse.com, konishi.ryusuke@gmail.com, dchinner@redhat.com,
	linux@weissschuh.net, min15.li@samsung.com, yukuai3@huawei.com,
	dlemoal@kernel.org, willy@infradead.org,
	akpm@linux-foundation.org, hare@suse.de, p.raghav@samsung.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
	gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' from block_device
Date: Mon, 27 Nov 2023 06:47:37 +0000	[thread overview]
Message-ID: <20231127064737.GH38156@ZenIV> (raw)
In-Reply-To: <20231127062116.2355129-1-yukuai1@huaweicloud.com>

On Mon, Nov 27, 2023 at 02:21:00PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v2:
>  - split different portions into different patches, as greg k-h
>  suggested.
>  - use container_of() instead of "bdev + 1" to get the address of
>  bd_inode in the new helper, as grep k-h suggested.

You might have misinterpreted gregkh - in your place I would rather
do a one-patch never-rebased branch (introduction of bdev_inode() in
form that returns bdev->bd_inode), with followup in your branch that
switches it to your variant.  Then conversions of ->bd_inode users,
to be either picked by individual filesystems of staying in your branch.
Any filesystem tree could merge from your never-rebased branch, after
which they could switch their ->bd_inode uses to the new helper, without
introducing any bisection hazards or interdependencies.
After the next -rc1, once all ->bd_inode users are gone from the tree -
remove the field.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2023-11-27  6:48 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  6:21 [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' from block_device Yu Kuai
2023-11-27  6:21 ` Yu Kuai
2023-11-27  6:21 ` Yu Kuai
2023-11-27  6:21 ` [PATCH block/for-next v2 01/16] block: add a new helper to get inode " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  7:21   ` Christoph Hellwig
2023-11-27  7:21     ` Christoph Hellwig
2023-11-27  7:21     ` Christoph Hellwig
2023-11-27 13:07     ` Yu Kuai
2023-11-27 13:07       ` Yu Kuai
2023-11-27 13:07       ` Yu Kuai
2023-11-27 16:32       ` Christoph Hellwig
2023-11-27 16:32         ` Christoph Hellwig
2023-11-27 16:32         ` Christoph Hellwig
2023-11-28  1:35         ` Yu Kuai
2023-11-28  1:35           ` Yu Kuai
2023-11-28  1:35           ` Yu Kuai
2023-11-28  5:48           ` Christoph Hellwig
2023-11-28  5:48             ` Christoph Hellwig
2023-11-28  5:48             ` Christoph Hellwig
2023-11-27  6:21 ` [PATCH block/for-next v2 02/16] xen/blkback: use " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-28 10:05   ` Roger Pau Monné
2023-11-28 10:05     ` Roger Pau Monné
2023-11-28 10:05     ` Roger Pau Monné via Linux-erofs
2023-11-27  6:21 ` [PATCH block/for-next v2 03/16] bcache: " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21 ` [PATCH block/for-next v2 04/16] mtd: block2mtd: " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21 ` [PATCH block/for-next v2 05/16] s390/dasd: " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21 ` [PATCH block/for-next v2 06/16] scsicam: " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21 ` [PATCH block/for-next v2 07/16] bcachefs: " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:49   ` Kent Overstreet
2023-11-27  6:49     ` Kent Overstreet
2023-11-27  6:49     ` Kent Overstreet
2023-11-27  7:09   ` Damien Le Moal
2023-11-27  7:09     ` Damien Le Moal
2023-11-27  7:09     ` Damien Le Moal
2023-11-27  7:24     ` Kent Overstreet
2023-11-27  7:24       ` Kent Overstreet
2023-11-27  7:24       ` Kent Overstreet
2023-11-27  7:52       ` Yu Kuai
2023-11-27  7:52         ` Yu Kuai
2023-11-27  7:52         ` Yu Kuai
2023-11-27  6:21 ` [PATCH block/for-next v2 08/16] btrfs: " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21 ` [PATCH block/for-next v2 09/16] cramfs: " Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27  6:21   ` Yu Kuai
2023-11-27 15:28   ` Nicolas Pitre
2023-11-27  6:47 ` Al Viro [this message]
2023-11-27  6:47   ` [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' " Al Viro
2023-11-27  6:47   ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231127064737.GH38156@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=adilger.kernel@dilger.ca \
    --cc=agordeev@linux.ibm.com \
    --cc=agruenba@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=chao@kernel.org \
    --cc=clm@fb.com \
    --cc=colyli@suse.de \
    --cc=dchinner@redhat.com \
    --cc=dlemoal@kernel.org \
    --cc=dsterba@suse.com \
    --cc=gfs2@lists.linux.dev \
    --cc=gor@linux.ibm.com \
    --cc=hare@suse.de \
    --cc=hca@linux.ibm.com \
    --cc=hch@infradead.org \
    --cc=hoeppner@linux.ibm.com \
    --cc=jack@suse.com \
    --cc=jejb@linux.ibm.com \
    --cc=joern@lazybastard.org \
    --cc=josef@toxicpanda.com \
    --cc=kent.overstreet@gmail.com \
    --cc=konishi.ryusuke@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-bcachefs@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=martin.petersen@oracle.com \
    --cc=min15.li@samsung.com \
    --cc=ming.lei@redhat.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=nico@fluxnic.net \
    --cc=p.raghav@samsung.com \
    --cc=richard@nod.at \
    --cc=roger.pau@citrix.com \
    --cc=sth@linux.ibm.com \
    --cc=tytso@mit.edu \
    --cc=vigneshr@ti.com \
    --cc=willy@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xiang@kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.