From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Vignesh Raman <vignesh.raman@collabora.com>
Cc: daniels@collabora.com, linux-pci@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, helen.koike@collabora.com
Subject: Re: [Intel-gfx] [PATCH] PCI: qcom: Fix compile error
Date: Tue, 28 Nov 2023 12:21:04 +0530 [thread overview]
Message-ID: <20231128065104.GK3088@thinkpad> (raw)
In-Reply-To: <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com>
On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote:
> Hi Mani,
>
> On 28/11/23 10:44, Manivannan Sadhasivam wrote:
> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote:
> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument
> > > to acquire bus lock") has added an argument to acquire bus lock
> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it
> > > without this argument, resulting in below build error.
> > >
> >
> > Where do you see this error? That patch is not even merged. Looks like you are
> > sending the patch against some downstream tree.
>
> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip
>
> This commit is merged in drm-intel/topic/core-for-CI -
> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI
>
Okay. Since this patch is just for CI, please do not CC linux-pci as it causes
confusion.
- Mani
> Regards,
> Vignesh
--
மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Vignesh Raman <vignesh.raman@collabora.com>
Cc: intel-gfx@lists.freedesktop.org, helen.koike@collabora.com,
daniels@collabora.com, linux-pci@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom: Fix compile error
Date: Tue, 28 Nov 2023 12:21:04 +0530 [thread overview]
Message-ID: <20231128065104.GK3088@thinkpad> (raw)
In-Reply-To: <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com>
On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote:
> Hi Mani,
>
> On 28/11/23 10:44, Manivannan Sadhasivam wrote:
> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote:
> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument
> > > to acquire bus lock") has added an argument to acquire bus lock
> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it
> > > without this argument, resulting in below build error.
> > >
> >
> > Where do you see this error? That patch is not even merged. Looks like you are
> > sending the patch against some downstream tree.
>
> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip
>
> This commit is merged in drm-intel/topic/core-for-CI -
> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI
>
Okay. Since this patch is just for CI, please do not CC linux-pci as it causes
confusion.
- Mani
> Regards,
> Vignesh
--
மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Vignesh Raman <vignesh.raman@collabora.com>
Cc: daniels@collabora.com, linux-pci@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, helen.koike@collabora.com
Subject: Re: [PATCH] PCI: qcom: Fix compile error
Date: Tue, 28 Nov 2023 12:21:04 +0530 [thread overview]
Message-ID: <20231128065104.GK3088@thinkpad> (raw)
In-Reply-To: <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com>
On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote:
> Hi Mani,
>
> On 28/11/23 10:44, Manivannan Sadhasivam wrote:
> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote:
> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument
> > > to acquire bus lock") has added an argument to acquire bus lock
> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it
> > > without this argument, resulting in below build error.
> > >
> >
> > Where do you see this error? That patch is not even merged. Looks like you are
> > sending the patch against some downstream tree.
>
> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip
>
> This commit is merged in drm-intel/topic/core-for-CI -
> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI
>
Okay. Since this patch is just for CI, please do not CC linux-pci as it causes
confusion.
- Mani
> Regards,
> Vignesh
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-11-28 13:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 4:20 [Intel-gfx] [PATCH] PCI: qcom: Fix compile error Vignesh Raman
2023-11-28 4:20 ` Vignesh Raman
2023-11-28 4:20 ` Vignesh Raman
2023-11-28 5:14 ` [Intel-gfx] " Manivannan Sadhasivam
2023-11-28 5:14 ` Manivannan Sadhasivam
2023-11-28 5:14 ` Manivannan Sadhasivam
2023-11-28 6:14 ` [Intel-gfx] " Vignesh Raman
2023-11-28 6:14 ` Vignesh Raman
2023-11-28 6:14 ` Vignesh Raman
2023-11-28 6:51 ` Manivannan Sadhasivam [this message]
2023-11-28 6:51 ` Manivannan Sadhasivam
2023-11-28 6:51 ` Manivannan Sadhasivam
2023-11-28 7:47 ` [Intel-gfx] " Vignesh Raman
2023-11-28 7:47 ` Vignesh Raman
2023-11-28 7:47 ` Vignesh Raman
2023-11-28 13:03 ` [Intel-gfx] " Jani Nikula
2023-11-28 13:03 ` Jani Nikula
2023-11-29 13:57 ` [Intel-gfx] " Vignesh Raman
2023-11-29 13:57 ` Vignesh Raman
2023-11-28 10:39 ` [Intel-gfx] " Jani Nikula
2023-11-28 10:39 ` Jani Nikula
2023-11-28 10:45 ` [Intel-gfx] " Manivannan Sadhasivam
2023-11-28 10:45 ` Manivannan Sadhasivam
2023-11-28 10:45 ` Manivannan Sadhasivam
2023-11-29 2:08 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-11-29 2:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-29 9:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128065104.GK3088@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=helen.koike@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vignesh.raman@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.