* [Buildroot] [PATCH 1/1] package/openrc: fix uclibc build
@ 2023-11-27 21:31 Fabrice Fontaine
2023-11-28 16:16 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2023-11-27 21:31 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine, Michał Łyszczek
Fix the following uclibc build failures raised since bump to version
0.51 in commit 730c90faa3ec13ee1ead47113c9c5c7d3a8dac55:
../src/rc-abort/rc-abort.c: In function 'main':
../src/rc-abort/rc-abort.c:27:21: error: implicit declaration of function 'kill'; did you mean 'killpg'? [-Werror=implicit-function-declaration]
27 | if (kill(pid, SIGUSR1) != 0)
| ^~~~
| killpg
../src/libeinfo/libeinfo.c: In function 'colour_terminal':
../src/libeinfo/libeinfo.c:319:26: error: implicit declaration of function 'fileno' [-Werror=implicit-function-declaration]
319 | if (f && !isatty(fileno(f)))
| ^~~~~~
../src/librc/librc-misc.c: In function 'rc_getfile':
../src/librc/librc-misc.c:79:14: error: implicit declaration of function 'fileno'; did you mean 'd_fileno'? [-Werror=implicit-function-declaration]
79 | fd = fileno(fp);
| ^~~~~~
| d_fileno
../src/librc/librc-daemon.c: In function 'rc_service_daemons_crashed':
../src/librc/librc-daemon.c:633:37: error: implicit declaration of function 'kill'; did you mean 'killpg'? [-Werror=implicit-function-declaration]
633 | if (kill(pid, 0) == -1 && errno == ESRCH)
| ^~~~
| killpg
Fixes:
- http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
.../0008-meson.build-fix-uclibc-build.patch | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 package/openrc/0008-meson.build-fix-uclibc-build.patch
diff --git a/package/openrc/0008-meson.build-fix-uclibc-build.patch b/package/openrc/0008-meson.build-fix-uclibc-build.patch
new file mode 100644
index 0000000000..b01cb5f894
--- /dev/null
+++ b/package/openrc/0008-meson.build-fix-uclibc-build.patch
@@ -0,0 +1,53 @@
+From ce1f18ca178186821c812e0e965edd984557fed1 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Mon, 27 Nov 2023 22:22:56 +0100
+Subject: [PATCH] meson.build: fix uclibc build
+
+Fix the following uclibc build failures raised with meson because kill
+and fileno are not standard functions:
+
+../src/rc-abort/rc-abort.c: In function 'main':
+../src/rc-abort/rc-abort.c:27:21: error: implicit declaration of function 'kill'; did you mean 'killpg'? [-Werror=implicit-function-declaration]
+ 27 | if (kill(pid, SIGUSR1) != 0)
+ | ^~~~
+ | killpg
+
+../src/libeinfo/libeinfo.c: In function 'colour_terminal':
+../src/libeinfo/libeinfo.c:319:26: error: implicit declaration of function 'fileno' [-Werror=implicit-function-declaration]
+ 319 | if (f && !isatty(fileno(f)))
+ | ^~~~~~
+
+../src/librc/librc-misc.c: In function 'rc_getfile':
+../src/librc/librc-misc.c:79:14: error: implicit declaration of function 'fileno'; did you mean 'd_fileno'? [-Werror=implicit-function-declaration]
+ 79 | fd = fileno(fp);
+ | ^~~~~~
+ | d_fileno
+
+../src/librc/librc-daemon.c: In function 'rc_service_daemons_crashed':
+../src/librc/librc-daemon.c:633:37: error: implicit declaration of function 'kill'; did you mean 'killpg'? [-Werror=implicit-function-declaration]
+ 633 | if (kill(pid, 0) == -1 && errno == ESRCH)
+ | ^~~~
+ | killpg
+
+Fixes:
+ - http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Upstream: https://github.com/OpenRC/openrc/pull/674
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 9f4fc5ee5..9ab293c3a 100644
+--- a/meson.build
++++ b/meson.build
+@@ -149,7 +149,7 @@ else
+ endif
+
+ if os == 'Linux' or os == 'GNU-kFreeBSD'
+- cc_os_flags = ['-D_DEFAULT_SOURCE']
++ cc_os_flags = ['-D_DEFAULT_SOURCE', '-D_GNU_SOURCE']
+ elif os == 'FreeBSD'
+ cc_os_flags = ['-D_BSD_SOURCE']
+ elif os == 'GNU'
--
2.42.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/openrc: fix uclibc build
2023-11-27 21:31 [Buildroot] [PATCH 1/1] package/openrc: fix uclibc build Fabrice Fontaine
@ 2023-11-28 16:16 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2023-11-28 16:16 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Michał Łyszczek, buildroot
Fabrice, All,
On 2023-11-27 22:31 +0100, Fabrice Fontaine spake thusly:
> Fix the following uclibc build failures raised since bump to version
> 0.51 in commit 730c90faa3ec13ee1ead47113c9c5c7d3a8dac55:
[--SNIP--]
> Fixes:
> - http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Upstream: https://github.com/OpenRC/openrc/pull/674
It looks like upstream is not happy with this patch. Given the feedback
there, I think we'll unfortunately have to hide openrc away for uClibc,
until upstream has a proper fix.
Regards,
Yann E. MORIN.
> +---
> + meson.build | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/meson.build b/meson.build
> +index 9f4fc5ee5..9ab293c3a 100644
> +--- a/meson.build
> ++++ b/meson.build
> +@@ -149,7 +149,7 @@ else
> + endif
> +
> + if os == 'Linux' or os == 'GNU-kFreeBSD'
> +- cc_os_flags = ['-D_DEFAULT_SOURCE']
> ++ cc_os_flags = ['-D_DEFAULT_SOURCE', '-D_GNU_SOURCE']
> + elif os == 'FreeBSD'
> + cc_os_flags = ['-D_BSD_SOURCE']
> + elif os == 'GNU'
> --
> 2.42.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-28 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-27 21:31 [Buildroot] [PATCH 1/1] package/openrc: fix uclibc build Fabrice Fontaine
2023-11-28 16:16 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.