From: Conor Dooley <conor@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: Frank Li <frank.li@nxp.com>, "will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"irogers@google.com" <irogers@google.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"acme@kernel.org" <acme@kernel.org>,
"john.g.garry@oracle.com" <john.g.garry@oracle.com>,
"james.clark@arm.com" <james.clark@arm.com>,
"mike.leach@linaro.org" <mike.leach@linaro.org>,
"leo.yan@linaro.org" <leo.yan@linaro.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible
Date: Fri, 1 Dec 2023 16:16:59 +0000 [thread overview]
Message-ID: <20231201-pointer-statue-f30a42b8102e@spud> (raw)
In-Reply-To: <DB7PR04MB51460A715C6870642B6D7BBE8C81A@DB7PR04MB5146.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Fri, Dec 01, 2023 at 06:41:59AM +0000, Xu Yang wrote:
> Hi Conor,
>
> >
> > On Mon, Nov 27, 2023 at 03:32:06PM +0800, Xu Yang wrote:
> > > i.MX95 has a more precise counting capability than i.MX93. This will add
> > > a compatible for it.
> >
> > It is hard to tell from this comment, but I figure this "more precise
> > capability" is not an option you can enable, but instead makes the
> > programming model of this device different to that of the imx93?
>
> Actually, imx95 is compatible with imx93 except AXI ID filter capability.
> But for AXI ID filter, imx95 is using different registers and bits from
> imx93 for filter configuration.
This sounds like it conflicts with...
> To distinguish them, I need use different
> compatible because programming model cannot recognize which device is
> running.
>
> compatible = "fsl,imx95-ddr-pmu";
> compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";
...this. If drivers for the imx93 need changes to work on the imx95,
then `compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";` cannot be
used. If they will work, with only the new imx95 features being
non-functional, then you can use it.
> Both above compatible is okay for me. Therefore, "fsl,imx95-ddr-pmu" is needed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: Frank Li <frank.li@nxp.com>, "will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"irogers@google.com" <irogers@google.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"acme@kernel.org" <acme@kernel.org>,
"john.g.garry@oracle.com" <john.g.garry@oracle.com>,
"james.clark@arm.com" <james.clark@arm.com>,
"mike.leach@linaro.org" <mike.leach@linaro.org>,
"leo.yan@linaro.org" <leo.yan@linaro.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible
Date: Fri, 1 Dec 2023 16:16:59 +0000 [thread overview]
Message-ID: <20231201-pointer-statue-f30a42b8102e@spud> (raw)
In-Reply-To: <DB7PR04MB51460A715C6870642B6D7BBE8C81A@DB7PR04MB5146.eurprd04.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1272 bytes --]
On Fri, Dec 01, 2023 at 06:41:59AM +0000, Xu Yang wrote:
> Hi Conor,
>
> >
> > On Mon, Nov 27, 2023 at 03:32:06PM +0800, Xu Yang wrote:
> > > i.MX95 has a more precise counting capability than i.MX93. This will add
> > > a compatible for it.
> >
> > It is hard to tell from this comment, but I figure this "more precise
> > capability" is not an option you can enable, but instead makes the
> > programming model of this device different to that of the imx93?
>
> Actually, imx95 is compatible with imx93 except AXI ID filter capability.
> But for AXI ID filter, imx95 is using different registers and bits from
> imx93 for filter configuration.
This sounds like it conflicts with...
> To distinguish them, I need use different
> compatible because programming model cannot recognize which device is
> running.
>
> compatible = "fsl,imx95-ddr-pmu";
> compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";
...this. If drivers for the imx93 need changes to work on the imx95,
then `compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";` cannot be
used. If they will work, with only the new imx95 features being
non-functional, then you can use it.
> Both above compatible is okay for me. Therefore, "fsl,imx95-ddr-pmu" is needed.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-01 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 7:32 [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible Xu Yang
2023-11-27 7:32 ` Xu Yang
2023-11-27 7:32 ` [PATCH 2/3] perf: imx_perf: add support for i.MX95 platform Xu Yang
2023-11-27 7:32 ` Xu Yang
2023-11-27 15:25 ` Frank Li
2023-11-27 15:25 ` Frank Li
2023-12-01 8:56 ` Xu Yang
2023-12-01 8:56 ` Xu Yang
2023-11-27 7:32 ` [PATCH 3/3] perf vendor events arm64:: Add i.MX95 DDR Performane Monitor metrics Xu Yang
2023-11-27 7:32 ` Xu Yang
2023-11-27 17:36 ` [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible Conor Dooley
2023-11-27 17:36 ` Conor Dooley
2023-12-01 6:41 ` [EXT] " Xu Yang
2023-12-01 6:41 ` Xu Yang
2023-12-01 16:16 ` Conor Dooley [this message]
2023-12-01 16:16 ` Conor Dooley
2023-12-06 1:42 ` Xu Yang
2023-12-06 1:42 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201-pointer-statue-f30a42b8102e@spud \
--to=conor@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.