From: Simon Horman <horms@kernel.org>
To: Jan Glaza <jan.glaza@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Sachin Bahadur <sachin.bahadur@intel.com>,
Andrii Staikov <andrii.staikov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: ice_base.c: Add const modifier to params and vars
Date: Fri, 1 Dec 2023 09:58:48 +0000 [thread overview]
Message-ID: <20231201095848.GT32077@kernel.org> (raw)
In-Reply-To: <20231129073611.8816-1-jan.glaza@intel.com>
On Wed, Nov 29, 2023 at 02:36:11AM -0500, Jan Glaza wrote:
> Add const modifier to function parameters and variables where appropriate
> in ice_base.c and corresponding declarations in ice_base.h.
>
> The reason for starting the change is that read-only pointers should be
> marked as const when possible to allow for smoother and more optimal code
> generation and optimization as well as allowing the compiler to warn the
> developer about potentially unwanted modifications, while not carrying
> noticable negative impact.
Hi Jan,
it's probably not worth respinning for this, but: noticeable
>
> Reviewed-by: Andrii Staikov <andrii.staikov@intel.com>
> Reviewed-by: Sachin Bahadur <sachin.bahadur@intel.com>
> Signed-off-by: Jan Glaza <jan.glaza@intel.com>
> ---
> This change is done in one file to get comment feedback and, if positive,
> will be rolled out across the entire ice driver code.
The nit above notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jan Glaza <jan.glaza@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Andrii Staikov <andrii.staikov@intel.com>,
Sachin Bahadur <sachin.bahadur@intel.com>
Subject: Re: [PATCH iwl-next] ice: ice_base.c: Add const modifier to params and vars
Date: Fri, 1 Dec 2023 09:58:48 +0000 [thread overview]
Message-ID: <20231201095848.GT32077@kernel.org> (raw)
In-Reply-To: <20231129073611.8816-1-jan.glaza@intel.com>
On Wed, Nov 29, 2023 at 02:36:11AM -0500, Jan Glaza wrote:
> Add const modifier to function parameters and variables where appropriate
> in ice_base.c and corresponding declarations in ice_base.h.
>
> The reason for starting the change is that read-only pointers should be
> marked as const when possible to allow for smoother and more optimal code
> generation and optimization as well as allowing the compiler to warn the
> developer about potentially unwanted modifications, while not carrying
> noticable negative impact.
Hi Jan,
it's probably not worth respinning for this, but: noticeable
>
> Reviewed-by: Andrii Staikov <andrii.staikov@intel.com>
> Reviewed-by: Sachin Bahadur <sachin.bahadur@intel.com>
> Signed-off-by: Jan Glaza <jan.glaza@intel.com>
> ---
> This change is done in one file to get comment feedback and, if positive,
> will be rolled out across the entire ice driver code.
The nit above notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-12-01 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 7:36 [Intel-wired-lan] [PATCH iwl-next] ice: ice_base.c: Add const modifier to params and vars Jan Glaza
2023-11-29 7:36 ` Jan Glaza
2023-12-01 9:58 ` Simon Horman [this message]
2023-12-01 9:58 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201095848.GT32077@kernel.org \
--to=horms@kernel.org \
--cc=andrii.staikov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.glaza@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sachin.bahadur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.