From: Jakub Kicinski <kuba@kernel.org>
To: Haoran Liu <liuhaoran14@163.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
heiko@sntech.de, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net/ethernet] arc_emac: Add error handling in emac_rockchip_probe
Date: Fri, 1 Dec 2023 20:11:46 -0800 [thread overview]
Message-ID: <20231201201146.12aa16df@kernel.org> (raw)
In-Reply-To: <20231130031318.35850-1-liuhaoran14@163.com>
On Wed, 29 Nov 2023 19:13:18 -0800 Haoran Liu wrote:
> Although the error addressed by this patch may not occur in the current
> environment, I still suggest implementing these error handling routines
> if the function is not highly time-sensitive. As the environment evolves
> or the code gets reused in different contexts, there's a possibility that
> these errors might occur. Addressing them now can prevent potential
> debugging efforts in the future, which could be quite resource-intensive.
Please skip this pointless boilerplate.
> match = of_match_node(emac_rockchip_dt_ids, dev->of_node);
> + if (!match) {
> + dev_err(dev, "No matching device found\n");
> + return -ENODEV;
"device" and ENODEV are not right here.
--
pw-bot: cr
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Haoran Liu <liuhaoran14@163.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
heiko@sntech.de, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net/ethernet] arc_emac: Add error handling in emac_rockchip_probe
Date: Fri, 1 Dec 2023 20:11:46 -0800 [thread overview]
Message-ID: <20231201201146.12aa16df@kernel.org> (raw)
In-Reply-To: <20231130031318.35850-1-liuhaoran14@163.com>
On Wed, 29 Nov 2023 19:13:18 -0800 Haoran Liu wrote:
> Although the error addressed by this patch may not occur in the current
> environment, I still suggest implementing these error handling routines
> if the function is not highly time-sensitive. As the environment evolves
> or the code gets reused in different contexts, there's a possibility that
> these errors might occur. Addressing them now can prevent potential
> debugging efforts in the future, which could be quite resource-intensive.
Please skip this pointless boilerplate.
> match = of_match_node(emac_rockchip_dt_ids, dev->of_node);
> + if (!match) {
> + dev_err(dev, "No matching device found\n");
> + return -ENODEV;
"device" and ENODEV are not right here.
--
pw-bot: cr
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Haoran Liu <liuhaoran14@163.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
heiko@sntech.de, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net/ethernet] arc_emac: Add error handling in emac_rockchip_probe
Date: Fri, 1 Dec 2023 20:11:46 -0800 [thread overview]
Message-ID: <20231201201146.12aa16df@kernel.org> (raw)
In-Reply-To: <20231130031318.35850-1-liuhaoran14@163.com>
On Wed, 29 Nov 2023 19:13:18 -0800 Haoran Liu wrote:
> Although the error addressed by this patch may not occur in the current
> environment, I still suggest implementing these error handling routines
> if the function is not highly time-sensitive. As the environment evolves
> or the code gets reused in different contexts, there's a possibility that
> these errors might occur. Addressing them now can prevent potential
> debugging efforts in the future, which could be quite resource-intensive.
Please skip this pointless boilerplate.
> match = of_match_node(emac_rockchip_dt_ids, dev->of_node);
> + if (!match) {
> + dev_err(dev, "No matching device found\n");
> + return -ENODEV;
"device" and ENODEV are not right here.
--
pw-bot: cr
next prev parent reply other threads:[~2023-12-02 4:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 3:13 [PATCH] [net/ethernet] arc_emac: Add error handling in emac_rockchip_probe Haoran Liu
2023-11-30 3:13 ` Haoran Liu
2023-11-30 3:13 ` Haoran Liu
2023-12-02 4:11 ` Jakub Kicinski [this message]
2023-12-02 4:11 ` Jakub Kicinski
2023-12-02 4:11 ` Jakub Kicinski
2023-12-06 5:35 ` Dan Carpenter
2023-12-06 5:35 ` Dan Carpenter
2023-12-06 5:35 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2023-12-05 17:34 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201201146.12aa16df@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=liuhaoran14@163.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.