From: Simon Horman <horms@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: Wojciech Drewek <wojciech.drewek@intel.com>,
netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
intel-wired-lan@lists.osuosl.org, Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH v5 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs
Date: Sun, 3 Dec 2023 11:41:39 +0000 [thread overview]
Message-ID: <20231203114139.GG50400@kernel.org> (raw)
In-Reply-To: <20231124150343.81520-3-ivecera@redhat.com>
On Fri, Nov 24, 2023 at 04:03:40PM +0100, Ivan Vecera wrote:
> Introduce i40e_for_each_vsi() and i40e_for_each_veb() helper
> macros and use them to iterate relevant arrays.
>
> Replace pattern:
> for (i = 0; i < pf->num_alloc_vsi; i++)
> by:
> i40e_for_each_vsi(pf, i, vsi)
>
> and pattern:
> for (i = 0; i < I40E_MAX_VEB; i++)
> by
> i40e_for_each_veb(pf, i, veb)
>
> These macros also check if array item pf->vsi[i] or pf->veb[i]
> are not NULL and skip such items so we can remove redundant
> checks from loop bodies.
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: intel-wired-lan@lists.osuosl.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
mschmidt@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v5 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs
Date: Sun, 3 Dec 2023 11:41:39 +0000 [thread overview]
Message-ID: <20231203114139.GG50400@kernel.org> (raw)
In-Reply-To: <20231124150343.81520-3-ivecera@redhat.com>
On Fri, Nov 24, 2023 at 04:03:40PM +0100, Ivan Vecera wrote:
> Introduce i40e_for_each_vsi() and i40e_for_each_veb() helper
> macros and use them to iterate relevant arrays.
>
> Replace pattern:
> for (i = 0; i < pf->num_alloc_vsi; i++)
> by:
> i40e_for_each_vsi(pf, i, vsi)
>
> and pattern:
> for (i = 0; i < I40E_MAX_VEB; i++)
> by
> i40e_for_each_veb(pf, i, veb)
>
> These macros also check if array item pf->vsi[i] or pf->veb[i]
> are not NULL and skip such items so we can remove redundant
> checks from loop bodies.
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-12-03 11:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 15:03 [Intel-wired-lan] [PATCH iwl-next v5 0/5] i40e: Simplify VSI and VEB handling Ivan Vecera
2023-11-24 15:03 ` Ivan Vecera
2023-11-24 15:03 ` [Intel-wired-lan] [PATCH v5 1/5] i40e: Use existing helper to find flow director VSI Ivan Vecera
2023-11-24 15:03 ` Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-30 5:23 ` Pucha, HimasekharX Reddy
2023-12-03 11:41 ` Simon Horman
2023-12-03 11:41 ` Simon Horman
2023-11-24 15:03 ` [Intel-wired-lan] [PATCH v5 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs Ivan Vecera
2023-11-24 15:03 ` Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-30 5:23 ` Pucha, HimasekharX Reddy
2023-12-03 11:41 ` Simon Horman [this message]
2023-12-03 11:41 ` Simon Horman
2023-11-24 15:03 ` [Intel-wired-lan] [PATCH v5 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them Ivan Vecera
2023-11-24 15:03 ` Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-30 5:23 ` Pucha, HimasekharX Reddy
2023-12-03 11:41 ` Simon Horman
2023-12-03 11:41 ` Simon Horman
2023-11-24 15:03 ` [Intel-wired-lan] [PATCH v5 4/5] i40e: Fix broken support for floating VEBs Ivan Vecera
2023-11-24 15:03 ` Ivan Vecera
2023-11-27 8:43 ` [Intel-wired-lan] " Dan Carpenter
2023-11-27 8:43 ` Dan Carpenter
2023-11-29 8:38 ` [Intel-wired-lan] " Ivan Vecera
2023-11-29 8:38 ` Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-30 5:23 ` Pucha, HimasekharX Reddy
2023-12-03 16:22 ` Simon Horman
2023-12-03 16:22 ` Simon Horman
2023-11-24 15:03 ` [Intel-wired-lan] [PATCH v5 5/5] i40e: Remove VEB recursion Ivan Vecera
2023-11-24 15:03 ` Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-30 5:23 ` Pucha, HimasekharX Reddy
2023-12-03 16:22 ` Simon Horman
2023-12-03 16:22 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231203114139.GG50400@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.