From: Maxime Ripard <mripard@kernel.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <mripard@kernel.org>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH 5/5] drm/todo: Add entry to rename drm_atomic_state
Date: Mon, 4 Dec 2023 13:17:07 +0100 [thread overview]
Message-ID: <20231204121707.3647961-5-mripard@kernel.org> (raw)
In-Reply-To: <20231204121707.3647961-1-mripard@kernel.org>
The name of the structure drm_atomic_state is confusing. Let's add an
entry to our todo list to rename it.
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Documentation/gpu/todo.rst | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index b62c7fa0c2bc..fe95aea89d67 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -120,6 +120,24 @@ Contact: Daniel Vetter, respective driver maintainers
Level: Advanced
+Rename drm_atomic_state
+-----------------------
+
+The KMS framework uses two slightly different definitions for the ``state``
+concept. For a given object (plane, CRTC, encoder, etc., so
+``drm_$OBJECT_state``), the state is the entire state of that object. However,
+at the device level, ``drm_atomic_state`` refers to a state update for a
+limited number of objects.
+
+The state isn't the entire device state anymore, but only the full state of
+some objects in that device. This is confusing to newcomers, and
+``drm_atomic_state`` should be renamed to something clearer like
+``drm_atomic_update``.
+
+Contact: Maxime Ripard <mripard@kernel.org>
+
+Level: Advanced
+
Fallout from atomic KMS
-----------------------
--
2.43.0
next prev parent reply other threads:[~2023-12-04 12:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 12:17 [PATCH 1/5] drm/atomic: Move the drm_atomic_state field doc inline Maxime Ripard
2023-12-04 12:17 ` [PATCH 2/5] drm/atomic: Remove inexistent reference Maxime Ripard
2023-12-05 13:32 ` [2/5] " Sui Jingfeng
2023-12-07 21:40 ` [PATCH 2/5] " Daniel Vetter
2023-12-04 12:17 ` [PATCH 3/5] drm/atomic: Rework the object doc a bit Maxime Ripard
2023-12-05 13:52 ` [3/5] " Sui Jingfeng
2023-12-07 21:41 ` [PATCH 3/5] " Daniel Vetter
2023-12-04 12:17 ` [PATCH 4/5] drm/atomic: Make the drm_atomic_state documentation less ambiguous Maxime Ripard
2023-12-05 8:51 ` Pekka Paalanen
2023-12-05 9:15 ` Pekka Paalanen
2023-12-07 13:50 ` Maxime Ripard
2023-12-07 14:27 ` Maxime Ripard
2023-12-08 8:08 ` Pekka Paalanen
2023-12-08 12:25 ` Maxime Ripard
2023-12-08 13:59 ` Pekka Paalanen
2023-12-08 15:20 ` Maxime Ripard
2023-12-11 9:22 ` Pekka Paalanen
2023-12-07 21:48 ` Daniel Vetter
2023-12-04 12:17 ` Maxime Ripard [this message]
2023-12-07 21:51 ` [PATCH 5/5] drm/todo: Add entry to rename drm_atomic_state Daniel Vetter
2023-12-05 13:42 ` [1/5] drm/atomic: Move the drm_atomic_state field doc inline Sui Jingfeng
2023-12-07 21:34 ` [PATCH 1/5] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204121707.3647961-5-mripard@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.