From: Daniel Vetter <daniel@ffwll.ch>
To: Maxime Ripard <mripard@kernel.org>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH 2/5] drm/atomic: Remove inexistent reference
Date: Thu, 7 Dec 2023 22:40:04 +0100 [thread overview]
Message-ID: <ZXI7tPmDWAlNT8Kw@phenom.ffwll.local> (raw)
In-Reply-To: <20231204121707.3647961-2-mripard@kernel.org>
On Mon, Dec 04, 2023 at 01:17:04PM +0100, Maxime Ripard wrote:
> The num_connectors field documentation mentions a connector_states field
> that has never been part of this structure.
Not entirely correct, this is an oversight from 63e83c1dba54 ("drm:
Consolidate connector arrays in drm_atomic_state"). With the commit
message suitably updated.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
> include/drm/drm_atomic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> index 2a08030fcd75..13cecdc1257d 100644
> --- a/include/drm/drm_atomic.h
> +++ b/include/drm/drm_atomic.h
> @@ -413,7 +413,7 @@ struct drm_atomic_state {
> struct __drm_crtcs_state *crtcs;
>
> /**
> - * @num_connector: size of the @connectors and @connector_states arrays
> + * @num_connector: size of the @connectors array
> */
> int num_connector;
>
> --
> 2.43.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2023-12-07 21:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 12:17 [PATCH 1/5] drm/atomic: Move the drm_atomic_state field doc inline Maxime Ripard
2023-12-04 12:17 ` [PATCH 2/5] drm/atomic: Remove inexistent reference Maxime Ripard
2023-12-05 13:32 ` [2/5] " Sui Jingfeng
2023-12-07 21:40 ` Daniel Vetter [this message]
2023-12-04 12:17 ` [PATCH 3/5] drm/atomic: Rework the object doc a bit Maxime Ripard
2023-12-05 13:52 ` [3/5] " Sui Jingfeng
2023-12-07 21:41 ` [PATCH 3/5] " Daniel Vetter
2023-12-04 12:17 ` [PATCH 4/5] drm/atomic: Make the drm_atomic_state documentation less ambiguous Maxime Ripard
2023-12-05 8:51 ` Pekka Paalanen
2023-12-05 9:15 ` Pekka Paalanen
2023-12-07 13:50 ` Maxime Ripard
2023-12-07 14:27 ` Maxime Ripard
2023-12-08 8:08 ` Pekka Paalanen
2023-12-08 12:25 ` Maxime Ripard
2023-12-08 13:59 ` Pekka Paalanen
2023-12-08 15:20 ` Maxime Ripard
2023-12-11 9:22 ` Pekka Paalanen
2023-12-07 21:48 ` Daniel Vetter
2023-12-04 12:17 ` [PATCH 5/5] drm/todo: Add entry to rename drm_atomic_state Maxime Ripard
2023-12-07 21:51 ` Daniel Vetter
2023-12-05 13:42 ` [1/5] drm/atomic: Move the drm_atomic_state field doc inline Sui Jingfeng
2023-12-07 21:34 ` [PATCH 1/5] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXI7tPmDWAlNT8Kw@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=mripard@kernel.org \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.