From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, sboyd@kernel.org,
mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, daniel@ffwll.ch,
airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com,
neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH V2 02/10] drm/panel: himax-hx8394: Drop shutdown logic
Date: Mon, 4 Dec 2023 12:57:11 -0600 [thread overview]
Message-ID: <20231204185719.569021-3-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231204185719.569021-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
The driver shutdown is duplicate as it calls drm_unprepare and
drm_disable which are called anyway when associated drivers are
shutdown/removed.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/gpu/drm/panel/panel-himax-hx8394.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c
index 3823ff388b96..d8e590d5e1da 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx8394.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c
@@ -390,27 +390,11 @@ static int hx8394_probe(struct mipi_dsi_device *dsi)
return 0;
}
-static void hx8394_shutdown(struct mipi_dsi_device *dsi)
-{
- struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);
- int ret;
-
- ret = drm_panel_disable(&ctx->panel);
- if (ret < 0)
- dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret);
-
- ret = drm_panel_unprepare(&ctx->panel);
- if (ret < 0)
- dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret);
-}
-
static void hx8394_remove(struct mipi_dsi_device *dsi)
{
struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);
int ret;
- hx8394_shutdown(dsi);
-
ret = mipi_dsi_detach(dsi);
if (ret < 0)
dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
@@ -427,7 +411,6 @@ MODULE_DEVICE_TABLE(of, hx8394_of_match);
static struct mipi_dsi_driver hx8394_driver = {
.probe = hx8394_probe,
.remove = hx8394_remove,
- .shutdown = hx8394_shutdown,
.driver = {
.name = DRV_NAME,
.of_match_table = hx8394_of_match,
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, sboyd@kernel.org,
mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, daniel@ffwll.ch,
airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com,
neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH V2 02/10] drm/panel: himax-hx8394: Drop shutdown logic
Date: Mon, 4 Dec 2023 12:57:11 -0600 [thread overview]
Message-ID: <20231204185719.569021-3-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231204185719.569021-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
The driver shutdown is duplicate as it calls drm_unprepare and
drm_disable which are called anyway when associated drivers are
shutdown/removed.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/gpu/drm/panel/panel-himax-hx8394.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c
index 3823ff388b96..d8e590d5e1da 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx8394.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c
@@ -390,27 +390,11 @@ static int hx8394_probe(struct mipi_dsi_device *dsi)
return 0;
}
-static void hx8394_shutdown(struct mipi_dsi_device *dsi)
-{
- struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);
- int ret;
-
- ret = drm_panel_disable(&ctx->panel);
- if (ret < 0)
- dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret);
-
- ret = drm_panel_unprepare(&ctx->panel);
- if (ret < 0)
- dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret);
-}
-
static void hx8394_remove(struct mipi_dsi_device *dsi)
{
struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);
int ret;
- hx8394_shutdown(dsi);
-
ret = mipi_dsi_detach(dsi);
if (ret < 0)
dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
@@ -427,7 +411,6 @@ MODULE_DEVICE_TABLE(of, hx8394_of_match);
static struct mipi_dsi_driver hx8394_driver = {
.probe = hx8394_probe,
.remove = hx8394_remove,
- .shutdown = hx8394_shutdown,
.driver = {
.name = DRV_NAME,
.of_match_table = hx8394_of_match,
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
Chris Morgan <macromorgan@hotmail.com>,
krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org,
sboyd@kernel.org, sam@ravnborg.org, mturquette@baylibre.com,
javierm@redhat.com, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, mripard@kernel.org, tzimmermann@suse.de,
quic_jesszhan@quicinc.com, linux-clk@vger.kernel.org
Subject: [PATCH V2 02/10] drm/panel: himax-hx8394: Drop shutdown logic
Date: Mon, 4 Dec 2023 12:57:11 -0600 [thread overview]
Message-ID: <20231204185719.569021-3-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231204185719.569021-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
The driver shutdown is duplicate as it calls drm_unprepare and
drm_disable which are called anyway when associated drivers are
shutdown/removed.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/gpu/drm/panel/panel-himax-hx8394.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c
index 3823ff388b96..d8e590d5e1da 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx8394.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c
@@ -390,27 +390,11 @@ static int hx8394_probe(struct mipi_dsi_device *dsi)
return 0;
}
-static void hx8394_shutdown(struct mipi_dsi_device *dsi)
-{
- struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);
- int ret;
-
- ret = drm_panel_disable(&ctx->panel);
- if (ret < 0)
- dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret);
-
- ret = drm_panel_unprepare(&ctx->panel);
- if (ret < 0)
- dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret);
-}
-
static void hx8394_remove(struct mipi_dsi_device *dsi)
{
struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);
int ret;
- hx8394_shutdown(dsi);
-
ret = mipi_dsi_detach(dsi);
if (ret < 0)
dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
@@ -427,7 +411,6 @@ MODULE_DEVICE_TABLE(of, hx8394_of_match);
static struct mipi_dsi_driver hx8394_driver = {
.probe = hx8394_probe,
.remove = hx8394_remove,
- .shutdown = hx8394_shutdown,
.driver = {
.name = DRV_NAME,
.of_match_table = hx8394_of_match,
--
2.34.1
next prev parent reply other threads:[~2023-12-04 18:57 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 18:57 [PATCH V2 00/10] rockchip: Add Powkiddy X55 Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` [PATCH V2 01/10] drm/panel: himax-hx8394: Drop prepare/unprepare tracking Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-05 7:55 ` neil.armstrong
2023-12-05 7:55 ` neil.armstrong
2023-12-05 7:55 ` neil.armstrong
2023-12-04 18:57 ` Chris Morgan [this message]
2023-12-04 18:57 ` [PATCH V2 02/10] drm/panel: himax-hx8394: Drop shutdown logic Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-05 7:57 ` neil.armstrong
2023-12-05 7:57 ` neil.armstrong
2023-12-05 7:57 ` neil.armstrong
2023-12-04 18:57 ` [PATCH V2 03/10] dt-bindings: display: Document Himax HX8394 panel rotation Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` [PATCH V2 04/10] drm/panel: himax-hx8394: Add Panel Rotation Support Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-05 7:56 ` neil.armstrong
2023-12-05 7:56 ` neil.armstrong
2023-12-05 7:56 ` neil.armstrong
2023-12-04 18:57 ` [PATCH V2 05/10] dt-bindings: display: himax-hx8394: Add Powkiddy X55 panel Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` [PATCH V2 06/10] drm/panel: himax-hx8394: Add Support for " Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-05 7:57 ` neil.armstrong
2023-12-05 7:57 ` neil.armstrong
2023-12-05 7:57 ` neil.armstrong
2023-12-04 18:57 ` [PATCH V2 07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` [PATCH V2 08/10] clk: rockchip: rk3568: Add PLL rate for 126.4MHz Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` [PATCH V2 09/10] dt-bindings: arm: rockchip: Add Powkiddy X55 Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` [PATCH V2 10/10] arm64: dts: " Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-04 18:57 ` Chris Morgan
2023-12-05 8:26 ` [PATCH V2 00/10] " Neil Armstrong
2023-12-05 8:26 ` Neil Armstrong
2023-12-05 8:26 ` Neil Armstrong
2023-12-05 8:28 ` Neil Armstrong
2023-12-05 8:28 ` Neil Armstrong
2023-12-05 8:28 ` Neil Armstrong
2023-12-05 9:41 ` Heiko Stübner
2023-12-05 9:41 ` Heiko Stübner
2023-12-05 9:41 ` Heiko Stübner
2023-12-05 9:52 ` (subset) " Heiko Stuebner
2023-12-05 9:52 ` Heiko Stuebner
2023-12-05 9:52 ` Heiko Stuebner
2023-12-05 9:59 ` Heiko Stuebner
2023-12-05 9:59 ` Heiko Stuebner
2023-12-05 9:59 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204185719.569021-3-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=macromorgan@hotmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.