From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH net] net: core: synchronize link-watch when carrier is queried
Date: Tue, 5 Dec 2023 16:11:03 -0800 [thread overview]
Message-ID: <20231205161103.3bec2036@kernel.org> (raw)
In-Reply-To: <20231204214706.303c62768415.I1caedccae72ee5a45c9085c5eb49c145ce1c0dd5@changeid>
On Mon, 4 Dec 2023 21:47:07 +0100 Johannes Berg wrote:
> There are multiple ways to query for the carrier state: through
> rtnetlink, sysfs, and (possibly) ethtool. Synchronize linkwatch
> work before these operations so that we don't have a situation
> where userspace queries the carrier state between the driver's
> carrier off->on transition and linkwatch running and expects it
> to work, when really (at least) TX cannot work until linkwatch
> has run.
>
> I previously posted a longer explanation of how this applies to
> wireless [1] but with this wireless can simply query the state
> before sending data, to ensure the kernel is ready for it.
Are you okay with net-next?
The previous behavior is, herm... well established.
next prev parent reply other threads:[~2023-12-06 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 20:47 [PATCH net] net: core: synchronize link-watch when carrier is queried Johannes Berg
2023-12-05 8:32 ` Jiri Pirko
2023-12-05 10:28 ` Johannes Berg
2023-12-05 11:21 ` Jiri Pirko
2023-12-06 0:11 ` Jakub Kicinski [this message]
2023-12-06 0:12 ` Johannes Berg
2023-12-06 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205161103.3bec2036@kernel.org \
--to=kuba@kernel.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.