From: Jiri Pirko <jiri@resnulli.us>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: core: synchronize link-watch when carrier is queried
Date: Tue, 5 Dec 2023 12:21:12 +0100 [thread overview]
Message-ID: <ZW8HqIgkRwsicjNR@nanopsycho> (raw)
In-Reply-To: <48f260af66acc811d97eb64ff1b04ecce5893755.camel@sipsolutions.net>
Tue, Dec 05, 2023 at 11:28:32AM CET, johannes@sipsolutions.net wrote:
>On Tue, 2023-12-05 at 09:32 +0100, Jiri Pirko wrote:
>> >
>> > + /* Synchronize the carrier state so we don't report a state
>> > + * that we're not actually going to honour immediately; if
>> > + * the driver just did a carrier off->on transition, we can
>> > + * only TX if link watch work has run, but without this we'd
>> > + * already report carrier on, even if it doesn't work yet.
>> > + */
>>
>> This comment is a bit harder to understand for me, but I eventually did
>> get it :)
>
>Do you want to propose different wording with your understanding? :)
Would not be better I'm afraid :)
>
>> Patch looks fine to me.
>
>Thanks :)
>
>johannes
next prev parent reply other threads:[~2023-12-05 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 20:47 [PATCH net] net: core: synchronize link-watch when carrier is queried Johannes Berg
2023-12-05 8:32 ` Jiri Pirko
2023-12-05 10:28 ` Johannes Berg
2023-12-05 11:21 ` Jiri Pirko [this message]
2023-12-06 0:11 ` Jakub Kicinski
2023-12-06 0:12 ` Johannes Berg
2023-12-06 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW8HqIgkRwsicjNR@nanopsycho \
--to=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.