Re: [PATCH v2 1/2] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

[kernel test robot <lkp@intel.com>]

Hi Dmitry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.7-rc4 next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-atomic-helper-rename-drm_atomic_helper_check_wb_encoder_state/20231205-103552
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20231205023150.1581875-2-dmitry.baryshkov%40linaro.org
patch subject: [PATCH v2 1/2] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state
config: i386-buildonly-randconfig-003-20231205 (https://download.01.org/0day-ci/archive/20231205/202312051810.e0QCZPbY-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051810.e0QCZPbY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051810.e0QCZPbY-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_atomic_helper.c:811: warning: Function parameter or member 'wb_conn' not described in 'drm_atomic_helper_check_wb_connector_state'
>> drivers/gpu/drm/drm_atomic_helper.c:811: warning: Excess function parameter 'connector' description in 'drm_atomic_helper_check_wb_connector_state'


vim +811 drivers/gpu/drm/drm_atomic_helper.c

623369e533e8a5 Daniel Vetter    2014-09-16  796  
254fe9c106ed69 Igor Torrente    2022-09-05  797  /**
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  798   * drm_atomic_helper_check_wb_connector_state() - Check writeback connector state
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  799   * @connector: corresponding connector
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  800   * @state: the driver state object
254fe9c106ed69 Igor Torrente    2022-09-05  801   *
254fe9c106ed69 Igor Torrente    2022-09-05  802   * Checks if the writeback connector state is valid, and returns an error if it
254fe9c106ed69 Igor Torrente    2022-09-05  803   * isn't.
254fe9c106ed69 Igor Torrente    2022-09-05  804   *
254fe9c106ed69 Igor Torrente    2022-09-05  805   * RETURNS:
254fe9c106ed69 Igor Torrente    2022-09-05  806   * Zero for success or -errno
254fe9c106ed69 Igor Torrente    2022-09-05  807   */
254fe9c106ed69 Igor Torrente    2022-09-05  808  int
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  809  drm_atomic_helper_check_wb_connector_state(struct drm_writeback_connector *wb_conn,
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  810  					   struct drm_atomic_state *state)
254fe9c106ed69 Igor Torrente    2022-09-05 @811  {
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  812  	struct drm_connector_state *conn_state =
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  813  		drm_atomic_get_new_connector_state(state, &wb_conn->base);
254fe9c106ed69 Igor Torrente    2022-09-05  814  	struct drm_writeback_job *wb_job = conn_state->writeback_job;
254fe9c106ed69 Igor Torrente    2022-09-05  815  	struct drm_property_blob *pixel_format_blob;
254fe9c106ed69 Igor Torrente    2022-09-05  816  	struct drm_framebuffer *fb;
254fe9c106ed69 Igor Torrente    2022-09-05  817  	size_t i, nformats;
254fe9c106ed69 Igor Torrente    2022-09-05  818  	u32 *formats;
254fe9c106ed69 Igor Torrente    2022-09-05  819  
254fe9c106ed69 Igor Torrente    2022-09-05  820  	if (!wb_job || !wb_job->fb)
254fe9c106ed69 Igor Torrente    2022-09-05  821  		return 0;
254fe9c106ed69 Igor Torrente    2022-09-05  822  
254fe9c106ed69 Igor Torrente    2022-09-05  823  	pixel_format_blob = wb_job->connector->pixel_formats_blob_ptr;
254fe9c106ed69 Igor Torrente    2022-09-05  824  	nformats = pixel_format_blob->length / sizeof(u32);
254fe9c106ed69 Igor Torrente    2022-09-05  825  	formats = pixel_format_blob->data;
254fe9c106ed69 Igor Torrente    2022-09-05  826  	fb = wb_job->fb;
254fe9c106ed69 Igor Torrente    2022-09-05  827  
254fe9c106ed69 Igor Torrente    2022-09-05  828  	for (i = 0; i < nformats; i++)
254fe9c106ed69 Igor Torrente    2022-09-05  829  		if (fb->format->format == formats[i])
254fe9c106ed69 Igor Torrente    2022-09-05  830  			return 0;
254fe9c106ed69 Igor Torrente    2022-09-05  831  
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  832  	drm_dbg_kms(wb_conn->base.dev, "Invalid pixel format %p4cc\n", &fb->format->format);
254fe9c106ed69 Igor Torrente    2022-09-05  833  
254fe9c106ed69 Igor Torrente    2022-09-05  834  	return -EINVAL;
254fe9c106ed69 Igor Torrente    2022-09-05  835  }
d538670e1a27f5 Dmitry Baryshkov 2023-12-05  836  EXPORT_SYMBOL(drm_atomic_helper_check_wb_connector_state);
254fe9c106ed69 Igor Torrente    2022-09-05  837  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki