From: Simon Horman <horms@kernel.org>
To: Steven Zou <steven.zou@intel.com>
Cc: jan.sokolowski@intel.com, netdev@vger.kernel.org,
andrii.staikov@intel.com, aleksander.lobakin@intel.com,
intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com,
andriy.shevchenko@linux.intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/2] ice: Refactor FW data type and fix bitmap casting issue
Date: Tue, 5 Dec 2023 19:16:02 +0000 [thread overview]
Message-ID: <20231205191602.GU50400@kernel.org> (raw)
In-Reply-To: <20231201062502.10099-2-steven.zou@intel.com>
On Fri, Dec 01, 2023 at 02:25:01PM +0800, Steven Zou wrote:
> According to the datasheet, the recipe association data is an 8-byte
> little-endian value. It is described as 'Bitmap of the recipe indexes
> associated with this profile', it is from 24 to 31 byte area in FW.
> Therefore, it is defined to '__le64 recipe_assoc' in struct
> ice_aqc_recipe_to_profile. And then fix the bitmap casting issue, as we
> must never ever use castings for bitmap type.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Andrii Staikov <andrii.staikov@intel.com>
> Reviewed-by: Jan Sokolowski <jan.sokolowski@intel.com>
> Signed-off-by: Steven Zou <steven.zou@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Steven Zou <steven.zou@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
przemyslaw.kitszel@intel.com, andriy.shevchenko@linux.intel.com,
aleksander.lobakin@intel.com, andrii.staikov@intel.com,
jan.sokolowski@intel.com
Subject: Re: [PATCH iwl-next 1/2] ice: Refactor FW data type and fix bitmap casting issue
Date: Tue, 5 Dec 2023 19:16:02 +0000 [thread overview]
Message-ID: <20231205191602.GU50400@kernel.org> (raw)
In-Reply-To: <20231201062502.10099-2-steven.zou@intel.com>
On Fri, Dec 01, 2023 at 02:25:01PM +0800, Steven Zou wrote:
> According to the datasheet, the recipe association data is an 8-byte
> little-endian value. It is described as 'Bitmap of the recipe indexes
> associated with this profile', it is from 24 to 31 byte area in FW.
> Therefore, it is defined to '__le64 recipe_assoc' in struct
> ice_aqc_recipe_to_profile. And then fix the bitmap casting issue, as we
> must never ever use castings for bitmap type.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Andrii Staikov <andrii.staikov@intel.com>
> Reviewed-by: Jan Sokolowski <jan.sokolowski@intel.com>
> Signed-off-by: Steven Zou <steven.zou@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-12-05 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 6:25 [Intel-wired-lan] [PATCH iwl-next 0/2] ice: Introduce switch recipe reusing Steven Zou
2023-12-01 6:25 ` Steven Zou
2023-12-01 6:25 ` [Intel-wired-lan] [PATCH iwl-next 1/2] ice: Refactor FW data type and fix bitmap casting issue Steven Zou
2023-12-01 6:25 ` Steven Zou
2023-12-05 19:16 ` Simon Horman [this message]
2023-12-05 19:16 ` Simon Horman
2023-12-01 6:25 ` [Intel-wired-lan] [PATCH iwl-next 2/2] ice: Add switch recipe reusing feature Steven Zou
2023-12-01 6:25 ` Steven Zou
2023-12-05 19:15 ` [Intel-wired-lan] " Simon Horman
2023-12-05 19:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205191602.GU50400@kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrii.staikov@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.sokolowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=steven.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.