From: kernel test robot <lkp@intel.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 3/7] ksmbd: downgrade RWH lease caching state to RH for directory
Date: Tue, 5 Dec 2023 19:15:08 +0800 [thread overview]
Message-ID: <202312051955.0b8rw970-lkp@intel.com> (raw)
In-Reply-To: <20231204134509.11413-3-linkinjeon@kernel.org>
Hi Namjae,
kernel test robot noticed the following build warnings:
[auto build test WARNING on cifs/for-next]
[also build test WARNING on linus/master v6.7-rc4 next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Namjae-Jeon/ksmbd-set-v2-lease-capability/20231204-214847
base: git://git.samba.org/sfrench/cifs-2.6.git for-next
patch link: https://lore.kernel.org/r/20231204134509.11413-3-linkinjeon%40kernel.org
patch subject: [PATCH 3/7] ksmbd: downgrade RWH lease caching state to RH for directory
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231205/202312051955.0b8rw970-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051955.0b8rw970-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051955.0b8rw970-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/smb/server/oplock.c:1405: warning: Function parameter or member 'is_dir' not described in 'parse_lease_state'
vim +1405 fs/smb/server/oplock.c
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1397
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1398 /**
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1399 * parse_lease_state() - parse lease context containted in file open request
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1400 * @open_req: buffer containing smb2 file open(create) request
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1401 *
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1402 * Return: oplock state, -ENOENT if create lease context not found
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1403 */
9c0f64c0641abec fs/smb/server/oplock.c Namjae Jeon 2023-12-04 1404 struct lease_ctx_info *parse_lease_state(void *open_req, bool is_dir)
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 @1405 {
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1406 struct create_context *cc;
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1407 struct smb2_create_req *req = (struct smb2_create_req *)open_req;
fc6c6a3c324c1b3 fs/smb/server/oplock.c Namjae Jeon 2023-05-28 1408 struct lease_ctx_info *lreq;
fc6c6a3c324c1b3 fs/smb/server/oplock.c Namjae Jeon 2023-05-28 1409
fc6c6a3c324c1b3 fs/smb/server/oplock.c Namjae Jeon 2023-05-28 1410 cc = smb2_find_context_vals(req, SMB2_CREATE_REQUEST_LEASE, 4);
fc6c6a3c324c1b3 fs/smb/server/oplock.c Namjae Jeon 2023-05-28 1411 if (IS_ERR_OR_NULL(cc))
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1412 return NULL;
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1413
fc6c6a3c324c1b3 fs/smb/server/oplock.c Namjae Jeon 2023-05-28 1414 lreq = kzalloc(sizeof(struct lease_ctx_info), GFP_KERNEL);
fc6c6a3c324c1b3 fs/smb/server/oplock.c Namjae Jeon 2023-05-28 1415 if (!lreq)
fc6c6a3c324c1b3 fs/smb/server/oplock.c Namjae Jeon 2023-05-28 1416 return NULL;
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1417
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1418 if (sizeof(struct lease_context_v2) == le32_to_cpu(cc->DataLength)) {
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1419 struct create_lease_v2 *lc = (struct create_lease_v2 *)cc;
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1420
2734b692f7b8167 fs/ksmbd/oplock.c Namjae Jeon 2021-09-09 1421 memcpy(lreq->lease_key, lc->lcontext.LeaseKey, SMB2_LEASE_KEY_SIZE);
9c0f64c0641abec fs/smb/server/oplock.c Namjae Jeon 2023-12-04 1422 if (is_dir)
9c0f64c0641abec fs/smb/server/oplock.c Namjae Jeon 2023-12-04 1423 lreq->req_state = lc->lcontext.LeaseState &
9c0f64c0641abec fs/smb/server/oplock.c Namjae Jeon 2023-12-04 1424 ~SMB2_LEASE_WRITE_CACHING_LE;
9c0f64c0641abec fs/smb/server/oplock.c Namjae Jeon 2023-12-04 1425 else
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1426 lreq->req_state = lc->lcontext.LeaseState;
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1427 lreq->flags = lc->lcontext.LeaseFlags;
3ed2c7b63d1312c fs/smb/server/oplock.c Namjae Jeon 2023-12-04 1428 lreq->epoch = lc->lcontext.Epoch;
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1429 lreq->duration = lc->lcontext.LeaseDuration;
2734b692f7b8167 fs/ksmbd/oplock.c Namjae Jeon 2021-09-09 1430 memcpy(lreq->parent_lease_key, lc->lcontext.ParentLeaseKey,
2734b692f7b8167 fs/ksmbd/oplock.c Namjae Jeon 2021-09-09 1431 SMB2_LEASE_KEY_SIZE);
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1432 lreq->version = 2;
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1433 } else {
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1434 struct create_lease *lc = (struct create_lease *)cc;
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1435
2734b692f7b8167 fs/ksmbd/oplock.c Namjae Jeon 2021-09-09 1436 memcpy(lreq->lease_key, lc->lcontext.LeaseKey, SMB2_LEASE_KEY_SIZE);
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1437 lreq->req_state = lc->lcontext.LeaseState;
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1438 lreq->flags = lc->lcontext.LeaseFlags;
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1439 lreq->duration = lc->lcontext.LeaseDuration;
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1440 lreq->version = 1;
ade62d8b429fe49 fs/cifsd/oplock.c Namjae Jeon 2021-06-07 1441 }
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1442 return lreq;
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1443 }
e2f34481b24db2f fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1444
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-12-05 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 13:45 [PATCH 1/7] ksmbd: set epoch in create context v2 lease Namjae Jeon
2023-12-04 13:45 ` [PATCH 2/7] ksmbd: set v2 lease capability Namjae Jeon
2023-12-04 13:45 ` [PATCH 3/7] ksmbd: downgrade RWH lease caching state to RH for directory Namjae Jeon
2023-12-05 11:15 ` kernel test robot [this message]
2023-12-05 12:04 ` Namjae Jeon
2023-12-04 13:45 ` [PATCH 4/7] ksmbd: send v2 lease break notification " Namjae Jeon
2023-12-04 13:45 ` [PATCH 5/7] ksmbd: lazy v2 lease break on smb2_write() Namjae Jeon
2023-12-06 12:41 ` kernel test robot
2023-12-06 13:12 ` Namjae Jeon
2023-12-04 13:45 ` [PATCH 6/7] ksmbd: avoid duplicate opinfo_put() call on error of smb21_lease_break_ack() Namjae Jeon
2023-12-04 13:45 ` [PATCH 7/7] ksmbd: fix wrong allocation size update in smb2_open() Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312051955.0b8rw970-lkp@intel.com \
--to=lkp@intel.com \
--cc=linkinjeon@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.