Re: [PATCH 5/7] ksmbd: lazy v2 lease break on smb2_write()

[kernel test robot <lkp@intel.com>]

Hi Namjae,

kernel test robot noticed the following build warnings:

[auto build test WARNING on cifs/for-next]
[also build test WARNING on linus/master v6.7-rc4 next-20231206]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Namjae-Jeon/ksmbd-set-v2-lease-capability/20231204-214847
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
patch link:    https://lore.kernel.org/r/20231204134509.11413-5-linkinjeon%40kernel.org
patch subject: [PATCH 5/7] ksmbd: lazy v2 lease break on smb2_write()
config: parisc-randconfig-r122-20231206 (https://download.01.org/0day-ci/archive/20231206/202312062020.FbeMXJCT-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231206/202312062020.FbeMXJCT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312062020.FbeMXJCT-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   fs/smb/server/oplock.c: note: in included file (through include/linux/dcache.h, include/linux/unicode.h, fs/smb/server/unicode.h, ...):
   include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
   include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
   include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
>> fs/smb/server/oplock.c:1120:16: sparse: sparse: dereference of noderef expression
   fs/smb/server/oplock.c:1120:42: sparse: sparse: dereference of noderef expression
   include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
   include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true

vim +1120 fs/smb/server/oplock.c

  1114	
  1115	void smb_lazy_parent_lease_break_close(struct ksmbd_file *fp)
  1116	{
  1117		struct oplock_info *opinfo;
  1118		struct ksmbd_inode *p_ci = NULL;
  1119	
> 1120		if (!fp->f_opinfo->is_lease || fp->f_opinfo->o_lease->version != 2)
  1121			return;
  1122	
  1123		p_ci = ksmbd_inode_lookup_lock(fp->filp->f_path.dentry->d_parent);
  1124		if (!p_ci)
  1125			return;
  1126	
  1127		list_for_each_entry(opinfo, &p_ci->m_op_list, op_entry) {
  1128			if (!opinfo->is_lease)
  1129				continue;
  1130	
  1131			if (opinfo->o_lease->state != SMB2_OPLOCK_LEVEL_NONE)
  1132				oplock_break(opinfo, SMB2_OPLOCK_LEVEL_NONE);
  1133		}
  1134	
  1135		ksmbd_inode_put(p_ci);
  1136	}
  1137	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki