From: Fabio Estevam <festevam@gmail.com>
To: marex@denx.de
Cc: stefan@agner.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@denx.de>
Subject: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
Date: Wed, 6 Dec 2023 08:23:37 -0300 [thread overview]
Message-ID: <20231206112337.2234849-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
i.MX23 has two LCDIF interrupts instead of a single one like other
i.MX devices.
Take this into account for properly describing the i.MX23 LCDIF
interrupts.
This fixes the following dt-schema warning:
imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Marek Vasut <marex@denx.de>
---
Changes since v1:
- Add missing else to limit the number of irqs for the other variants. (Krzysztof)
.../bindings/display/fsl,lcdif.yaml | 20 ++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index fc11ab5fc465..1c2be8d6f633 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -51,7 +51,10 @@ properties:
minItems: 1
interrupts:
- maxItems: 1
+ items:
+ - description: LCDIF DMA interrupt
+ - description: LCDIF Error interrupt
+ minItems: 1
power-domains:
maxItems: 1
@@ -131,6 +134,21 @@ allOf:
then:
required:
- power-domains
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx23-lcdif
+ then:
+ properties:
+ interrupts:
+ minItems: 2
+ maxItems: 2
+ else:
+ properties:
+ interrupts:
+ maxItems: 1
examples:
- |
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: marex@denx.de
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
Fabio Estevam <festevam@denx.de>,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
Date: Wed, 6 Dec 2023 08:23:37 -0300 [thread overview]
Message-ID: <20231206112337.2234849-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
i.MX23 has two LCDIF interrupts instead of a single one like other
i.MX devices.
Take this into account for properly describing the i.MX23 LCDIF
interrupts.
This fixes the following dt-schema warning:
imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Marek Vasut <marex@denx.de>
---
Changes since v1:
- Add missing else to limit the number of irqs for the other variants. (Krzysztof)
.../bindings/display/fsl,lcdif.yaml | 20 ++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index fc11ab5fc465..1c2be8d6f633 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -51,7 +51,10 @@ properties:
minItems: 1
interrupts:
- maxItems: 1
+ items:
+ - description: LCDIF DMA interrupt
+ - description: LCDIF Error interrupt
+ minItems: 1
power-domains:
maxItems: 1
@@ -131,6 +134,21 @@ allOf:
then:
required:
- power-domains
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx23-lcdif
+ then:
+ properties:
+ interrupts:
+ minItems: 2
+ maxItems: 2
+ else:
+ properties:
+ interrupts:
+ maxItems: 1
examples:
- |
--
2.34.1
next reply other threads:[~2023-12-06 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 11:23 Fabio Estevam [this message]
2023-12-06 11:23 ` [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts Fabio Estevam
2023-12-06 15:34 ` Conor Dooley
2023-12-06 15:34 ` Conor Dooley
2023-12-06 21:53 ` Rob Herring
2023-12-06 21:53 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2023-12-05 18:47 Fabio Estevam
2023-12-05 18:47 ` Fabio Estevam
2023-12-05 21:24 ` Marek Vasut
2023-12-05 21:24 ` Marek Vasut
2023-12-06 11:02 ` Krzysztof Kozlowski
2023-12-06 11:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206112337.2234849-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@denx.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.