All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com,
	quic_nitegupt@quicinc.com, quic_skananth@quicinc.com,
	quic_vpernami@quicinc.com, quic_parass@quicinc.com
Subject: Re: [PATCH v3 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property
Date: Wed, 6 Dec 2023 18:40:09 +0530	[thread overview]
Message-ID: <20231206131009.GD12802@thinkpad> (raw)
In-Reply-To: <3a7376aa-18a2-41cb-a4c9-680e735ce75b@linaro.org>

On Fri, Dec 01, 2023 at 02:25:44PM +0100, Krzysztof Kozlowski wrote:
> On 01/12/2023 13:30, Manivannan Sadhasivam wrote:
> >> What I said before:
> >> "Again, third time (once from Bjorn, once from Dmitry), rephrase
> >> property name and description to describe the hardware issue. I see
> >> description improved, but not the property name. Again in the end of
> >> description you say what Linux should do. Bindings do not describe Linux
> >> OS."
> >>
> > 
> > You didn't answer my question:
> > 
> > "I see a plenty of properties similar to this one instructing the OS to keep some
> > resource ON to workaround hardware issues. So they are all wrong?"
> 
> They are not the best, but it all depends on the individual case.
> 
> > 
> > If you say they are wrong, why are they approved in the first place?
> Because we don't have time to keep digging what the driver is doing and
> what is claimed in DT. Some people don't even CC us on the driver.
> 

OK. How about, "qcom,broken-refclk"? This reflects the fact that the default
refclk operation is broken on this platform, so the OS should be prepared for
it (by keeping it always on).

- Mani

> 
> Best regards,
> Krzysztof
> 

-- 
மணிவண்ணன் சதாசிவம்

WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com,
	quic_nitegupt@quicinc.com, quic_skananth@quicinc.com,
	quic_vpernami@quicinc.com, quic_parass@quicinc.com
Subject: Re: [PATCH v3 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property
Date: Wed, 6 Dec 2023 18:40:09 +0530	[thread overview]
Message-ID: <20231206131009.GD12802@thinkpad> (raw)
In-Reply-To: <3a7376aa-18a2-41cb-a4c9-680e735ce75b@linaro.org>

On Fri, Dec 01, 2023 at 02:25:44PM +0100, Krzysztof Kozlowski wrote:
> On 01/12/2023 13:30, Manivannan Sadhasivam wrote:
> >> What I said before:
> >> "Again, third time (once from Bjorn, once from Dmitry), rephrase
> >> property name and description to describe the hardware issue. I see
> >> description improved, but not the property name. Again in the end of
> >> description you say what Linux should do. Bindings do not describe Linux
> >> OS."
> >>
> > 
> > You didn't answer my question:
> > 
> > "I see a plenty of properties similar to this one instructing the OS to keep some
> > resource ON to workaround hardware issues. So they are all wrong?"
> 
> They are not the best, but it all depends on the individual case.
> 
> > 
> > If you say they are wrong, why are they approved in the first place?
> Because we don't have time to keep digging what the driver is doing and
> what is claimed in DT. Some people don't even CC us on the driver.
> 

OK. How about, "qcom,broken-refclk"? This reflects the fact that the default
refclk operation is broken on this platform, so the OS should be prepared for
it (by keeping it always on).

- Mani

> 
> Best regards,
> Krzysztof
> 

-- 
மணிவண்ணன் சதாசிவம்

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2023-12-06 13:10 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 12:13 [PATCH v3 0/3] phy: qcom-qmp-pcie: Add support to keep refclk always on Krishna chaitanya chundru
2023-11-27 12:13 ` Krishna chaitanya chundru
2023-11-27 12:13 ` [PATCH v3 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property Krishna chaitanya chundru
2023-11-27 12:13   ` Krishna chaitanya chundru
2023-11-28  8:56   ` Krzysztof Kozlowski
2023-11-28  8:56     ` Krzysztof Kozlowski
2023-11-28  9:19     ` Krishna Chaitanya Chundru
2023-11-28  9:19       ` Krishna Chaitanya Chundru
2023-12-01  6:07       ` Manivannan Sadhasivam
2023-12-01  6:07         ` Manivannan Sadhasivam
2023-12-01  8:01         ` Krzysztof Kozlowski
2023-12-01  8:01           ` Krzysztof Kozlowski
2023-12-01 11:10           ` Manivannan Sadhasivam
2023-12-01 11:10             ` Manivannan Sadhasivam
2023-12-01 12:10             ` Krzysztof Kozlowski
2023-12-01 12:10               ` Krzysztof Kozlowski
2023-12-01 12:30               ` Manivannan Sadhasivam
2023-12-01 12:30                 ` Manivannan Sadhasivam
2023-12-01 13:25                 ` Krzysztof Kozlowski
2023-12-01 13:25                   ` Krzysztof Kozlowski
2023-12-01 21:29                   ` Konrad Dybcio
2023-12-01 21:29                     ` Konrad Dybcio
2023-12-06 13:07                     ` Manivannan Sadhasivam
2023-12-06 13:07                       ` Manivannan Sadhasivam
2023-12-07 10:53                       ` Konrad Dybcio
2023-12-07 10:53                         ` Konrad Dybcio
2023-12-06 13:10                   ` Manivannan Sadhasivam [this message]
2023-12-06 13:10                     ` Manivannan Sadhasivam
2023-12-06 17:50                     ` Krzysztof Kozlowski
2023-12-06 17:50                       ` Krzysztof Kozlowski
2023-12-07  9:51                     ` Johan Hovold
2023-12-07  9:51                       ` Johan Hovold
2023-12-07 10:12                       ` Manivannan Sadhasivam
2023-12-07 10:12                         ` Manivannan Sadhasivam
2023-12-07 13:05                         ` Johan Hovold
2023-12-07 13:05                           ` Johan Hovold
2023-12-07 13:20                           ` Manivannan Sadhasivam
2023-12-07 13:20                             ` Manivannan Sadhasivam
2023-12-07 13:36                             ` Johan Hovold
2023-12-07 13:36                               ` Johan Hovold
2023-12-11 12:32                               ` Manivannan Sadhasivam
2023-12-11 12:32                                 ` Manivannan Sadhasivam
2023-11-27 12:13 ` [PATCH v3 2/3] phy: qcom-qmp-pcie: Add endpoint refclk control register offset Krishna chaitanya chundru
2023-11-27 12:13   ` Krishna chaitanya chundru
2023-11-27 12:13 ` [PATCH v3 3/3] phy: qcom-qmp-pcie: Add support for keeping refclk always on Krishna chaitanya chundru
2023-11-27 12:13   ` Krishna chaitanya chundru
2023-12-01  6:09   ` Manivannan Sadhasivam
2023-12-01  6:09     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231206131009.GD12802@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=quic_krichai@quicinc.com \
    --cc=quic_nitegupt@quicinc.com \
    --cc=quic_parass@quicinc.com \
    --cc=quic_ramkri@quicinc.com \
    --cc=quic_skananth@quicinc.com \
    --cc=quic_vbadigan@quicinc.com \
    --cc=quic_vpernami@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.