From: Lee Jones <lee@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: tudor.ambarus@linaro.org, pratyush@kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sbinding@opensource.cirrus.com, james.schulman@cirrus.com,
david.rhodes@cirrus.com, rf@opensource.cirrus.com,
perex@perex.cz, tiwai@suse.com,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
michael@walle.cc, linux-mtd@lists.infradead.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, michal.simek@amd.com,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, git@amd.com,
amitrkcian2002@gmail.com
Subject: Re: (subset) [PATCH v11 01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select
Date: Wed, 6 Dec 2023 13:45:18 +0000 [thread overview]
Message-ID: <20231206134518.GE3375667@google.com> (raw)
In-Reply-To: <395caa58-a8a0-4c75-85d3-4fa0f6f4a9ba@sirena.org.uk>
On Fri, 01 Dec 2023, Mark Brown wrote:
> On Fri, Dec 01, 2023 at 09:57:36AM +0000, Lee Jones wrote:
> > On Sat, 25 Nov 2023 14:51:28 +0530, Amit Kumar Mahapatra wrote:
> > > In preparation for adding multiple CS support for a device, set/get
> > > functions were introduces accessing spi->chip_select in
> > > 'commit 303feb3cc06a ("spi: Add APIs in spi core to set/get
> > > spi->chip_select and spi->cs_gpiod")'.
> > > Replace spi->chip_select with spi_get_chipselect() API.
>
> > Applied, thanks!
>
> > [01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select
> > commit: dd636638446c87c95c5beddcd367d95ac6764c6c
>
> Is there a signed tag available for this - without this change the
> subsequent SPI changes introduce a build breakage.
Not yet, but I can get around to making one.
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: tudor.ambarus@linaro.org, pratyush@kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sbinding@opensource.cirrus.com, james.schulman@cirrus.com,
david.rhodes@cirrus.com, rf@opensource.cirrus.com,
perex@perex.cz, tiwai@suse.com,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
michael@walle.cc, linux-mtd@lists.infradead.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, michal.simek@amd.com,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, git@amd.com,
amitrkcian2002@gmail.com
Subject: Re: (subset) [PATCH v11 01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select
Date: Wed, 6 Dec 2023 13:45:18 +0000 [thread overview]
Message-ID: <20231206134518.GE3375667@google.com> (raw)
In-Reply-To: <395caa58-a8a0-4c75-85d3-4fa0f6f4a9ba@sirena.org.uk>
On Fri, 01 Dec 2023, Mark Brown wrote:
> On Fri, Dec 01, 2023 at 09:57:36AM +0000, Lee Jones wrote:
> > On Sat, 25 Nov 2023 14:51:28 +0530, Amit Kumar Mahapatra wrote:
> > > In preparation for adding multiple CS support for a device, set/get
> > > functions were introduces accessing spi->chip_select in
> > > 'commit 303feb3cc06a ("spi: Add APIs in spi core to set/get
> > > spi->chip_select and spi->cs_gpiod")'.
> > > Replace spi->chip_select with spi_get_chipselect() API.
>
> > Applied, thanks!
>
> > [01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select
> > commit: dd636638446c87c95c5beddcd367d95ac6764c6c
>
> Is there a signed tag available for this - without this change the
> subsequent SPI changes introduce a build breakage.
Not yet, but I can get around to making one.
--
Lee Jones [李琼斯]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, vigneshr@ti.com,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
git@amd.com, sbinding@opensource.cirrus.com, richard@nod.at,
tiwai@suse.com, tudor.ambarus@linaro.org,
amitrkcian2002@gmail.com,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
linux-sound@vger.kernel.org, james.schulman@cirrus.com,
rf@opensource.cirrus.com, perex@perex.cz, michal.simek@amd.com,
linux-arm-kernel@lists.infradead.org,
patches@opensource.cirrus.com, claudiu.beznea@tuxon.dev,
linux-spi@vger.kernel.org, michael@walle.cc,
david.rhodes@cirrus.com, pratyush@kernel.org
Subject: Re: (subset) [PATCH v11 01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select
Date: Wed, 6 Dec 2023 13:45:18 +0000 [thread overview]
Message-ID: <20231206134518.GE3375667@google.com> (raw)
In-Reply-To: <395caa58-a8a0-4c75-85d3-4fa0f6f4a9ba@sirena.org.uk>
On Fri, 01 Dec 2023, Mark Brown wrote:
> On Fri, Dec 01, 2023 at 09:57:36AM +0000, Lee Jones wrote:
> > On Sat, 25 Nov 2023 14:51:28 +0530, Amit Kumar Mahapatra wrote:
> > > In preparation for adding multiple CS support for a device, set/get
> > > functions were introduces accessing spi->chip_select in
> > > 'commit 303feb3cc06a ("spi: Add APIs in spi core to set/get
> > > spi->chip_select and spi->cs_gpiod")'.
> > > Replace spi->chip_select with spi_get_chipselect() API.
>
> > Applied, thanks!
>
> > [01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select
> > commit: dd636638446c87c95c5beddcd367d95ac6764c6c
>
> Is there a signed tag available for this - without this change the
> subsequent SPI changes introduce a build breakage.
Not yet, but I can get around to making one.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-06 13:46 UTC|newest]
Thread overview: 236+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 9:21 [PATCH v11 00/10] spi: Add support for stacked/parallel memories Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` [PATCH v11 01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-12-01 9:57 ` (subset) " Lee Jones
2023-12-01 9:57 ` Lee Jones
2023-12-01 9:57 ` Lee Jones
2023-12-01 18:50 ` Mark Brown
2023-12-01 18:50 ` Mark Brown
2023-12-01 18:50 ` Mark Brown
2023-12-06 13:45 ` Lee Jones [this message]
2023-12-06 13:45 ` Lee Jones
2023-12-06 13:45 ` Lee Jones
2023-12-07 13:38 ` [GIT PULL] Immutable branch between MFD and SPI due for the v6.8 merge window Lee Jones
2023-12-07 13:38 ` Lee Jones
2023-12-07 13:38 ` Lee Jones
2023-12-07 16:20 ` Mark Brown
2023-12-07 16:20 ` Mark Brown
2023-12-07 16:20 ` Mark Brown
2023-11-25 9:21 ` [PATCH v11 02/10] ALSA: hda/cs35l56: Use set/get APIs to access spi->chip_select Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` [PATCH v11 03/10] spi: Add multi-cs memories support in SPI core Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2024-01-12 19:11 ` Guenter Roeck
2024-01-12 19:11 ` Guenter Roeck
2024-01-12 19:11 ` Guenter Roeck
2024-01-12 19:16 ` Mark Brown
2024-01-12 19:16 ` Mark Brown
2024-01-12 19:16 ` Mark Brown
2024-01-12 20:05 ` Guenter Roeck
2024-01-12 20:05 ` Guenter Roeck
2024-01-12 20:05 ` Guenter Roeck
2024-01-20 17:05 ` Guenter Roeck
2024-01-20 17:05 ` Guenter Roeck
2024-01-20 17:05 ` Guenter Roeck
2024-01-21 1:04 ` Mark Brown
2024-01-21 1:04 ` Mark Brown
2024-01-21 1:04 ` Mark Brown
2024-01-21 16:58 ` Guenter Roeck
2024-01-21 16:58 ` Guenter Roeck
2024-01-21 16:58 ` Guenter Roeck
2024-01-21 18:06 ` Michael Walle
2024-01-21 18:06 ` Michael Walle
2024-01-21 18:06 ` Michael Walle
2024-01-21 19:29 ` Guenter Roeck
2024-01-21 19:29 ` Guenter Roeck
2024-01-21 19:29 ` Guenter Roeck
2024-01-21 21:17 ` Mark Brown
2024-01-21 21:17 ` Mark Brown
2024-01-21 21:17 ` Mark Brown
2024-01-21 21:15 ` Mark Brown
2024-01-21 21:15 ` Mark Brown
2024-01-21 21:15 ` Mark Brown
2024-01-21 9:42 ` Linux regression tracking #adding (Thorsten Leemhuis)
2024-01-21 9:42 ` Linux regression tracking #adding (Thorsten Leemhuis)
2024-01-21 9:42 ` Linux regression tracking #adding (Thorsten Leemhuis)
2024-01-23 15:45 ` Linux regression tracking #update (Thorsten Leemhuis)
2024-01-23 15:45 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-11-25 9:21 ` [PATCH v11 04/10] mtd: spi-nor: Convert macros with inline functions Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` [PATCH v11 05/10] mtd: spi-nor: Add APIs to set/get nor->params Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` [PATCH v11 06/10] mtd: spi-nor: Move write enable inside specific write & erase APIs Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` [PATCH v11 07/10] mtd: spi-nor: Add stacked memories support in spi-nor Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-12-06 14:30 ` Tudor Ambarus
2023-12-06 14:30 ` Tudor Ambarus
2023-12-06 14:30 ` Tudor Ambarus
2023-12-06 14:43 ` Tudor Ambarus
2023-12-06 14:43 ` Tudor Ambarus
2023-12-06 14:43 ` Tudor Ambarus
2023-12-08 17:06 ` Mahapatra, Amit Kumar
2023-12-08 17:06 ` Mahapatra, Amit Kumar
2023-12-08 17:06 ` Mahapatra, Amit Kumar
2023-12-11 3:44 ` Tudor Ambarus
2023-12-11 3:44 ` Tudor Ambarus
2023-12-11 3:44 ` Tudor Ambarus
2023-12-08 17:05 ` Mahapatra, Amit Kumar
2023-12-08 17:05 ` Mahapatra, Amit Kumar
2023-12-08 17:05 ` Mahapatra, Amit Kumar
2023-12-11 3:33 ` Tudor Ambarus
2023-12-11 3:33 ` Tudor Ambarus
2023-12-11 3:33 ` Tudor Ambarus
2023-12-11 6:56 ` Mahapatra, Amit Kumar
2023-12-11 6:56 ` Mahapatra, Amit Kumar
2023-12-11 6:56 ` Mahapatra, Amit Kumar
2023-12-11 9:35 ` Tudor Ambarus
2023-12-11 9:35 ` Tudor Ambarus
2023-12-11 9:35 ` Tudor Ambarus
2023-12-11 13:37 ` Mahapatra, Amit Kumar
2023-12-11 13:37 ` Mahapatra, Amit Kumar
2023-12-11 13:37 ` Mahapatra, Amit Kumar
2023-12-12 15:02 ` Tudor Ambarus
2023-12-12 15:02 ` Tudor Ambarus
2023-12-12 15:02 ` Tudor Ambarus
2023-12-15 7:55 ` Mahapatra, Amit Kumar
2023-12-15 7:55 ` Mahapatra, Amit Kumar
2023-12-15 7:55 ` Mahapatra, Amit Kumar
2023-12-15 8:09 ` Tudor Ambarus
2023-12-15 8:09 ` Tudor Ambarus
2023-12-15 8:09 ` Tudor Ambarus
2023-12-15 10:02 ` Mahapatra, Amit Kumar
2023-12-15 10:02 ` Mahapatra, Amit Kumar
2023-12-15 10:02 ` Mahapatra, Amit Kumar
2023-12-15 10:33 ` Tudor Ambarus
2023-12-15 10:33 ` Tudor Ambarus
2023-12-15 10:33 ` Tudor Ambarus
2023-12-15 11:20 ` Mahapatra, Amit Kumar
2023-12-15 11:20 ` Mahapatra, Amit Kumar
2023-12-15 11:20 ` Mahapatra, Amit Kumar
2023-12-19 8:26 ` Tudor Ambarus
2023-12-19 8:26 ` Tudor Ambarus
2023-12-19 8:26 ` Tudor Ambarus
2023-12-21 6:54 ` Mahapatra, Amit Kumar
2023-12-21 6:54 ` Mahapatra, Amit Kumar
2023-12-21 6:54 ` Mahapatra, Amit Kumar
2024-02-09 11:06 ` Tudor Ambarus
2024-02-09 11:06 ` Tudor Ambarus
2024-02-09 11:06 ` Tudor Ambarus
2024-02-09 16:13 ` Tudor Ambarus
2024-02-09 16:13 ` Tudor Ambarus
2024-02-09 16:13 ` Tudor Ambarus
2024-03-13 16:03 ` Mahapatra, Amit Kumar
2024-03-13 16:03 ` Mahapatra, Amit Kumar
2024-03-13 16:03 ` Mahapatra, Amit Kumar
2024-07-26 12:35 ` Mahapatra, Amit Kumar
2024-07-26 12:35 ` Mahapatra, Amit Kumar
2024-07-26 12:35 ` Mahapatra, Amit Kumar
[not found] ` < <IA0PR12MB769944254171C39FF4171B52DCB42@IA0PR12MB7699.namprd12.prod.outlook.com>
2024-07-26 12:55 ` Michael Walle
2024-07-26 12:55 ` Michael Walle
2024-07-26 12:55 ` Michael Walle
2024-07-31 8:58 ` Michal Simek
2024-07-31 8:58 ` Michal Simek
2024-07-31 8:58 ` Michal Simek
2024-07-31 9:19 ` Michael Walle
2024-07-31 9:19 ` Michael Walle
2024-07-31 9:19 ` Michael Walle
2024-07-31 13:40 ` Michal Simek
2024-07-31 13:40 ` Michal Simek
2024-07-31 13:40 ` Michal Simek
2024-07-31 14:11 ` Michael Walle
2024-07-31 14:11 ` Michael Walle
2024-07-31 14:11 ` Michael Walle
2024-08-01 6:22 ` Michal Simek
2024-08-01 6:22 ` Michal Simek
2024-08-01 6:22 ` Michal Simek
2024-08-01 6:37 ` Frager, Neal
2024-08-01 6:37 ` Frager, Neal
2024-08-01 6:37 ` Frager, Neal
2024-08-01 9:28 ` Mahapatra, Amit Kumar
2024-08-01 9:28 ` Mahapatra, Amit Kumar
2024-08-01 9:28 ` Mahapatra, Amit Kumar
[not found] ` < <CH2PR12MB50044242FE253D7B0E3425ABF0B22@CH2PR12MB5004.namprd12.prod.outlook.com>
2024-08-05 8:14 ` Michael Walle
2024-08-05 8:14 ` Michael Walle
2024-08-05 8:14 ` Michael Walle
2024-08-05 8:27 ` Michael Walle
2024-08-05 8:27 ` Michael Walle
2024-08-05 8:27 ` Michael Walle
2024-08-05 11:00 ` Michal Simek
2024-08-05 11:00 ` Michal Simek
2024-08-05 11:00 ` Michal Simek
2024-08-07 13:21 ` Mahapatra, Amit Kumar
2024-08-07 13:21 ` Mahapatra, Amit Kumar
2024-08-07 13:21 ` Mahapatra, Amit Kumar
2024-08-12 7:29 ` Miquel Raynal
2024-08-12 7:29 ` Miquel Raynal
2024-08-12 7:29 ` Miquel Raynal
2024-08-12 7:37 ` Michael Walle
2024-08-12 7:37 ` Michael Walle
2024-08-12 7:37 ` Michael Walle
2024-08-12 8:39 ` Miquel Raynal
2024-08-12 8:39 ` Miquel Raynal
2024-08-12 8:39 ` Miquel Raynal
2024-08-12 8:38 ` Miquel Raynal
2024-08-12 8:38 ` Miquel Raynal
2024-08-12 8:38 ` Miquel Raynal
2024-08-12 9:45 ` Tudor Ambarus
2024-08-12 9:45 ` Tudor Ambarus
2024-08-12 9:45 ` Tudor Ambarus
2024-08-14 7:13 ` Mahapatra, Amit Kumar
2024-08-14 7:13 ` Mahapatra, Amit Kumar
2024-08-14 7:13 ` Mahapatra, Amit Kumar
2024-08-14 8:46 ` Miquel Raynal
2024-08-14 8:46 ` Miquel Raynal
2024-08-14 8:46 ` Miquel Raynal
2024-08-14 12:53 ` Mahapatra, Amit Kumar
2024-08-14 12:53 ` Mahapatra, Amit Kumar
2024-08-14 12:53 ` Mahapatra, Amit Kumar
2024-08-14 14:46 ` Miquel Raynal
2024-08-14 14:46 ` Miquel Raynal
2024-08-14 14:46 ` Miquel Raynal
2024-08-19 10:28 ` Mahapatra, Amit Kumar
2024-08-19 10:28 ` Mahapatra, Amit Kumar
2024-08-19 10:28 ` Mahapatra, Amit Kumar
2024-03-13 16:03 ` Mahapatra, Amit Kumar
2024-03-13 16:03 ` Mahapatra, Amit Kumar
2024-03-13 16:03 ` Mahapatra, Amit Kumar
2023-12-07 17:24 ` Tudor Ambarus
2023-12-07 17:24 ` Tudor Ambarus
2023-12-07 17:24 ` Tudor Ambarus
2023-11-25 9:21 ` [PATCH v11 08/10] spi: spi-zynqmp-gqspi: Add stacked memories support in GQSPI driver Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` [PATCH v11 09/10] mtd: spi-nor: Add parallel memories support in spi-nor Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 19:21 ` kernel test robot
2023-12-04 4:35 ` Dan Carpenter
2023-11-25 9:21 ` [PATCH v11 10/10] spi: spi-zynqmp-gqspi: Add parallel memories support in GQSPI driver Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-25 9:21 ` Amit Kumar Mahapatra
2023-11-27 3:11 ` kernel test robot
2023-12-07 22:35 ` (subset) [PATCH v11 00/10] spi: Add support for stacked/parallel memories Mark Brown
2023-12-07 22:35 ` Mark Brown
2023-12-07 22:35 ` Mark Brown
2023-12-12 12:34 ` Michael Walle
2023-12-12 12:34 ` Michael Walle
2023-12-12 12:34 ` Michael Walle
2023-12-15 7:28 ` Mahapatra, Amit Kumar
2023-12-15 7:28 ` Mahapatra, Amit Kumar
2023-12-15 7:28 ` Mahapatra, Amit Kumar
2023-12-18 22:10 ` Richard Weinberger
2023-12-18 22:10 ` Richard Weinberger
2023-12-18 22:10 ` Richard Weinberger
2023-12-19 8:12 ` Miquel Raynal
2023-12-19 8:12 ` Miquel Raynal
2023-12-19 8:12 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206134518.GE3375667@google.com \
--to=lee@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=amit.kumar-mahapatra@amd.com \
--cc=amitrkcian2002@gmail.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=david.rhodes@cirrus.com \
--cc=git@amd.com \
--cc=james.schulman@cirrus.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=michal.simek@amd.com \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=pratyush@kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=richard@nod.at \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.