* drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:525:29-44: ERROR: reference preceded by free on line 524
@ 2023-12-06 14:56 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-12-06 14:56 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Julia Lawall
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Alexander Lobakin <aleksander.lobakin@intel.com>
CC: Tony Nguyen <anthony.l.nguyen@intel.com>
CC: Kees Cook <keescook@chromium.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
commit: b0654e64dbaf62f565b5f2b4fbd92202e88dcba3 virtchnl: fix fake 1-elem arrays for structures allocated as `nents`
date: 4 months ago
:::::: branch date: 2 days ago
:::::: commit date: 4 months ago
config: i386-randconfig-054-20231206 (https://download.01.org/0day-ci/archive/20231206/202312062230.VRAIGrLi-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20231206/202312062230.VRAIGrLi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202312062230.VRAIGrLi-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:525:29-44: ERROR: reference preceded by free on line 524
vim +525 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 492
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 493 /**
2723f3b5d4ff58 Jesse Brandeburg 2022-12-16 494 * i40e_config_rdma_qvlist
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 495 * @vf: pointer to the VF info
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 496 * @qvlist_info: queue and vector list
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 497 *
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 498 * Return 0 on success or < 0 on error
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 499 **/
2723f3b5d4ff58 Jesse Brandeburg 2022-12-16 500 static int
2723f3b5d4ff58 Jesse Brandeburg 2022-12-16 501 i40e_config_rdma_qvlist(struct i40e_vf *vf,
2723f3b5d4ff58 Jesse Brandeburg 2022-12-16 502 struct virtchnl_rdma_qvlist_info *qvlist_info)
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 503 {
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 504 struct i40e_pf *pf = vf->pf;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 505 struct i40e_hw *hw = &pf->hw;
2723f3b5d4ff58 Jesse Brandeburg 2022-12-16 506 struct virtchnl_rdma_qv_info *qv_info;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 507 u32 v_idx, i, reg_idx, reg;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 508 u32 next_q_idx, next_q_type;
b0654e64dbaf62 Alexander Lobakin 2023-07-28 509 size_t size;
fae6cad17ce39b Gustavo A. R. Silva 2019-06-05 510 u32 msix_vf;
0b63644602cfcb Martyna Szapar 2019-04-18 511 int ret = 0;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 512
7015ca3df96537 Sergey Nemov 2019-03-29 513 msix_vf = pf->hw.func_caps.num_msix_vectors_vf;
7015ca3df96537 Sergey Nemov 2019-03-29 514
7015ca3df96537 Sergey Nemov 2019-03-29 515 if (qvlist_info->num_vectors > msix_vf) {
7015ca3df96537 Sergey Nemov 2019-03-29 516 dev_warn(&pf->pdev->dev,
7015ca3df96537 Sergey Nemov 2019-03-29 517 "Incorrect number of iwarp vectors %u. Maximum %u allowed.\n",
7015ca3df96537 Sergey Nemov 2019-03-29 518 qvlist_info->num_vectors,
7015ca3df96537 Sergey Nemov 2019-03-29 519 msix_vf);
0b63644602cfcb Martyna Szapar 2019-04-18 520 ret = -EINVAL;
0b63644602cfcb Martyna Szapar 2019-04-18 521 goto err_out;
7015ca3df96537 Sergey Nemov 2019-03-29 522 }
7015ca3df96537 Sergey Nemov 2019-03-29 523
0b63644602cfcb Martyna Szapar 2019-04-18 @524 kfree(vf->qvlist_info);
b0654e64dbaf62 Alexander Lobakin 2023-07-28 @525 size = virtchnl_struct_size(vf->qvlist_info, qv_info,
b0654e64dbaf62 Alexander Lobakin 2023-07-28 526 qvlist_info->num_vectors);
b0654e64dbaf62 Alexander Lobakin 2023-07-28 527 vf->qvlist_info = kzalloc(size, GFP_KERNEL);
0b63644602cfcb Martyna Szapar 2019-04-18 528 if (!vf->qvlist_info) {
0b63644602cfcb Martyna Szapar 2019-04-18 529 ret = -ENOMEM;
0b63644602cfcb Martyna Szapar 2019-04-18 530 goto err_out;
0b63644602cfcb Martyna Szapar 2019-04-18 531 }
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 532 vf->qvlist_info->num_vectors = qvlist_info->num_vectors;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 533
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 534 msix_vf = pf->hw.func_caps.num_msix_vectors_vf;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 535 for (i = 0; i < qvlist_info->num_vectors; i++) {
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 536 qv_info = &qvlist_info->qv_info[i];
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 537 if (!qv_info)
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 538 continue;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 539
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 540 /* Validate vector id belongs to this vf */
d510497b8397ec Sergey Nemov 2019-04-24 541 if (!i40e_vc_isvalid_vector_id(vf, qv_info->v_idx)) {
0b63644602cfcb Martyna Szapar 2019-04-18 542 ret = -EINVAL;
0b63644602cfcb Martyna Szapar 2019-04-18 543 goto err_free;
0b63644602cfcb Martyna Szapar 2019-04-18 544 }
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 545
d510497b8397ec Sergey Nemov 2019-04-24 546 v_idx = qv_info->v_idx;
d510497b8397ec Sergey Nemov 2019-04-24 547
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 548 vf->qvlist_info->qv_info[i] = *qv_info;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 549
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 550 reg_idx = ((msix_vf - 1) * vf->vf_id) + (v_idx - 1);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 551 /* We might be sharing the interrupt, so get the first queue
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 552 * index and type, push it down the list by adding the new
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 553 * queue on top. Also link it with the new queue in CEQCTL.
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 554 */
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 555 reg = rd32(hw, I40E_VPINT_LNKLSTN(reg_idx));
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 556 next_q_idx = ((reg & I40E_VPINT_LNKLSTN_FIRSTQ_INDX_MASK) >>
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 557 I40E_VPINT_LNKLSTN_FIRSTQ_INDX_SHIFT);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 558 next_q_type = ((reg & I40E_VPINT_LNKLSTN_FIRSTQ_TYPE_MASK) >>
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 559 I40E_VPINT_LNKLSTN_FIRSTQ_TYPE_SHIFT);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 560
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 561 if (qv_info->ceq_idx != I40E_QUEUE_INVALID_IDX) {
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 562 reg_idx = (msix_vf - 1) * vf->vf_id + qv_info->ceq_idx;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 563 reg = (I40E_VPINT_CEQCTL_CAUSE_ENA_MASK |
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 564 (v_idx << I40E_VPINT_CEQCTL_MSIX_INDX_SHIFT) |
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 565 (qv_info->itr_idx << I40E_VPINT_CEQCTL_ITR_INDX_SHIFT) |
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 566 (next_q_type << I40E_VPINT_CEQCTL_NEXTQ_TYPE_SHIFT) |
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 567 (next_q_idx << I40E_VPINT_CEQCTL_NEXTQ_INDX_SHIFT));
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 568 wr32(hw, I40E_VPINT_CEQCTL(reg_idx), reg);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 569
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 570 reg_idx = ((msix_vf - 1) * vf->vf_id) + (v_idx - 1);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 571 reg = (qv_info->ceq_idx &
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 572 I40E_VPINT_LNKLSTN_FIRSTQ_INDX_MASK) |
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 573 (I40E_QUEUE_TYPE_PE_CEQ <<
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 574 I40E_VPINT_LNKLSTN_FIRSTQ_TYPE_SHIFT);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 575 wr32(hw, I40E_VPINT_LNKLSTN(reg_idx), reg);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 576 }
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 577
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 578 if (qv_info->aeq_idx != I40E_QUEUE_INVALID_IDX) {
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 579 reg = (I40E_VPINT_AEQCTL_CAUSE_ENA_MASK |
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 580 (v_idx << I40E_VPINT_AEQCTL_MSIX_INDX_SHIFT) |
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 581 (qv_info->itr_idx << I40E_VPINT_AEQCTL_ITR_INDX_SHIFT));
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 582
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 583 wr32(hw, I40E_VPINT_AEQCTL(vf->vf_id), reg);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 584 }
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 585 }
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 586
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 587 return 0;
0b63644602cfcb Martyna Szapar 2019-04-18 588 err_free:
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 589 kfree(vf->qvlist_info);
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 590 vf->qvlist_info = NULL;
0b63644602cfcb Martyna Szapar 2019-04-18 591 err_out:
0b63644602cfcb Martyna Szapar 2019-04-18 592 return ret;
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 593 }
e3219ce6a77546 Anjali Singhai Jain 2016-01-20 594
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-12-06 14:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-06 14:56 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:525:29-44: ERROR: reference preceded by free on line 524 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.