From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: <linux-pci@vger.kernel.org>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Robert Richter <rrichter@amd.com>,
Terry Bowman <terry.bowman@amd.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 3/3] PCI/AER: Use explicit register sizes for struct members
Date: Fri, 8 Dec 2023 14:38:57 +0000 [thread overview]
Message-ID: <20231208143857.000061f4@Huawei.com> (raw)
In-Reply-To: <20231206224231.732765-4-helgaas@kernel.org>
On Wed, 6 Dec 2023 16:42:31 -0600
Bjorn Helgaas <helgaas@kernel.org> wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> aer_irq() reads the AER Root Error Status and Error Source Identification
> (PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into
> struct aer_err_source. Both registers are 32 bits, so declare the members
> explicitly as "u32" instead of "unsigned int".
>
> Similarly, aer_get_device_error_info() reads the AER Header Log
> (PCI_ERR_HEADER_LOG) registers, which are also 32 bits, into struct
> aer_header_log_regs. Declare those members as "u32" as well.
>
> No functional changes intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Another sensible cleanup. FWIW on such simple patches
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Robert Richter <rrichter@amd.com>,
Terry Bowman <terry.bowman@amd.com>,
linux-pci@vger.kernel.org,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
linux-kernel@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Oliver O'Halloran <oohall@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] PCI/AER: Use explicit register sizes for struct members
Date: Fri, 8 Dec 2023 14:38:57 +0000 [thread overview]
Message-ID: <20231208143857.000061f4@Huawei.com> (raw)
In-Reply-To: <20231206224231.732765-4-helgaas@kernel.org>
On Wed, 6 Dec 2023 16:42:31 -0600
Bjorn Helgaas <helgaas@kernel.org> wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> aer_irq() reads the AER Root Error Status and Error Source Identification
> (PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into
> struct aer_err_source. Both registers are 32 bits, so declare the members
> explicitly as "u32" instead of "unsigned int".
>
> Similarly, aer_get_device_error_info() reads the AER Header Log
> (PCI_ERR_HEADER_LOG) registers, which are also 32 bits, into struct
> aer_header_log_regs. Declare those members as "u32" as well.
>
> No functional changes intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Another sensible cleanup. FWIW on such simple patches
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2023-12-08 14:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 22:42 [PATCH 0/3] PCI/AER: Clean up logging Bjorn Helgaas
2023-12-06 22:42 ` Bjorn Helgaas
2023-12-06 22:42 ` [PATCH 1/3] PCI/AER: Use 'Correctable' and 'Uncorrectable' spec terms for errors Bjorn Helgaas
2023-12-06 22:42 ` Bjorn Helgaas
2023-12-08 14:36 ` Jonathan Cameron
2023-12-08 14:36 ` Jonathan Cameron
2023-12-12 15:00 ` Terry Bowman
2023-12-12 15:00 ` Terry Bowman
2023-12-12 21:23 ` Bjorn Helgaas
2023-12-12 21:23 ` Bjorn Helgaas
2023-12-12 22:42 ` Bowman, Terry
2024-01-02 19:23 ` Kuppuswamy Sathyanarayanan
2024-01-02 19:23 ` Kuppuswamy Sathyanarayanan
2023-12-06 22:42 ` [PATCH 2/3] PCI/AER: Decode Requester ID when no error info found Bjorn Helgaas
2023-12-06 22:42 ` Bjorn Helgaas
2023-12-08 14:38 ` Jonathan Cameron
2023-12-08 14:38 ` Jonathan Cameron
2023-12-12 15:00 ` Terry Bowman
2023-12-12 15:00 ` Terry Bowman
2024-01-02 19:22 ` Kuppuswamy Sathyanarayanan
2024-01-02 19:22 ` Kuppuswamy Sathyanarayanan
2024-01-02 22:53 ` Bjorn Helgaas
2024-01-02 22:53 ` Bjorn Helgaas
2023-12-06 22:42 ` [PATCH 3/3] PCI/AER: Use explicit register sizes for struct members Bjorn Helgaas
2023-12-06 22:42 ` Bjorn Helgaas
2023-12-08 14:38 ` Jonathan Cameron [this message]
2023-12-08 14:38 ` Jonathan Cameron
2023-12-08 16:54 ` [PATCH 0/3] PCI/AER: Clean up logging Bjorn Helgaas
2023-12-08 16:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208143857.000061f4@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=rrichter@amd.com \
--cc=terry.bowman@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.