All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: kovalev@altlinux.org
Cc: devel-kernel@lists.altlinux.org,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	dri-devel@lists.freedesktop.org, stable@vger.kernel.org,
	"Jani Nikula" <jani.nikula@intel.com>
Subject: Re: [PATCH 1/1] Revert "drm/edid: Fix csync detailed mode parsing"
Date: Sat, 9 Dec 2023 12:58:33 +0100	[thread overview]
Message-ID: <2023120959-unloader-empower-4dc2@gregkh> (raw)
In-Reply-To: <20231206084946.111835-2-kovalev@altlinux.org>

On Wed, Dec 06, 2023 at 11:49:46AM +0300, kovalev@altlinux.org wrote:
> From: Vasiliy Kovalev <kovalev@altlinux.org>
> 
> This reverts commit 5a46dc8e4a064769e916d87bf9bccae75afc7289.
> 
> Commit 50b6f2c8297793f7f3315623db78dcff85158e96 upstream.
> 
> Commit 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing") fixed
> EDID detailed mode sync parsing. Unfortunately, there are quite a few
> displays out there that have bogus (zero) sync field that are broken by
> the change. Zero means analog composite sync, which is not right for
> digital displays, and the modes get rejected. Regardless, it used to
> work, and it needs to continue to work. Revert the change.
> 
> Rejecting modes with analog composite sync was the part that fixed the
> gitlab issue 8146 [1]. We'll need to get back to the drawing board with
> that.
> 
> [1] https://gitlab.freedesktop.org/drm/intel/-/issues/8146
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8789
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8930
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9044
> Fixes: 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing")
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v6.4+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20230815101907.2900768-1-jani.nikula@intel.com
> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
> ---
>  drivers/gpu/drm/drm_edid.c | 26 +++++++-------------------
>  include/drm/drm_edid.h     | 12 +++---------
>  2 files changed, 10 insertions(+), 28 deletions(-)

You sent this 3 times, why?  And what tree is this backport for?  It's
already in the respective stable releases, right?

confused,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: kovalev@altlinux.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	stable@vger.kernel.org, dri-devel@lists.freedesktop.org,
	devel-kernel@lists.altlinux.org
Subject: Re: [PATCH 1/1] Revert "drm/edid: Fix csync detailed mode parsing"
Date: Sat, 9 Dec 2023 12:58:33 +0100	[thread overview]
Message-ID: <2023120959-unloader-empower-4dc2@gregkh> (raw)
In-Reply-To: <20231206084946.111835-2-kovalev@altlinux.org>

On Wed, Dec 06, 2023 at 11:49:46AM +0300, kovalev@altlinux.org wrote:
> From: Vasiliy Kovalev <kovalev@altlinux.org>
> 
> This reverts commit 5a46dc8e4a064769e916d87bf9bccae75afc7289.
> 
> Commit 50b6f2c8297793f7f3315623db78dcff85158e96 upstream.
> 
> Commit 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing") fixed
> EDID detailed mode sync parsing. Unfortunately, there are quite a few
> displays out there that have bogus (zero) sync field that are broken by
> the change. Zero means analog composite sync, which is not right for
> digital displays, and the modes get rejected. Regardless, it used to
> work, and it needs to continue to work. Revert the change.
> 
> Rejecting modes with analog composite sync was the part that fixed the
> gitlab issue 8146 [1]. We'll need to get back to the drawing board with
> that.
> 
> [1] https://gitlab.freedesktop.org/drm/intel/-/issues/8146
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8789
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8930
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9044
> Fixes: 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing")
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v6.4+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20230815101907.2900768-1-jani.nikula@intel.com
> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
> ---
>  drivers/gpu/drm/drm_edid.c | 26 +++++++-------------------
>  include/drm/drm_edid.h     | 12 +++---------
>  2 files changed, 10 insertions(+), 28 deletions(-)

You sent this 3 times, why?  And what tree is this backport for?  It's
already in the respective stable releases, right?

confused,

greg k-h

  reply	other threads:[~2023-12-09 11:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231206084946.111835-1-kovalev@altlinux.org>
2023-12-06  8:49 ` [PATCH 1/1] Revert "drm/edid: Fix csync detailed mode parsing" kovalev
2023-12-06  8:49   ` kovalev
2023-12-09 11:58   ` Greg KH [this message]
2023-12-09 11:58     ` Greg KH
     [not found] <20231206084045.111544-1-kovalev@altlinux.org>
2023-12-06  8:40 ` kovalev
2023-12-06  8:40   ` kovalev
     [not found] <20231206082746.110903-1-kovalev@altlinux.org>
2023-12-06  8:27 ` kovalev
2023-12-06  8:27   ` kovalev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023120959-unloader-empower-4dc2@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=devel-kernel@lists.altlinux.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=kovalev@altlinux.org \
    --cc=stable@vger.kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.