From: Fabio Estevam <festevam@gmail.com>
To: marex@denx.de
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, martink@posteo.de, kernel@puri.sm,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@denx.de>
Subject: [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"
Date: Mon, 11 Dec 2023 17:41:36 -0300 [thread overview]
Message-ID: <20231211204138.553141-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
On i.MX6SX, the LCDIF has an associated power domain.
However, i.MX8MQ does not have an LCDIF power domain.
imx8mq.dtsi has the following compatible string:
compatible = "fsl,imx8mq-lcdif", "fsl,imx6sx-lcdif";
which causes the following dt-schema warning:
imx8mq-evk.dtb: lcd-controller@30320000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
To prevent this problem, add a specific fsl,imx8mq-lcdif entry in
the driver to properly handle such a power-domain requirement difference.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index b483ef48216a..ac9ce3b45b38 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -340,6 +340,7 @@ static const struct of_device_id mxsfb_dt_ids[] = {
{ .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], },
{ .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
{ .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
+ { .compatible = "fsl,imx8mq-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, mxsfb_dt_ids);
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: marex@denx.de
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
Fabio Estevam <festevam@denx.de>,
kernel@puri.sm, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
martink@posteo.de
Subject: [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"
Date: Mon, 11 Dec 2023 17:41:36 -0300 [thread overview]
Message-ID: <20231211204138.553141-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
On i.MX6SX, the LCDIF has an associated power domain.
However, i.MX8MQ does not have an LCDIF power domain.
imx8mq.dtsi has the following compatible string:
compatible = "fsl,imx8mq-lcdif", "fsl,imx6sx-lcdif";
which causes the following dt-schema warning:
imx8mq-evk.dtb: lcd-controller@30320000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
To prevent this problem, add a specific fsl,imx8mq-lcdif entry in
the driver to properly handle such a power-domain requirement difference.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index b483ef48216a..ac9ce3b45b38 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -340,6 +340,7 @@ static const struct of_device_id mxsfb_dt_ids[] = {
{ .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], },
{ .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
{ .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
+ { .compatible = "fsl,imx8mq-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, mxsfb_dt_ids);
--
2.34.1
next reply other threads:[~2023-12-11 20:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 20:41 Fabio Estevam [this message]
2023-12-11 20:41 ` [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif" Fabio Estevam
2023-12-11 20:41 ` [PATCH 2/3] dt-bindings: lcdif: Decouple imx8mq from imx6sx Fabio Estevam
2023-12-11 20:41 ` Fabio Estevam
2023-12-12 16:52 ` Conor Dooley
2023-12-12 16:52 ` Conor Dooley
2023-12-11 20:41 ` [PATCH 3/3] arm64: dts: imx8mq: Exclude "fsl,imx6sx-lcdif" Fabio Estevam
2023-12-11 20:41 ` Fabio Estevam
2023-12-12 18:19 ` [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif" Lucas Stach
2023-12-12 18:28 ` Fabio Estevam
2023-12-13 9:02 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211204138.553141-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@denx.de \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=marex@denx.de \
--cc=martink@posteo.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.