From: Conor Dooley <conor@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH net-next v3 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes
Date: Tue, 12 Dec 2023 16:29:35 +0000 [thread overview]
Message-ID: <20231212-operative-stubbly-2104c96bdee5@spud> (raw)
In-Reply-To: <5859da6629b8b6c100eca4062dd193105bf829ba.1702352117.git.daniel@makrotopia.org>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Tue, Dec 12, 2023 at 03:48:10AM +0000, Daniel Golle wrote:
> Several clocks as well as both sgmiisys phandles were added by mistake
> to the Ethernet bindings for MT7988.
>
> This happened because the vendor driver which served as a reference
> uses a high number of syscon phandles to access various parts of the
> SoC which wasn't acceptable upstream. Hence several parts which have
> never previously been supported (such SerDes PHY and USXGMII PCS) have
> been moved to separate drivers which also result in a much more sane
> device tree.
>
> Quickly align the bindings with the upcoming reality of the drivers
> actually adding full support for this SoC.
>
> Fixes: c94a9aabec36 ("dt-bindings: net: mediatek,net: add mt7988-eth binding")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH net-next v3 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes
Date: Tue, 12 Dec 2023 16:29:35 +0000 [thread overview]
Message-ID: <20231212-operative-stubbly-2104c96bdee5@spud> (raw)
In-Reply-To: <5859da6629b8b6c100eca4062dd193105bf829ba.1702352117.git.daniel@makrotopia.org>
[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]
On Tue, Dec 12, 2023 at 03:48:10AM +0000, Daniel Golle wrote:
> Several clocks as well as both sgmiisys phandles were added by mistake
> to the Ethernet bindings for MT7988.
>
> This happened because the vendor driver which served as a reference
> uses a high number of syscon phandles to access various parts of the
> SoC which wasn't acceptable upstream. Hence several parts which have
> never previously been supported (such SerDes PHY and USXGMII PCS) have
> been moved to separate drivers which also result in a much more sane
> device tree.
>
> Quickly align the bindings with the upcoming reality of the drivers
> actually adding full support for this SoC.
>
> Fixes: c94a9aabec36 ("dt-bindings: net: mediatek,net: add mt7988-eth binding")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 112 bytes --]
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH net-next v3 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes
Date: Tue, 12 Dec 2023 16:29:35 +0000 [thread overview]
Message-ID: <20231212-operative-stubbly-2104c96bdee5@spud> (raw)
In-Reply-To: <5859da6629b8b6c100eca4062dd193105bf829ba.1702352117.git.daniel@makrotopia.org>
[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]
On Tue, Dec 12, 2023 at 03:48:10AM +0000, Daniel Golle wrote:
> Several clocks as well as both sgmiisys phandles were added by mistake
> to the Ethernet bindings for MT7988.
>
> This happened because the vendor driver which served as a reference
> uses a high number of syscon phandles to access various parts of the
> SoC which wasn't acceptable upstream. Hence several parts which have
> never previously been supported (such SerDes PHY and USXGMII PCS) have
> been moved to separate drivers which also result in a much more sane
> device tree.
>
> Quickly align the bindings with the upcoming reality of the drivers
> actually adding full support for this SoC.
>
> Fixes: c94a9aabec36 ("dt-bindings: net: mediatek,net: add mt7988-eth binding")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-12 16:29 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 3:45 [RFC PATCH net-next v3 0/8] Add support for 10G Ethernet SerDes on MT7988 Daniel Golle
2023-12-12 3:45 ` Daniel Golle
2023-12-12 3:45 ` Daniel Golle
2023-12-12 3:46 ` [RFC PATCH net-next v3 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Daniel Golle
2023-12-12 3:46 ` Daniel Golle
2023-12-12 3:46 ` Daniel Golle
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 16:21 ` Conor Dooley
2023-12-12 16:21 ` Conor Dooley
2023-12-12 16:21 ` Conor Dooley
2023-12-12 16:42 ` Daniel Golle
2023-12-12 16:42 ` Daniel Golle
2023-12-12 16:42 ` Daniel Golle
2023-12-13 9:46 ` Conor Dooley
2023-12-13 9:46 ` Conor Dooley
2023-12-13 9:46 ` Conor Dooley
2023-12-13 13:20 ` Andrew Lunn
2023-12-13 13:20 ` Andrew Lunn
2023-12-13 13:20 ` Andrew Lunn
2023-12-16 1:16 ` Daniel Golle
2023-12-16 1:16 ` Daniel Golle
2023-12-16 1:16 ` Daniel Golle
2023-12-12 3:46 ` [RFC PATCH net-next v3 2/8] phy: add driver for MediaTek pextp 10GE SerDes PHY Daniel Golle
2023-12-12 3:46 ` Daniel Golle
2023-12-12 3:46 ` Daniel Golle
2023-12-12 10:41 ` AngeloGioacchino Del Regno
2023-12-12 10:41 ` AngeloGioacchino Del Regno
2023-12-12 10:41 ` AngeloGioacchino Del Regno
2023-12-13 2:13 ` Chunfeng Yun (云春峰)
2023-12-13 2:13 ` Chunfeng Yun (云春峰)
2023-12-13 2:13 ` Chunfeng Yun (云春峰)
2023-12-21 16:48 ` Vinod Koul
2023-12-21 16:48 ` Vinod Koul
2023-12-21 16:48 ` Vinod Koul
2023-12-12 3:47 ` [RFC PATCH net-next v3 3/8] net: pcs: pcs-mtk-lynxi: add platform driver for MT7988 Daniel Golle
2023-12-12 3:47 ` Daniel Golle
2023-12-12 3:47 ` Daniel Golle
2023-12-13 16:04 ` Russell King (Oracle)
2023-12-13 16:04 ` Russell King (Oracle)
2023-12-13 16:04 ` Russell King (Oracle)
2024-02-07 1:29 ` Daniel Golle
2024-02-07 1:29 ` Daniel Golle
2024-02-07 1:29 ` Daniel Golle
2024-04-22 16:23 ` Daniel Golle
2024-04-22 16:23 ` Daniel Golle
2024-04-22 16:23 ` Daniel Golle
2024-07-10 11:17 ` Frank Wunderlich
2024-07-10 11:17 ` Frank Wunderlich
2024-10-04 14:17 ` Aw: " Frank Wunderlich
2024-10-04 14:17 ` Frank Wunderlich
2024-10-04 14:17 ` Frank Wunderlich
2024-10-04 14:35 ` Russell King (Oracle)
2024-10-04 14:35 ` Russell King (Oracle)
2025-01-05 11:29 ` Aw: " Frank Wunderlich
2025-01-05 11:29 ` Frank Wunderlich
2023-12-12 3:47 ` [RFC PATCH net-next v3 4/8] dt-bindings: net: pcs: add bindings for MediaTek USXGMII PCS Daniel Golle
2023-12-12 3:47 ` Daniel Golle
2023-12-12 3:47 ` Daniel Golle
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 16:24 ` Conor Dooley
2023-12-12 16:24 ` Conor Dooley
2023-12-12 16:24 ` Conor Dooley
2023-12-12 3:47 ` [RFC PATCH net-next v3 5/8] net: pcs: add driver " Daniel Golle
2023-12-12 3:47 ` Daniel Golle
2023-12-12 3:47 ` Daniel Golle
2023-12-12 9:29 ` Simon Horman
2023-12-12 9:29 ` Simon Horman
2023-12-12 9:29 ` Simon Horman
2023-12-12 3:48 ` [RFC PATCH net-next v3 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes Daniel Golle
2023-12-12 3:48 ` Daniel Golle
2023-12-12 3:48 ` Daniel Golle
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 16:29 ` Conor Dooley [this message]
2023-12-12 16:29 ` Conor Dooley
2023-12-12 16:29 ` Conor Dooley
2023-12-12 3:51 ` [RFC PATCH net-next v3 7/8] dt-bindings: net: mediatek,net: fix and complete mt7988-eth binding Daniel Golle
2023-12-12 3:51 ` Daniel Golle
2023-12-12 3:51 ` Daniel Golle
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 5:43 ` Rob Herring
2023-12-12 16:34 ` Conor Dooley
2023-12-12 16:34 ` Conor Dooley
2023-12-12 16:34 ` Conor Dooley
2023-12-13 6:58 ` Krzysztof Kozlowski
2023-12-13 6:58 ` Krzysztof Kozlowski
2023-12-13 6:58 ` Krzysztof Kozlowski
2023-12-12 3:51 ` [RFC PATCH net-next v3 8/8] net: ethernet: mtk_eth_soc: add paths and SerDes modes for MT7988 Daniel Golle
2023-12-12 3:51 ` Daniel Golle
2023-12-12 3:51 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212-operative-stubbly-2104c96bdee5@spud \
--to=conor@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.