From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: netdev@vger.kernel.org,
Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: Add helper function ice_is_generic_mac
Date: Tue, 12 Dec 2023 10:01:41 +0000 [thread overview]
Message-ID: <20231212100141.GV5817@kernel.org> (raw)
In-Reply-To: <20231206192919.3826128-3-grzegorz.nitka@intel.com>
On Wed, Dec 06, 2023 at 08:29:18PM +0100, Grzegorz Nitka wrote:
> E800 series devices have a couple of quirks:
> 1. Sideband control queues are not supported
> 2. The registers that the driver needs to program for the "Precision
> Time Protocol (PTP)" feature are different for E800 series devices
> compared to other devices supported by this driver.
>
> Both these require conditional logic based on the underlying device we
> are dealing with.
>
> The function ice_is_sbq_supported added by commit 8f5ee3c477a8
> ("ice: add support for sideband messages") addresses (1).
> The same function can be used to address (2) as well
> but this just looks weird readability wise in cases that have nothing
> to do with sideband control queues:
>
> if (ice_is_sbq_supported(hw))
> /* program register A */
> else
> /* program register B */
>
> For these cases, the function ice_is_generic_mac introduced by this
> patch communicates the idea/intention better. Also rework
> ice_is_sbq_supported to use this new function.
> As side-band queue is supported for E825C devices, it's mac_type is
> considered as generic mac_type.
>
> Co-developed-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Subject: Re: [PATCH iwl-next v1 2/3] ice: Add helper function ice_is_generic_mac
Date: Tue, 12 Dec 2023 10:01:41 +0000 [thread overview]
Message-ID: <20231212100141.GV5817@kernel.org> (raw)
In-Reply-To: <20231206192919.3826128-3-grzegorz.nitka@intel.com>
On Wed, Dec 06, 2023 at 08:29:18PM +0100, Grzegorz Nitka wrote:
> E800 series devices have a couple of quirks:
> 1. Sideband control queues are not supported
> 2. The registers that the driver needs to program for the "Precision
> Time Protocol (PTP)" feature are different for E800 series devices
> compared to other devices supported by this driver.
>
> Both these require conditional logic based on the underlying device we
> are dealing with.
>
> The function ice_is_sbq_supported added by commit 8f5ee3c477a8
> ("ice: add support for sideband messages") addresses (1).
> The same function can be used to address (2) as well
> but this just looks weird readability wise in cases that have nothing
> to do with sideband control queues:
>
> if (ice_is_sbq_supported(hw))
> /* program register A */
> else
> /* program register B */
>
> For these cases, the function ice_is_generic_mac introduced by this
> patch communicates the idea/intention better. Also rework
> ice_is_sbq_supported to use this new function.
> As side-band queue is supported for E825C devices, it's mac_type is
> considered as generic mac_type.
>
> Co-developed-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-12-12 10:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 19:29 [Intel-wired-lan] [PATCH iwl-next v1 0/3] ice: add E825C device family support Grzegorz Nitka
2023-12-06 19:29 ` Grzegorz Nitka
2023-12-06 19:29 ` [Intel-wired-lan] [PATCH iwl-next v1 1/3] ice: introduce new E825C devices family Grzegorz Nitka
2023-12-06 19:29 ` Grzegorz Nitka
2023-12-12 10:01 ` [Intel-wired-lan] " Simon Horman
2023-12-12 10:01 ` Simon Horman
2024-01-08 4:50 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-08 4:50 ` Pucha, HimasekharX Reddy
2023-12-06 19:29 ` [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: Add helper function ice_is_generic_mac Grzegorz Nitka
2023-12-06 19:29 ` Grzegorz Nitka
2023-12-12 10:01 ` Simon Horman [this message]
2023-12-12 10:01 ` Simon Horman
2024-01-08 4:53 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-08 4:53 ` Pucha, HimasekharX Reddy
2023-12-06 19:29 ` [Intel-wired-lan] [PATCH iwl-next v1 3/3] ice: add support for 3k signing DDP sections for E825C Grzegorz Nitka
2023-12-06 19:29 ` Grzegorz Nitka
2023-12-12 10:02 ` [Intel-wired-lan] " Simon Horman
2023-12-12 10:02 ` Simon Horman
2024-01-08 4:55 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-08 4:55 ` Pucha, HimasekharX Reddy
2023-12-07 9:11 ` [Intel-wired-lan] [PATCH iwl-next v1 0/3] ice: add E825C device family support Mateusz Polchlopek
2023-12-07 9:11 ` Mateusz Polchlopek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212100141.GV5817@kernel.org \
--to=horms@kernel.org \
--cc=anirudh.venkataramanan@intel.com \
--cc=grzegorz.nitka@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.