From: Jakub Kicinski <kuba@kernel.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: Kunwu Chan <kunwu.chan@hotmail.com>,
przemyslaw.kitszel@intel.com, jesse.brandeburg@intel.com,
linux-kernel@vger.kernel.org, edumazet@google.com,
anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
jacob.e.keller@intel.com, intel-wired-lan@lists.osuosl.org,
pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH] igb: Add null pointer check to igb_set_fw_version
Date: Tue, 12 Dec 2023 13:26:37 -0800 [thread overview]
Message-ID: <20231212132637.1b0fb8aa@kernel.org> (raw)
In-Reply-To: <20231211031336.235634-1-chentao@kylinos.cn>
On Mon, 11 Dec 2023 11:13:36 +0800 Kunwu Chan wrote:
> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
>
> Fixes: 1978d3ead82c ("intel: fix string truncation warnings")
> Cc: Kunwu Chan <kunwu.chan@hotmail.com>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
The allocation is rather pointless here.
Can you convert this code to use snprintf() instead?
--
pw-bot: cr
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
jacob.e.keller@intel.com, przemyslaw.kitszel@intel.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Kunwu Chan <kunwu.chan@hotmail.com>
Subject: Re: [PATCH] igb: Add null pointer check to igb_set_fw_version
Date: Tue, 12 Dec 2023 13:26:37 -0800 [thread overview]
Message-ID: <20231212132637.1b0fb8aa@kernel.org> (raw)
In-Reply-To: <20231211031336.235634-1-chentao@kylinos.cn>
On Mon, 11 Dec 2023 11:13:36 +0800 Kunwu Chan wrote:
> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
>
> Fixes: 1978d3ead82c ("intel: fix string truncation warnings")
> Cc: Kunwu Chan <kunwu.chan@hotmail.com>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
The allocation is rather pointless here.
Can you convert this code to use snprintf() instead?
--
pw-bot: cr
next prev parent reply other threads:[~2023-12-12 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 3:13 [Intel-wired-lan] [PATCH] igb: Add null pointer check to igb_set_fw_version Kunwu Chan
2023-12-11 3:13 ` Kunwu Chan
2023-12-12 21:26 ` Jakub Kicinski [this message]
2023-12-12 21:26 ` Jakub Kicinski
2023-12-14 2:44 ` [Intel-wired-lan] " Kunwu Chan
2023-12-14 2:44 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212132637.1b0fb8aa@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=chentao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.