From: Donald Hunter <donald.hunter@gmail.com>
To: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>,
Breno Leitao <leitao@debian.org>
Cc: donald.hunter@redhat.com, Donald Hunter <donald.hunter@gmail.com>
Subject: [PATCH net-next v3 00/13] tools/net/ynl: Add 'sub-message' support to ynl
Date: Tue, 12 Dec 2023 22:15:39 +0000 [thread overview]
Message-ID: <20231212221552.3622-1-donald.hunter@gmail.com> (raw)
This patchset adds a 'sub-message' attribute type to the netlink-raw
schema and implements it in ynl. This provides support for kind-specific
options attributes as used in rt_link and tc raw netlink families.
A description of the new 'sub-message' attribute type and the
corresponding sub-message definitions is provided in patch 3.
The patchset includes updates to the rt_link spec and a new tc spec that
make use of the new 'sub-message' attribute type.
As mentioned in patch 4, encode support is not yet implemented in ynl
and support for sub-message selectors at a different nest level from the
key attribute is not yet supported. I plan to work on these in folloup
patches.
Patches 1 is code cleanup in ynl
Patches 2-4 add sub-message support to the schema and ynl with
documentation updates.
Patch 5 adds binary and pad support to structs in netlink-raw.
Patches 6-8 contain specs that use the sub-message attribute type.
Patches 9-13 update ynl-gen-rst and its make target
Changes since v2: (reported by Jakub Kicinski and Breno Leitao)
- Fixed ynl-gen-c breakage
- Added schema constraint for pad/binary & len
- Improved description text in raw schema
- Used | for all multi-line text in schema
- Updated docs with explanation of what a sub-message is
- Reverted change in ynl-gen-rst
- Added ynl-gen-rst patches and grouped them all at end of patchset
Changes since v1: (reported by Jakub Kicinski, thanks!)
- Added cleanups for ynl and generated netlink docs
- Describe sub-messages in netlink docs
- Cleaned up unintended indent changes
- Cleaned up rt-link sub-message definitions
- Cleaned up array index expressions to follow python style
- Added sub-messages to generated netlink spec docs
Donald Hunter (13):
tools/net/ynl: Use consistent array index expression formatting
doc/netlink: Add sub-message support to netlink-raw
doc/netlink: Document the sub-message format for netlink-raw
tools/net/ynl: Add 'sub-message' attribute decoding to ynl
tools/net/ynl: Add binary and pad support to structs for tc
doc/netlink/specs: Add sub-message type to rt_link family
doc/netlink/specs: use pad in structs in rt_link
doc/netlink/specs: Add a spec for tc
doc/netlink: Regenerate netlink .rst files if ynl-gen-rst changes
tools/net/ynl-gen-rst: Add sub-messages to generated docs
tools/net/ynl-gen-rst: Sort the index of generated netlink specs
tools/net/ynl-gen-rst: Remove bold from attribute-set headings
tools/net/ynl-gen-rst: Remove extra indentation from generated docs
Documentation/Makefile | 8 +-
Documentation/netlink/netlink-raw.yaml | 65 +-
Documentation/netlink/specs/rt_link.yaml | 449 +++-
Documentation/netlink/specs/tc.yaml | 2037 +++++++++++++++++
.../userspace-api/netlink/netlink-raw.rst | 96 +-
tools/net/ynl/lib/nlspec.py | 55 +
tools/net/ynl/lib/ynl.py | 94 +-
tools/net/ynl/ynl-gen-rst.py | 31 +-
8 files changed, 2789 insertions(+), 46 deletions(-)
create mode 100644 Documentation/netlink/specs/tc.yaml
--
2.42.0
next reply other threads:[~2023-12-12 22:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 22:15 Donald Hunter [this message]
2023-12-12 22:15 ` [PATCH net-next v3 01/13] tools/net/ynl: Use consistent array index expression formatting Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 02/13] doc/netlink: Add sub-message support to netlink-raw Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 03/13] doc/netlink: Document the sub-message format for netlink-raw Donald Hunter
2023-12-13 0:17 ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 04/13] tools/net/ynl: Add 'sub-message' attribute decoding to ynl Donald Hunter
2023-12-13 0:18 ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 05/13] tools/net/ynl: Add binary and pad support to structs for tc Donald Hunter
2023-12-13 0:19 ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 06/13] doc/netlink/specs: Add sub-message type to rt_link family Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 07/13] doc/netlink/specs: use pad in structs in rt_link Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 08/13] doc/netlink/specs: Add a spec for tc Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 09/13] doc/netlink: Regenerate netlink .rst files if ynl-gen-rst changes Donald Hunter
2023-12-12 23:34 ` Breno Leitao
2023-12-13 9:42 ` Donald Hunter
2023-12-13 14:58 ` Breno Leitao
2023-12-13 16:39 ` Jakub Kicinski
2023-12-13 17:04 ` Donald Hunter
2023-12-13 18:01 ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 10/13] tools/net/ynl-gen-rst: Add sub-messages to generated docs Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 11/13] tools/net/ynl-gen-rst: Sort the index of generated netlink specs Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 12/13] tools/net/ynl-gen-rst: Remove bold from attribute-set headings Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 13/13] tools/net/ynl-gen-rst: Remove extra indentation from generated docs Donald Hunter
2023-12-12 23:36 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212221552.3622-1-donald.hunter@gmail.com \
--to=donald.hunter@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.