All of lore.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org,
	Jacob Keller <jacob.e.keller@intel.com>,
	donald.hunter@redhat.com
Subject: Re: [PATCH net-next v3 09/13] doc/netlink: Regenerate netlink .rst files if ynl-gen-rst changes
Date: Wed, 13 Dec 2023 06:58:10 -0800	[thread overview]
Message-ID: <ZXnGglqz01BxAB21@gmail.com> (raw)
In-Reply-To: <m21qbq780z.fsf@gmail.com>

On Wed, Dec 13, 2023 at 09:42:52AM +0000, Donald Hunter wrote:
> Breno Leitao <leitao@debian.org> writes:
> 
> >> +$(YNL_INDEX): $(YNL_RST_FILES) $(YNL_TOOL)
> >> +	$(Q)$(YNL_TOOL) -o $@ -x
> >
> > Isn't $(YNL_INDEX) depending to $(YNL_TOOL) indirectly since it depends
> > on $(YNL_RST_FILES) ?
> >
> > I mean, do you really need the line above?
> 
> Sure, the transitive dependency is sufficient. I tend to add an explicit
> dependency for a script that gets run in a target.
> 
> Happy to remove that change and respin if you prefer?

I would say it is preferred to remove unnecessary code.

Feel free to add the following line in the new version:

	Reviewed-by: Breno Leitao <leitao@debian.org>

Thanks for addressing this.

  reply	other threads:[~2023-12-13 14:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 22:15 [PATCH net-next v3 00/13] tools/net/ynl: Add 'sub-message' support to ynl Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 01/13] tools/net/ynl: Use consistent array index expression formatting Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 02/13] doc/netlink: Add sub-message support to netlink-raw Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 03/13] doc/netlink: Document the sub-message format for netlink-raw Donald Hunter
2023-12-13  0:17   ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 04/13] tools/net/ynl: Add 'sub-message' attribute decoding to ynl Donald Hunter
2023-12-13  0:18   ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 05/13] tools/net/ynl: Add binary and pad support to structs for tc Donald Hunter
2023-12-13  0:19   ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 06/13] doc/netlink/specs: Add sub-message type to rt_link family Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 07/13] doc/netlink/specs: use pad in structs in rt_link Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 08/13] doc/netlink/specs: Add a spec for tc Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 09/13] doc/netlink: Regenerate netlink .rst files if ynl-gen-rst changes Donald Hunter
2023-12-12 23:34   ` Breno Leitao
2023-12-13  9:42     ` Donald Hunter
2023-12-13 14:58       ` Breno Leitao [this message]
2023-12-13 16:39       ` Jakub Kicinski
2023-12-13 17:04         ` Donald Hunter
2023-12-13 18:01           ` Jakub Kicinski
2023-12-12 22:15 ` [PATCH net-next v3 10/13] tools/net/ynl-gen-rst: Add sub-messages to generated docs Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 11/13] tools/net/ynl-gen-rst: Sort the index of generated netlink specs Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 12/13] tools/net/ynl-gen-rst: Remove bold from attribute-set headings Donald Hunter
2023-12-12 22:15 ` [PATCH net-next v3 13/13] tools/net/ynl-gen-rst: Remove extra indentation from generated docs Donald Hunter
2023-12-12 23:36   ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXnGglqz01BxAB21@gmail.com \
    --to=leitao@debian.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=donald.hunter@redhat.com \
    --cc=edumazet@google.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.