* drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
@ 2023-12-11 18:10 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2023-12-11 18:10 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
CC: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
CC: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
commit: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
date: 7 weeks ago
:::::: branch date: 19 hours ago
:::::: commit date: 7 weeks ago
config: riscv-randconfig-r071-20231211 (https://download.01.org/0day-ci/archive/20231212/202312120248.5DblxkBp-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231212/202312120248.5DblxkBp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312120248.5DblxkBp-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
Old smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:579 xilinx_pl_dma_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
drivers/pci/controller/pcie-xilinx-dma-pl.c:645 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
vim +/irq +638 drivers/pci/controller/pcie-xilinx-dma-pl.c
8d786149d78c77 Thippeswamy Havalige 2023-10-03 595
8d786149d78c77 Thippeswamy Havalige 2023-10-03 596 static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 597 {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 598 struct device *dev = port->dev;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 599 struct platform_device *pdev = to_platform_device(dev);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 600 int i, irq, err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 601
8d786149d78c77 Thippeswamy Havalige 2023-10-03 602 port->irq = platform_get_irq(pdev, 0);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 603 if (port->irq < 0)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 604 return port->irq;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 605
8d786149d78c77 Thippeswamy Havalige 2023-10-03 606 for (i = 0; i < ARRAY_SIZE(intr_cause); i++) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 607 int err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 608
8d786149d78c77 Thippeswamy Havalige 2023-10-03 609 if (!intr_cause[i].str)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 610 continue;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 611
8d786149d78c77 Thippeswamy Havalige 2023-10-03 612 irq = irq_create_mapping(port->pldma_domain, i);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 613 if (!irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 614 dev_err(dev, "Failed to map interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 615 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 616 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 617
8d786149d78c77 Thippeswamy Havalige 2023-10-03 618 err = devm_request_irq(dev, irq,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 619 xilinx_pl_dma_pcie_intr_handler,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 620 IRQF_SHARED | IRQF_NO_THREAD,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 621 intr_cause[i].sym, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 622 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 623 dev_err(dev, "Failed to request IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 624 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 625 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 626 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 627
8d786149d78c77 Thippeswamy Havalige 2023-10-03 628 port->intx_irq = irq_create_mapping(port->pldma_domain,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 629 XILINX_PCIE_INTR_INTX);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 630 if (!port->intx_irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 631 dev_err(dev, "Failed to map INTx interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 632 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 633 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 634
8d786149d78c77 Thippeswamy Havalige 2023-10-03 635 err = devm_request_irq(dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 636 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 637 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 @638 dev_err(dev, "Failed to request INTx IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 639 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 640 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 641
8d786149d78c77 Thippeswamy Havalige 2023-10-03 642 err = devm_request_irq(dev, port->irq, xilinx_pl_dma_pcie_event_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 643 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 644 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 645 dev_err(dev, "Failed to request event IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 646 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 647 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 648
8d786149d78c77 Thippeswamy Havalige 2023-10-03 649 return 0;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 650 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 651
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
@ 2023-12-12 9:54 Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2023-12-12 9:54 UTC (permalink / raw)
To: oe-kbuild, Thippeswamy Havalige
Cc: lkp, oe-kbuild-all, linux-kernel, Krzysztof Wilczyński,
Bharat Kumar Gogada
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
commit: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
config: riscv-randconfig-r071-20231211 (https://download.01.org/0day-ci/archive/20231212/202312120248.5DblxkBp-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231212/202312120248.5DblxkBp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202312120248.5DblxkBp-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
vim +/irq +638 drivers/pci/controller/pcie-xilinx-dma-pl.c
8d786149d78c77 Thippeswamy Havalige 2023-10-03 596 static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 597 {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 598 struct device *dev = port->dev;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 599 struct platform_device *pdev = to_platform_device(dev);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 600 int i, irq, err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 601
8d786149d78c77 Thippeswamy Havalige 2023-10-03 602 port->irq = platform_get_irq(pdev, 0);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 603 if (port->irq < 0)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 604 return port->irq;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 605
8d786149d78c77 Thippeswamy Havalige 2023-10-03 606 for (i = 0; i < ARRAY_SIZE(intr_cause); i++) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 607 int err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 608
8d786149d78c77 Thippeswamy Havalige 2023-10-03 609 if (!intr_cause[i].str)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 610 continue;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 611
8d786149d78c77 Thippeswamy Havalige 2023-10-03 612 irq = irq_create_mapping(port->pldma_domain, i);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 613 if (!irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 614 dev_err(dev, "Failed to map interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 615 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 616 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 617
8d786149d78c77 Thippeswamy Havalige 2023-10-03 618 err = devm_request_irq(dev, irq,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 619 xilinx_pl_dma_pcie_intr_handler,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 620 IRQF_SHARED | IRQF_NO_THREAD,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 621 intr_cause[i].sym, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 622 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 623 dev_err(dev, "Failed to request IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 624 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 625 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 626 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 627
8d786149d78c77 Thippeswamy Havalige 2023-10-03 628 port->intx_irq = irq_create_mapping(port->pldma_domain,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 629 XILINX_PCIE_INTR_INTX);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 630 if (!port->intx_irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 631 dev_err(dev, "Failed to map INTx interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 632 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 633 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 634
8d786149d78c77 Thippeswamy Havalige 2023-10-03 635 err = devm_request_irq(dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 636 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 637 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 @638 dev_err(dev, "Failed to request INTx IRQ %d\n", irq);
^^^
s/irq/port->intx_irq/
8d786149d78c77 Thippeswamy Havalige 2023-10-03 639 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 640 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 641
8d786149d78c77 Thippeswamy Havalige 2023-10-03 642 err = devm_request_irq(dev, port->irq, xilinx_pl_dma_pcie_event_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 643 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 644 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 645 dev_err(dev, "Failed to request event IRQ %d\n", irq);
^^^
s/irq/port->irq/
8d786149d78c77 Thippeswamy Havalige 2023-10-03 646 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 647 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 648
8d786149d78c77 Thippeswamy Havalige 2023-10-03 649 return 0;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 650 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
@ 2023-12-12 12:19 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2023-12-12 12:19 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
CC: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
CC: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 26aff849438cebcd05f1a647390c4aa700d5c0f1
commit: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
date: 7 weeks ago
:::::: branch date: 12 hours ago
:::::: commit date: 7 weeks ago
config: riscv-randconfig-r071-20231211 (https://download.01.org/0day-ci/archive/20231212/202312122037.G1yxXee2-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231212/202312122037.G1yxXee2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312122037.G1yxXee2-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
Old smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:579 xilinx_pl_dma_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
drivers/pci/controller/pcie-xilinx-dma-pl.c:645 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
vim +/irq +638 drivers/pci/controller/pcie-xilinx-dma-pl.c
8d786149d78c77 Thippeswamy Havalige 2023-10-03 595
8d786149d78c77 Thippeswamy Havalige 2023-10-03 596 static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 597 {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 598 struct device *dev = port->dev;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 599 struct platform_device *pdev = to_platform_device(dev);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 600 int i, irq, err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 601
8d786149d78c77 Thippeswamy Havalige 2023-10-03 602 port->irq = platform_get_irq(pdev, 0);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 603 if (port->irq < 0)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 604 return port->irq;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 605
8d786149d78c77 Thippeswamy Havalige 2023-10-03 606 for (i = 0; i < ARRAY_SIZE(intr_cause); i++) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 607 int err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 608
8d786149d78c77 Thippeswamy Havalige 2023-10-03 609 if (!intr_cause[i].str)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 610 continue;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 611
8d786149d78c77 Thippeswamy Havalige 2023-10-03 612 irq = irq_create_mapping(port->pldma_domain, i);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 613 if (!irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 614 dev_err(dev, "Failed to map interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 615 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 616 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 617
8d786149d78c77 Thippeswamy Havalige 2023-10-03 618 err = devm_request_irq(dev, irq,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 619 xilinx_pl_dma_pcie_intr_handler,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 620 IRQF_SHARED | IRQF_NO_THREAD,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 621 intr_cause[i].sym, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 622 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 623 dev_err(dev, "Failed to request IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 624 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 625 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 626 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 627
8d786149d78c77 Thippeswamy Havalige 2023-10-03 628 port->intx_irq = irq_create_mapping(port->pldma_domain,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 629 XILINX_PCIE_INTR_INTX);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 630 if (!port->intx_irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 631 dev_err(dev, "Failed to map INTx interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 632 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 633 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 634
8d786149d78c77 Thippeswamy Havalige 2023-10-03 635 err = devm_request_irq(dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 636 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 637 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 @638 dev_err(dev, "Failed to request INTx IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 639 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 640 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 641
8d786149d78c77 Thippeswamy Havalige 2023-10-03 642 err = devm_request_irq(dev, port->irq, xilinx_pl_dma_pcie_event_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 643 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 644 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 645 dev_err(dev, "Failed to request event IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 646 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 647 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 648
8d786149d78c77 Thippeswamy Havalige 2023-10-03 649 return 0;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 650 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 651
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
@ 2023-12-12 21:15 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2023-12-12 21:15 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
CC: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
CC: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: eaadbbaaff74ac9a7f84f412fbaac221a04896c1
commit: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
date: 7 weeks ago
:::::: branch date: 2 hours ago
:::::: commit date: 7 weeks ago
config: riscv-randconfig-r071-20231211 (https://download.01.org/0day-ci/archive/20231213/202312130522.lsamDIka-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231213/202312130522.lsamDIka-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312130522.lsamDIka-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
Old smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:579 xilinx_pl_dma_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
drivers/pci/controller/pcie-xilinx-dma-pl.c:645 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
vim +/irq +638 drivers/pci/controller/pcie-xilinx-dma-pl.c
8d786149d78c77 Thippeswamy Havalige 2023-10-03 595
8d786149d78c77 Thippeswamy Havalige 2023-10-03 596 static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 597 {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 598 struct device *dev = port->dev;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 599 struct platform_device *pdev = to_platform_device(dev);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 600 int i, irq, err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 601
8d786149d78c77 Thippeswamy Havalige 2023-10-03 602 port->irq = platform_get_irq(pdev, 0);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 603 if (port->irq < 0)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 604 return port->irq;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 605
8d786149d78c77 Thippeswamy Havalige 2023-10-03 606 for (i = 0; i < ARRAY_SIZE(intr_cause); i++) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 607 int err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 608
8d786149d78c77 Thippeswamy Havalige 2023-10-03 609 if (!intr_cause[i].str)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 610 continue;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 611
8d786149d78c77 Thippeswamy Havalige 2023-10-03 612 irq = irq_create_mapping(port->pldma_domain, i);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 613 if (!irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 614 dev_err(dev, "Failed to map interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 615 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 616 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 617
8d786149d78c77 Thippeswamy Havalige 2023-10-03 618 err = devm_request_irq(dev, irq,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 619 xilinx_pl_dma_pcie_intr_handler,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 620 IRQF_SHARED | IRQF_NO_THREAD,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 621 intr_cause[i].sym, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 622 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 623 dev_err(dev, "Failed to request IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 624 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 625 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 626 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 627
8d786149d78c77 Thippeswamy Havalige 2023-10-03 628 port->intx_irq = irq_create_mapping(port->pldma_domain,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 629 XILINX_PCIE_INTR_INTX);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 630 if (!port->intx_irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 631 dev_err(dev, "Failed to map INTx interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 632 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 633 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 634
8d786149d78c77 Thippeswamy Havalige 2023-10-03 635 err = devm_request_irq(dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 636 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 637 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 @638 dev_err(dev, "Failed to request INTx IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 639 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 640 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 641
8d786149d78c77 Thippeswamy Havalige 2023-10-03 642 err = devm_request_irq(dev, port->irq, xilinx_pl_dma_pcie_event_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 643 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 644 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 645 dev_err(dev, "Failed to request event IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 646 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 647 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 648
8d786149d78c77 Thippeswamy Havalige 2023-10-03 649 return 0;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 650 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 651
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
@ 2023-12-13 7:01 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2023-12-13 7:01 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
CC: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
CC: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 88035e5694a86a7167d490bb95e9df97a9bb162b
commit: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
date: 7 weeks ago
:::::: branch date: 6 hours ago
:::::: commit date: 7 weeks ago
config: riscv-randconfig-r071-20231211 (https://download.01.org/0day-ci/archive/20231213/202312131444.UVOjSXTF-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231213/202312131444.UVOjSXTF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312131444.UVOjSXTF-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
Old smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:579 xilinx_pl_dma_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
drivers/pci/controller/pcie-xilinx-dma-pl.c:645 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
vim +/irq +638 drivers/pci/controller/pcie-xilinx-dma-pl.c
8d786149d78c77 Thippeswamy Havalige 2023-10-03 595
8d786149d78c77 Thippeswamy Havalige 2023-10-03 596 static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 597 {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 598 struct device *dev = port->dev;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 599 struct platform_device *pdev = to_platform_device(dev);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 600 int i, irq, err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 601
8d786149d78c77 Thippeswamy Havalige 2023-10-03 602 port->irq = platform_get_irq(pdev, 0);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 603 if (port->irq < 0)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 604 return port->irq;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 605
8d786149d78c77 Thippeswamy Havalige 2023-10-03 606 for (i = 0; i < ARRAY_SIZE(intr_cause); i++) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 607 int err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 608
8d786149d78c77 Thippeswamy Havalige 2023-10-03 609 if (!intr_cause[i].str)
8d786149d78c77 Thippeswamy Havalige 2023-10-03 610 continue;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 611
8d786149d78c77 Thippeswamy Havalige 2023-10-03 612 irq = irq_create_mapping(port->pldma_domain, i);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 613 if (!irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 614 dev_err(dev, "Failed to map interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 615 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 616 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 617
8d786149d78c77 Thippeswamy Havalige 2023-10-03 618 err = devm_request_irq(dev, irq,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 619 xilinx_pl_dma_pcie_intr_handler,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 620 IRQF_SHARED | IRQF_NO_THREAD,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 621 intr_cause[i].sym, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 622 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 623 dev_err(dev, "Failed to request IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 624 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 625 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 626 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 627
8d786149d78c77 Thippeswamy Havalige 2023-10-03 628 port->intx_irq = irq_create_mapping(port->pldma_domain,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 629 XILINX_PCIE_INTR_INTX);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 630 if (!port->intx_irq) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 631 dev_err(dev, "Failed to map INTx interrupt\n");
8d786149d78c77 Thippeswamy Havalige 2023-10-03 632 return -ENXIO;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 633 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 634
8d786149d78c77 Thippeswamy Havalige 2023-10-03 635 err = devm_request_irq(dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 636 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 637 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 @638 dev_err(dev, "Failed to request INTx IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 639 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 640 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 641
8d786149d78c77 Thippeswamy Havalige 2023-10-03 642 err = devm_request_irq(dev, port->irq, xilinx_pl_dma_pcie_event_flow,
8d786149d78c77 Thippeswamy Havalige 2023-10-03 643 IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 644 if (err) {
8d786149d78c77 Thippeswamy Havalige 2023-10-03 645 dev_err(dev, "Failed to request event IRQ %d\n", irq);
8d786149d78c77 Thippeswamy Havalige 2023-10-03 646 return err;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 647 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 648
8d786149d78c77 Thippeswamy Havalige 2023-10-03 649 return 0;
8d786149d78c77 Thippeswamy Havalige 2023-10-03 650 }
8d786149d78c77 Thippeswamy Havalige 2023-10-03 651
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-13 7:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-12 21:15 drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-12-13 7:01 kernel test robot
2023-12-12 12:19 kernel test robot
2023-12-12 9:54 Dan Carpenter
2023-12-11 18:10 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.