All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>,
	sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 4/5] nvmet: relocate the cntlid_ida to the internal of subsystem
Date: Wed, 13 Dec 2023 16:37:28 +0100	[thread overview]
Message-ID: <20231213153728.GB7301@lst.de> (raw)
In-Reply-To: <1db09834-5cbe-4e27-938d-8ba4d50347d0@linux.alibaba.com>

On Wed, Dec 13, 2023 at 08:59:26PM +0800, Guixin Liu wrote:
>> nvmet: Make cntlid globally unique
>>      We usually log the cntlid which is confusing in case
>> we have multiple subsystems each with it's own cntlid ida.
>> Instead make cntlid ida globally unique and log the initial
>> association.
>> "
>>
>> which seems reasonable.  If you have a reason for not making it unique,
>> it needs to be stated here so we can weight it against the original
>> reason for making the ids globally unique.
>
> Emm, I just change this per the NVMe spec, Sagi's comment is reasonable.

It's probably worth moving the above into a comment to explain what we're
doing here..


  reply	other threads:[~2023-12-13 15:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13  6:32 [PATCH 0/5] *** bugfixes and code refactoring for nvme target *** Guixin Liu
2023-12-13  6:32 ` [PATCH 1/5] nvmet: fix wrong error handling approach in nvmet_install_queue Guixin Liu
2023-12-13  8:43   ` Christoph Hellwig
2023-12-13 12:49     ` Guixin Liu
2023-12-13 13:45       ` Sagi Grimberg
2023-12-13  6:32 ` [PATCH 2/5] nvmet: allow identical cntlid_min and cntlid_max settings Guixin Liu
2023-12-13  8:43   ` Christoph Hellwig
2023-12-13 13:46   ` Sagi Grimberg
2023-12-13  6:32 ` [PATCH 3/5] nvmet: remove cntlid_min and cntlid_max check in nvmet_alloc_ctrl Guixin Liu
2023-12-13  8:43   ` Christoph Hellwig
2023-12-13 13:47   ` Sagi Grimberg
2023-12-13  6:32 ` [PATCH 4/5] nvmet: relocate the cntlid_ida to the internal of subsystem Guixin Liu
2023-12-13  8:46   ` Christoph Hellwig
2023-12-13 12:59     ` Guixin Liu
2023-12-13 15:37       ` Christoph Hellwig [this message]
2023-12-13  6:32 ` [PATCH 5/5] nvmet: return invalid filed when check fctype fails Guixin Liu
2023-12-13  8:48   ` Christoph Hellwig
2023-12-13 13:05     ` Guixin Liu
2023-12-13 13:52       ` Sagi Grimberg
2023-12-13 23:05 ` [PATCH 0/5] *** bugfixes and code refactoring for nvme target *** Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231213153728.GB7301@lst.de \
    --to=hch@lst.de \
    --cc=kanie@linux.alibaba.com \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.