* [PATCH] leds: trigger: panic: don't register panic notifier if creating the trigger failed
@ 2023-12-09 22:51 Heiner Kallweit
2023-12-13 16:00 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2023-12-09 22:51 UTC (permalink / raw)
To: Pavel Machek, Lee Jones; +Cc: linux-leds@vger.kernel.org
It doesn't make sense to register the panic notifier if creating the
panic trigger failed.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/leds/trigger/ledtrig-panic.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c
index 64abf2e91..72297a845 100644
--- a/drivers/leds/trigger/ledtrig-panic.c
+++ b/drivers/leds/trigger/ledtrig-panic.c
@@ -64,10 +64,13 @@ static long led_panic_blink(int state)
static int __init ledtrig_panic_init(void)
{
+ led_trigger_register_simple("panic", &trigger);
+ if (!trigger)
+ return 0;
+
atomic_notifier_chain_register(&panic_notifier_list,
&led_trigger_panic_nb);
- led_trigger_register_simple("panic", &trigger);
panic_blink = led_panic_blink;
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: trigger: panic: don't register panic notifier if creating the trigger failed
2023-12-09 22:51 [PATCH] leds: trigger: panic: don't register panic notifier if creating the trigger failed Heiner Kallweit
@ 2023-12-13 16:00 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-12-13 16:00 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Pavel Machek, linux-leds@vger.kernel.org
On Sat, 09 Dec 2023, Heiner Kallweit wrote:
> It doesn't make sense to register the panic notifier if creating the
> panic trigger failed.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/leds/trigger/ledtrig-panic.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c
> index 64abf2e91..72297a845 100644
> --- a/drivers/leds/trigger/ledtrig-panic.c
> +++ b/drivers/leds/trigger/ledtrig-panic.c
> @@ -64,10 +64,13 @@ static long led_panic_blink(int state)
>
> static int __init ledtrig_panic_init(void)
> {
> + led_trigger_register_simple("panic", &trigger);
> + if (!trigger)
> + return 0;
It doesn't seem correct to return 0 on a known failure.
> +
> atomic_notifier_chain_register(&panic_notifier_list,
> &led_trigger_panic_nb);
>
> - led_trigger_register_simple("panic", &trigger);
> panic_blink = led_panic_blink;
> return 0;
> }
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-13 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-09 22:51 [PATCH] leds: trigger: panic: don't register panic notifier if creating the trigger failed Heiner Kallweit
2023-12-13 16:00 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.