All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Icenowy Zheng <uwu@icenowy.me>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/3] dt-bindings: arm: sunxi: document Transpeed 8K618-T board name
Date: Thu, 14 Dec 2023 00:56:46 +0000	[thread overview]
Message-ID: <20231214005646.15c2b69e@minigeek.lan> (raw)
In-Reply-To: <7d352882-5f6f-4c8b-a8c5-76ea31c2ae31@linaro.org>

On Tue, 12 Dec 2023 10:01:56 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

Hi,

> On 12/12/2023 02:08, Andre Przywara wrote:
> > The Transpeed 8K618-T TV box is a Chinese Android TV box, using the
> > Allwinner H618 SoC.
> > 
> > Add the board/SoC compatible string pair to the list of known boards.
> > 
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> >  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index 11c5ce941dd7e..5e91110cc9eb8 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -868,6 +868,11 @@ properties:
> >            - const: topwise,a721
> >            - const: allwinner,sun4i-a10
> >  
> > +      - description: Transpeed 8K618-T
> > +        items:
> > +          - const: transpeed,8k618-t
> > +          - const: allwinner,sun50i-h618  
> 
> Assuming you kept the existing order (its style) of a file:

Ah, a good point. The file seems to be sort alphabetically after the
"description" name, though there are some outliers. Will send a patch
to fix them.
But at least this entry is correctly sorted.
 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks!
Andre

> 
> Best regards,
> Krzysztof
> 
> 


WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Icenowy Zheng <uwu@icenowy.me>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/3] dt-bindings: arm: sunxi: document Transpeed 8K618-T board name
Date: Thu, 14 Dec 2023 00:56:46 +0000	[thread overview]
Message-ID: <20231214005646.15c2b69e@minigeek.lan> (raw)
In-Reply-To: <7d352882-5f6f-4c8b-a8c5-76ea31c2ae31@linaro.org>

On Tue, 12 Dec 2023 10:01:56 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

Hi,

> On 12/12/2023 02:08, Andre Przywara wrote:
> > The Transpeed 8K618-T TV box is a Chinese Android TV box, using the
> > Allwinner H618 SoC.
> > 
> > Add the board/SoC compatible string pair to the list of known boards.
> > 
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> >  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index 11c5ce941dd7e..5e91110cc9eb8 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -868,6 +868,11 @@ properties:
> >            - const: topwise,a721
> >            - const: allwinner,sun4i-a10
> >  
> > +      - description: Transpeed 8K618-T
> > +        items:
> > +          - const: transpeed,8k618-t
> > +          - const: allwinner,sun50i-h618  
> 
> Assuming you kept the existing order (its style) of a file:

Ah, a good point. The file seems to be sort alphabetically after the
"description" name, though there are some outliers. Will send a patch
to fix them.
But at least this entry is correctly sorted.
 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks!
Andre

> 
> Best regards,
> Krzysztof
> 
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-14  0:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  1:08 [PATCH 0/3] arm64: dts: allwinner: Add Transpeed 8K618-T TV box Andre Przywara
2023-12-12  1:08 ` Andre Przywara
2023-12-12  1:08 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add Transpeed Andre Przywara
2023-12-12  1:08   ` Andre Przywara
2023-12-12  9:01   ` Krzysztof Kozlowski
2023-12-12  9:01     ` Krzysztof Kozlowski
2023-12-14  0:58     ` Andre Przywara
2023-12-14  0:58       ` Andre Przywara
2023-12-12  1:08 ` [PATCH 2/3] dt-bindings: arm: sunxi: document Transpeed 8K618-T board name Andre Przywara
2023-12-12  1:08   ` Andre Przywara
2023-12-12  9:01   ` Krzysztof Kozlowski
2023-12-12  9:01     ` Krzysztof Kozlowski
2023-12-14  0:56     ` Andre Przywara [this message]
2023-12-14  0:56       ` Andre Przywara
2023-12-12  1:08 ` [PATCH 3/3] arm64: dts: allwinner: h618: add Transpeed 8K618-T TV box Andre Przywara
2023-12-12  1:08   ` Andre Przywara
2023-12-13 19:22   ` Jernej Škrabec
2023-12-13 19:22     ` Jernej Škrabec
2023-12-14  1:23     ` Andre Przywara
2023-12-14  1:23       ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231214005646.15c2b69e@minigeek.lan \
    --to=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=uwu@icenowy.me \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.