All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Lukasz Plachno <lukasz.plachno@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules()
Date: Sat, 16 Dec 2023 10:04:09 +0000	[thread overview]
Message-ID: <20231216100409.GM6288@kernel.org> (raw)
In-Reply-To: <20231214043449.15835-2-lukasz.plachno@intel.com>

On Thu, Dec 14, 2023 at 05:34:48AM +0100, Lukasz Plachno wrote:
> Passing v6 argument is unnecessary as flow_type is still
> analyzed inside the function.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Lukasz Plachno <lukasz.plachno@intel.com>

Thanks, this is a nice clean up.

Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Lukasz Plachno <lukasz.plachno@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v3 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules()
Date: Sat, 16 Dec 2023 10:04:09 +0000	[thread overview]
Message-ID: <20231216100409.GM6288@kernel.org> (raw)
In-Reply-To: <20231214043449.15835-2-lukasz.plachno@intel.com>

On Thu, Dec 14, 2023 at 05:34:48AM +0100, Lukasz Plachno wrote:
> Passing v6 argument is unnecessary as flow_type is still
> analyzed inside the function.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Lukasz Plachno <lukasz.plachno@intel.com>

Thanks, this is a nice clean up.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2023-12-16 10:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14  4:34 [Intel-wired-lan] [PATCH iwl-next v3 0/2] ice: Support flow director ether type filters Lukasz Plachno
2023-12-14  4:34 ` Lukasz Plachno
2023-12-14  4:34 ` [Intel-wired-lan] [PATCH iwl-next v3 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules() Lukasz Plachno
2023-12-14  4:34   ` Lukasz Plachno
2023-12-16 10:04   ` Simon Horman [this message]
2023-12-16 10:04     ` Simon Horman
2023-12-14  4:34 ` [Intel-wired-lan] [PATCH iwl-next v3 2/2] ice: Implement 'flow-type ether' rules Lukasz Plachno
2023-12-14  4:34   ` Lukasz Plachno
2023-12-16 10:03   ` [Intel-wired-lan] " Simon Horman
2023-12-16 10:03     ` Simon Horman
2023-12-19 14:04     ` [Intel-wired-lan] " Plachno, Lukasz
2023-12-19 14:04       ` Plachno, Lukasz
2023-12-19 17:35   ` [Intel-wired-lan] " Brett Creeley
2023-12-19 17:35     ` Brett Creeley
2023-12-20 14:19     ` [Intel-wired-lan] " Plachno, Lukasz
2023-12-20 14:19       ` Plachno, Lukasz
2023-12-20 17:11       ` [Intel-wired-lan] " Brett Creeley
2023-12-20 17:11         ` Brett Creeley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231216100409.GM6288@kernel.org \
    --to=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=lukasz.plachno@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.