From: Simon Horman <horms@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: intel-wired-lan@lists.osuosl.org, llvm@lists.linux.dev,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator
Date: Tue, 19 Dec 2023 10:12:02 +0000 [thread overview]
Message-ID: <20231219101202.GE811967@kernel.org> (raw)
In-Reply-To: <CAKwvOd=LjM08FyiXu-Qn7JmtM0oBD7rf4qkr=oo3QKeP+njRUw@mail.gmail.com>
On Mon, Dec 18, 2023 at 11:08:38AM -0800, Nick Desaulniers wrote:
> On Mon, Dec 18, 2023 at 11:00 AM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > On Mon, Dec 18, 2023 at 08:32:28AM -0800, Nick Desaulniers wrote:
> > > (Is -Wcomma enabled by -Wall?)
> >
> > No and last time that I looked into enabling it, there were a lot of
> > instances in the kernel:
> >
> > https://lore.kernel.org/20230630192825.GA2745548@dev-arch.thelio-3990X/
> >
> > It is still probably worth pursuing at some point but that is a lot of
> > instances to clean up (along with potentially having a decent amount of
> > pushback depending on the changes necessary to eliminate all instances).
>
> Filed this todo:
> https://github.com/ClangBuiltLinux/linux/issues/1968
> I'd be happy if Simon keeps poking at getting that warning enabled.
FWIIW, since the discussion cited above I have been keeping an eye on
-Wcomma, mostly wrt to patches for Networking code.
My subjective feelings on this are:
* Few new instances seem to be added
* There are some, though I wouldn't say a lot, of existing
instances in files that are that is being updated.
* I don't recall any of the instances, new or old, being bugs.
Though perhaps a very small number were.
So while I'm all for more checks.
And I'm all for only using the comma where it is necessary
(I suspect that often it is a typo).
I do not get the feeling that we are sitting on a trove of nasty bugs.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator
Date: Tue, 19 Dec 2023 10:12:02 +0000 [thread overview]
Message-ID: <20231219101202.GE811967@kernel.org> (raw)
In-Reply-To: <CAKwvOd=LjM08FyiXu-Qn7JmtM0oBD7rf4qkr=oo3QKeP+njRUw@mail.gmail.com>
On Mon, Dec 18, 2023 at 11:08:38AM -0800, Nick Desaulniers wrote:
> On Mon, Dec 18, 2023 at 11:00 AM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > On Mon, Dec 18, 2023 at 08:32:28AM -0800, Nick Desaulniers wrote:
> > > (Is -Wcomma enabled by -Wall?)
> >
> > No and last time that I looked into enabling it, there were a lot of
> > instances in the kernel:
> >
> > https://lore.kernel.org/20230630192825.GA2745548@dev-arch.thelio-3990X/
> >
> > It is still probably worth pursuing at some point but that is a lot of
> > instances to clean up (along with potentially having a decent amount of
> > pushback depending on the changes necessary to eliminate all instances).
>
> Filed this todo:
> https://github.com/ClangBuiltLinux/linux/issues/1968
> I'd be happy if Simon keeps poking at getting that warning enabled.
FWIIW, since the discussion cited above I have been keeping an eye on
-Wcomma, mostly wrt to patches for Networking code.
My subjective feelings on this are:
* Few new instances seem to be added
* There are some, though I wouldn't say a lot, of existing
instances in files that are that is being updated.
* I don't recall any of the instances, new or old, being bugs.
Though perhaps a very small number were.
So while I'm all for more checks.
And I'm all for only using the comma where it is necessary
(I suspect that often it is a typo).
I do not get the feeling that we are sitting on a trove of nasty bugs.
next prev parent reply other threads:[~2023-12-19 10:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 9:44 [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator Simon Horman
2023-12-17 9:44 ` Simon Horman
2023-12-18 16:32 ` [Intel-wired-lan] " Nick Desaulniers
2023-12-18 16:32 ` Nick Desaulniers
2023-12-18 19:00 ` [Intel-wired-lan] " Nathan Chancellor
2023-12-18 19:00 ` Nathan Chancellor
2023-12-18 19:08 ` [Intel-wired-lan] " Nick Desaulniers
2023-12-18 19:08 ` Nick Desaulniers
2023-12-19 10:12 ` Simon Horman [this message]
2023-12-19 10:12 ` Simon Horman
2023-12-19 16:24 ` [Intel-wired-lan] " Nick Desaulniers
2023-12-19 16:24 ` Nick Desaulniers
2023-12-19 10:05 ` [Intel-wired-lan] " Simon Horman
2023-12-19 10:05 ` Simon Horman
2023-12-27 14:13 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-27 14:13 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219101202.GE811967@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.