All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling
Date: Tue, 19 Dec 2023 11:05:33 +0000	[thread overview]
Message-ID: <20231219110533.GH811967@kernel.org> (raw)
In-Reply-To: <20231218103926.346294-2-jedrzej.jagielski@intel.com>

On Mon, Dec 18, 2023 at 11:39:25AM +0100, Jedrzej Jagielski wrote:
> Currently ixgbe driver is notified of overheating events
> via internal IXGBE_ERR_OVERTEMP error code.
> 
> Change the approach for handle_lasi() to use freshly introduced
> is_overtemp function parameter which set when such event occurs.
> Change check_overtemp() to bool and return true if overtemp
> event occurs.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> v2: change aproach to use additional function parameter to notify when overheat
> v4: change check_overtemp to bool
> v5: adress Simon's comments

Hi Jedrzej,

Thanks for the updates, this version looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
	netdev@vger.kernel.org,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling
Date: Tue, 19 Dec 2023 11:05:33 +0000	[thread overview]
Message-ID: <20231219110533.GH811967@kernel.org> (raw)
In-Reply-To: <20231218103926.346294-2-jedrzej.jagielski@intel.com>

On Mon, Dec 18, 2023 at 11:39:25AM +0100, Jedrzej Jagielski wrote:
> Currently ixgbe driver is notified of overheating events
> via internal IXGBE_ERR_OVERTEMP error code.
> 
> Change the approach for handle_lasi() to use freshly introduced
> is_overtemp function parameter which set when such event occurs.
> Change check_overtemp() to bool and return true if overtemp
> event occurs.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> v2: change aproach to use additional function parameter to notify when overheat
> v4: change check_overtemp to bool
> v5: adress Simon's comments

Hi Jedrzej,

Thanks for the updates, this version looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>


  parent reply	other threads:[~2023-12-19 11:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 10:39 [Intel-wired-lan] [PATCH iwl-next v5 0/2] ixgbe: Refactor ixgbe internal status Jedrzej Jagielski
2023-12-18 10:39 ` Jedrzej Jagielski
2023-12-18 10:39 ` [Intel-wired-lan] [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling Jedrzej Jagielski
2023-12-18 10:39   ` Jedrzej Jagielski
2023-12-18 23:28   ` [Intel-wired-lan] " Jacob Keller
2023-12-18 23:28     ` Jacob Keller
2023-12-19 11:05   ` Simon Horman [this message]
2023-12-19 11:05     ` Simon Horman
2023-12-29 21:46   ` [Intel-wired-lan] " Mekala, SunithaX D
2023-12-29 21:46     ` Mekala, SunithaX D
2023-12-18 10:39 ` [Intel-wired-lan] [PATCH iwl-next v5 2/2] ixgbe: Refactor returning internal error codes Jedrzej Jagielski
2023-12-18 10:39   ` Jedrzej Jagielski
2023-12-29 21:46   ` [Intel-wired-lan] " Mekala, SunithaX D
2023-12-29 21:46     ` Mekala, SunithaX D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231219110533.GH811967@kernel.org \
    --to=horms@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jedrzej.jagielski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.