From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 2/6] ASoC: dt-bindings: Add Rockchip RK3308 internal audio codec
Date: Wed, 20 Dec 2023 09:10:07 +0100 [thread overview]
Message-ID: <20231220091007.35e62af9@booty> (raw)
In-Reply-To: <170302760623.2025074.2958729782154314139.robh@kernel.org>
Hello,
On Tue, 19 Dec 2023 17:13:26 -0600
Rob Herring <robh@kernel.org> wrote:
> On Tue, 19 Dec 2023 15:54:17 +0100, Luca Ceresoli wrote:
> > Add device tree bindings document for the internal audio codec of the
> > Rockchip RK3308 SoC.
...
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.example.dts:20.20-21 syntax error
Indeed:
- audio-codec: audio-codec@ff560000 {
+ audio_codec: audio-codec@ff560000 {
Fixed locally, queued for v3.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 2/6] ASoC: dt-bindings: Add Rockchip RK3308 internal audio codec
Date: Wed, 20 Dec 2023 09:10:07 +0100 [thread overview]
Message-ID: <20231220091007.35e62af9@booty> (raw)
In-Reply-To: <170302760623.2025074.2958729782154314139.robh@kernel.org>
Hello,
On Tue, 19 Dec 2023 17:13:26 -0600
Rob Herring <robh@kernel.org> wrote:
> On Tue, 19 Dec 2023 15:54:17 +0100, Luca Ceresoli wrote:
> > Add device tree bindings document for the internal audio codec of the
> > Rockchip RK3308 SoC.
...
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.example.dts:20.20-21 syntax error
Indeed:
- audio-codec: audio-codec@ff560000 {
+ audio_codec: audio-codec@ff560000 {
Fixed locally, queued for v3.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 2/6] ASoC: dt-bindings: Add Rockchip RK3308 internal audio codec
Date: Wed, 20 Dec 2023 09:10:07 +0100 [thread overview]
Message-ID: <20231220091007.35e62af9@booty> (raw)
In-Reply-To: <170302760623.2025074.2958729782154314139.robh@kernel.org>
Hello,
On Tue, 19 Dec 2023 17:13:26 -0600
Rob Herring <robh@kernel.org> wrote:
> On Tue, 19 Dec 2023 15:54:17 +0100, Luca Ceresoli wrote:
> > Add device tree bindings document for the internal audio codec of the
> > Rockchip RK3308 SoC.
...
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.example.dts:20.20-21 syntax error
Indeed:
- audio-codec: audio-codec@ff560000 {
+ audio_codec: audio-codec@ff560000 {
Fixed locally, queued for v3.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-20 8:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 14:54 [PATCH v2 0/6] Add support for the internal RK3308 audio codec Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` [PATCH v2 1/6] ASoC: rockchip: i2s-tdm: Fix clk_id usage in .set_sysclk() Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` [PATCH v2 2/6] ASoC: dt-bindings: Add Rockchip RK3308 internal audio codec Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 23:13 ` Rob Herring
2023-12-19 23:13 ` Rob Herring
2023-12-19 23:13 ` Rob Herring
2023-12-20 8:10 ` Luca Ceresoli [this message]
2023-12-20 8:10 ` Luca Ceresoli
2023-12-20 8:10 ` Luca Ceresoli
2023-12-19 14:54 ` [PATCH v2 3/6] ASoC: core: add SOC_DOUBLE_RANGE_TLV() helper macro Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` [PATCH v2 4/6] ASoC: codecs: Add RK3308 internal audio codec driver Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` [PATCH v2 5/6] arm64: dts: rockchip: add i2s_8ch_2 and i2s_8ch_3 Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` [PATCH v2 6/6] arm64: dts: rockchip: add the internal audio codec Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
2023-12-19 14:54 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220091007.35e62af9@booty \
--to=luca.ceresoli@bootlin.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.