* [Buildroot] [PATCH] editorconfig: fix wildcard expansion
@ 2023-12-18 8:19 yann.morin
2023-12-20 20:32 ` Thomas Petazzoni via buildroot
2024-01-07 11:21 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: yann.morin @ 2023-12-18 8:19 UTC (permalink / raw)
To: buildroot; +Cc: yann.morin
From: "Yann E. MORIN" <yann.morin@orange.com>
It turns out that wildcard expansion, * and ?, is not performed in
matching lists {...}, at least in the vim plugin. The spec is not clear
about that, but refer to "pattern matching through Unix shell-style
wildcards" [0].
So, let's consider that this is not supported. Expand the patterns into
one section each, rather than use a list.
[0] https://spec.editorconfig.org/
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
---
.editorconfig | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/.editorconfig b/.editorconfig
index 4acaf3486b..af6cf4b449 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -13,11 +13,19 @@ insert_final_newline = true
indent_style = tab
indent_size = tab
-[{Config*.in*,linux/Config.ext.in}]
+[Config*.in*]
indent_style = tab
indent_size = tab
-[{Makefile*,*.mk}]
+[linux/Config.ext.in]
+indent_style = tab
+indent_size = tab
+
+[Makefile*]
+indent_style = tab
+indent_size = tab
+
+[*.mk]
indent_style = tab
indent_size = tab
--
2.34.1
____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] editorconfig: fix wildcard expansion
2023-12-18 8:19 [Buildroot] [PATCH] editorconfig: fix wildcard expansion yann.morin
@ 2023-12-20 20:32 ` Thomas Petazzoni via buildroot
2024-01-07 11:21 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-12-20 20:32 UTC (permalink / raw)
To: yann.morin; +Cc: buildroot
On Mon, 18 Dec 2023 09:19:03 +0100
<yann.morin@orange.com> wrote:
> From: "Yann E. MORIN" <yann.morin@orange.com>
>
> It turns out that wildcard expansion, * and ?, is not performed in
> matching lists {...}, at least in the vim plugin. The spec is not clear
> about that, but refer to "pattern matching through Unix shell-style
> wildcards" [0].
>
> So, let's consider that this is not supported. Expand the patterns into
> one section each, rather than use a list.
>
> [0] https://spec.editorconfig.org/
>
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
> ---
> .editorconfig | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] editorconfig: fix wildcard expansion
2023-12-18 8:19 [Buildroot] [PATCH] editorconfig: fix wildcard expansion yann.morin
2023-12-20 20:32 ` Thomas Petazzoni via buildroot
@ 2024-01-07 11:21 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-01-07 11:21 UTC (permalink / raw)
To: yann.morin; +Cc: buildroot
>>>>> <yann.morin@orange.com> writes:
> From: "Yann E. MORIN" <yann.morin@orange.com>
> It turns out that wildcard expansion, * and ?, is not performed in
> matching lists {...}, at least in the vim plugin. The spec is not clear
> about that, but refer to "pattern matching through Unix shell-style
> wildcards" [0].
> So, let's consider that this is not supported. Expand the patterns into
> one section each, rather than use a list.
> [0] https://spec.editorconfig.org/
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-07 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-18 8:19 [Buildroot] [PATCH] editorconfig: fix wildcard expansion yann.morin
2023-12-20 20:32 ` Thomas Petazzoni via buildroot
2024-01-07 11:21 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.