From: kernel test robot <lkp@intel.com>
To: Pingfan Liu <kernelfans@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: oe-kbuild-all@lists.linux.dev, Baoquan He <bhe@redhat.com>,
Pingfan Liu <piliu@redhat.com>,
kexec@lists.infradead.org,
Mahesh Salgaonkar <mahesh@linux.ibm.com>,
Ming Lei <ming.lei@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
Sourabh Jain <sourabhjain@linux.ibm.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCHv10 3/3] powerpc/smp: Allow hole in paca_ptrs to accommodate boot_cpu
Date: Thu, 28 Dec 2023 12:07:25 +0800 [thread overview]
Message-ID: <202312281100.39B8MAEU-lkp@intel.com> (raw)
In-Reply-To: <20231227024147.12485-1-kernelfans@gmail.com>
Hi Pingfan,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pingfan-Liu/powerpc-kernel-Remove-check-on-paca_ptrs_size/20231227-104412
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20231227024147.12485-1-kernelfans%40gmail.com
patch subject: [PATCHv10 3/3] powerpc/smp: Allow hole in paca_ptrs to accommodate boot_cpu
config: powerpc-microwatt_defconfig (https://download.01.org/0day-ci/archive/20231228/202312281100.39B8MAEU-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231228/202312281100.39B8MAEU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312281100.39B8MAEU-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/smp.h:12,
from arch/powerpc/kernel/paca.c:6:
arch/powerpc/kernel/paca.c: In function 'allocate_paca_ptrs':
>> arch/powerpc/kernel/paca.c:248:55: error: 'threads_in_core' undeclared (first use in this function); did you mean 'threads_per_core'?
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~~~~~~~~~~~
include/linux/compiler.h:236:55: note: in definition of macro '__is_constexpr'
236 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/uapi/linux/const.h:31:41: note: in expansion of macro '__ALIGN_KERNEL_MASK'
31 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^~~~~~~~~~~~~~~~~~~
include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^~~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:33: note: in expansion of macro 'ALIGN'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~
arch/powerpc/kernel/paca.c:248:55: note: each undeclared identifier is reported only once for each function it appears in
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~~~~~~~~~~~
include/linux/compiler.h:236:55: note: in definition of macro '__is_constexpr'
236 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/uapi/linux/const.h:31:41: note: in expansion of macro '__ALIGN_KERNEL_MASK'
31 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^~~~~~~~~~~~~~~~~~~
include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^~~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:33: note: in expansion of macro 'ALIGN'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:39:10: note: in expansion of macro '__is_signed'
39 | (__is_signed(x) == __is_signed(y) || \
| ^~~~~~~~~~~
include/linux/minmax.h:51:23: note: in expansion of macro '__types_ok'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~
include/linux/minmax.h:58:17: note: in expansion of macro '__cmp_once'
58 | __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y)))
| ^~~~~~~~~~
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:40:17: note: in expansion of macro '__is_signed'
40 | __is_signed((x) + 0) == __is_signed((y) + 0) || \
| ^~~~~~~~~~~
include/linux/minmax.h:51:23: note: in expansion of macro '__types_ok'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~
include/linux/minmax.h:58:17: note: in expansion of macro '__cmp_once'
58 | __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y)))
| ^~~~~~~~~~
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:36:53: note: in expansion of macro '__is_signed'
36 | (__builtin_choose_expr(__is_constexpr(x) && __is_signed(x), x, -1) >= 0)
vim +248 arch/powerpc/kernel/paca.c
242
243 void __init allocate_paca_ptrs(void)
244 {
245 unsigned int cnt;
246
247 /* paca_ptrs should be big enough to hold boot cpu */
> 248 cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
249 paca_last_cpu_num = cnt;
250 paca_ptrs_size = sizeof(struct paca_struct *) * cnt;
251 paca_ptrs = memblock_alloc_raw(paca_ptrs_size, SMP_CACHE_BYTES);
252 if (!paca_ptrs)
253 panic("Failed to allocate %d bytes for paca pointers\n",
254 paca_ptrs_size);
255
256 memset(paca_ptrs, 0x88, paca_ptrs_size);
257 }
258
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Pingfan Liu <kernelfans@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: oe-kbuild-all@lists.linux.dev, Baoquan He <bhe@redhat.com>,
Pingfan Liu <piliu@redhat.com>,
kexec@lists.infradead.org,
Mahesh Salgaonkar <mahesh@linux.ibm.com>,
Ming Lei <ming.lei@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
Sourabh Jain <sourabhjain@linux.ibm.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCHv10 3/3] powerpc/smp: Allow hole in paca_ptrs to accommodate boot_cpu
Date: Thu, 28 Dec 2023 12:07:25 +0800 [thread overview]
Message-ID: <202312281100.39B8MAEU-lkp@intel.com> (raw)
In-Reply-To: <20231227024147.12485-1-kernelfans@gmail.com>
Hi Pingfan,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pingfan-Liu/powerpc-kernel-Remove-check-on-paca_ptrs_size/20231227-104412
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20231227024147.12485-1-kernelfans%40gmail.com
patch subject: [PATCHv10 3/3] powerpc/smp: Allow hole in paca_ptrs to accommodate boot_cpu
config: powerpc-microwatt_defconfig (https://download.01.org/0day-ci/archive/20231228/202312281100.39B8MAEU-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231228/202312281100.39B8MAEU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312281100.39B8MAEU-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/smp.h:12,
from arch/powerpc/kernel/paca.c:6:
arch/powerpc/kernel/paca.c: In function 'allocate_paca_ptrs':
>> arch/powerpc/kernel/paca.c:248:55: error: 'threads_in_core' undeclared (first use in this function); did you mean 'threads_per_core'?
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~~~~~~~~~~~
include/linux/compiler.h:236:55: note: in definition of macro '__is_constexpr'
236 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/uapi/linux/const.h:31:41: note: in expansion of macro '__ALIGN_KERNEL_MASK'
31 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^~~~~~~~~~~~~~~~~~~
include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^~~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:33: note: in expansion of macro 'ALIGN'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~
arch/powerpc/kernel/paca.c:248:55: note: each undeclared identifier is reported only once for each function it appears in
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~~~~~~~~~~~
include/linux/compiler.h:236:55: note: in definition of macro '__is_constexpr'
236 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/uapi/linux/const.h:31:41: note: in expansion of macro '__ALIGN_KERNEL_MASK'
31 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^~~~~~~~~~~~~~~~~~~
include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^~~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:33: note: in expansion of macro 'ALIGN'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:39:10: note: in expansion of macro '__is_signed'
39 | (__is_signed(x) == __is_signed(y) || \
| ^~~~~~~~~~~
include/linux/minmax.h:51:23: note: in expansion of macro '__types_ok'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~
include/linux/minmax.h:58:17: note: in expansion of macro '__cmp_once'
58 | __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y)))
| ^~~~~~~~~~
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:40:17: note: in expansion of macro '__is_signed'
40 | __is_signed((x) + 0) == __is_signed((y) + 0) || \
| ^~~~~~~~~~~
include/linux/minmax.h:51:23: note: in expansion of macro '__types_ok'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~
include/linux/minmax.h:58:17: note: in expansion of macro '__cmp_once'
58 | __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y)))
| ^~~~~~~~~~
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:36:53: note: in expansion of macro '__is_signed'
36 | (__builtin_choose_expr(__is_constexpr(x) && __is_signed(x), x, -1) >= 0)
vim +248 arch/powerpc/kernel/paca.c
242
243 void __init allocate_paca_ptrs(void)
244 {
245 unsigned int cnt;
246
247 /* paca_ptrs should be big enough to hold boot cpu */
> 248 cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
249 paca_last_cpu_num = cnt;
250 paca_ptrs_size = sizeof(struct paca_struct *) * cnt;
251 paca_ptrs = memblock_alloc_raw(paca_ptrs_size, SMP_CACHE_BYTES);
252 if (!paca_ptrs)
253 panic("Failed to allocate %d bytes for paca pointers\n",
254 paca_ptrs_size);
255
256 memset(paca_ptrs, 0x88, paca_ptrs_size);
257 }
258
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Pingfan Liu <kernelfans@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Baoquan He <bhe@redhat.com>, Pingfan Liu <piliu@redhat.com>,
kexec@lists.infradead.org,
Mahesh Salgaonkar <mahesh@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Ming Lei <ming.lei@redhat.com>,
Sourabh Jain <sourabhjain@linux.ibm.com>,
oe-kbuild-all@lists.linux.dev,
Hari Bathini <hbathini@linux.ibm.com>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCHv10 3/3] powerpc/smp: Allow hole in paca_ptrs to accommodate boot_cpu
Date: Thu, 28 Dec 2023 12:07:25 +0800 [thread overview]
Message-ID: <202312281100.39B8MAEU-lkp@intel.com> (raw)
In-Reply-To: <20231227024147.12485-1-kernelfans@gmail.com>
Hi Pingfan,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pingfan-Liu/powerpc-kernel-Remove-check-on-paca_ptrs_size/20231227-104412
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20231227024147.12485-1-kernelfans%40gmail.com
patch subject: [PATCHv10 3/3] powerpc/smp: Allow hole in paca_ptrs to accommodate boot_cpu
config: powerpc-microwatt_defconfig (https://download.01.org/0day-ci/archive/20231228/202312281100.39B8MAEU-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231228/202312281100.39B8MAEU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312281100.39B8MAEU-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/smp.h:12,
from arch/powerpc/kernel/paca.c:6:
arch/powerpc/kernel/paca.c: In function 'allocate_paca_ptrs':
>> arch/powerpc/kernel/paca.c:248:55: error: 'threads_in_core' undeclared (first use in this function); did you mean 'threads_per_core'?
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~~~~~~~~~~~
include/linux/compiler.h:236:55: note: in definition of macro '__is_constexpr'
236 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/uapi/linux/const.h:31:41: note: in expansion of macro '__ALIGN_KERNEL_MASK'
31 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^~~~~~~~~~~~~~~~~~~
include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^~~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:33: note: in expansion of macro 'ALIGN'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~
arch/powerpc/kernel/paca.c:248:55: note: each undeclared identifier is reported only once for each function it appears in
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~~~~~~~~~~~
include/linux/compiler.h:236:55: note: in definition of macro '__is_constexpr'
236 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/uapi/linux/const.h:31:41: note: in expansion of macro '__ALIGN_KERNEL_MASK'
31 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^~~~~~~~~~~~~~~~~~~
include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^~~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:33: note: in expansion of macro 'ALIGN'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:39:10: note: in expansion of macro '__is_signed'
39 | (__is_signed(x) == __is_signed(y) || \
| ^~~~~~~~~~~
include/linux/minmax.h:51:23: note: in expansion of macro '__types_ok'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~
include/linux/minmax.h:58:17: note: in expansion of macro '__cmp_once'
58 | __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y)))
| ^~~~~~~~~~
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:40:17: note: in expansion of macro '__is_signed'
40 | __is_signed((x) + 0) == __is_signed((y) + 0) || \
| ^~~~~~~~~~~
include/linux/minmax.h:51:23: note: in expansion of macro '__types_ok'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~
include/linux/minmax.h:58:17: note: in expansion of macro '__cmp_once'
58 | __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y)))
| ^~~~~~~~~~
include/linux/minmax.h:92:25: note: in expansion of macro '__careful_cmp'
92 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
arch/powerpc/kernel/paca.c:248:15: note: in expansion of macro 'max'
248 | cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
| ^~~
include/linux/minmax.h:31:9: error: first argument to '__builtin_choose_expr' not a constant
31 | __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/minmax.h:51:9: note: in expansion of macro 'static_assert'
51 | static_assert(__types_ok(x, y), \
| ^~~~~~~~~~~~~
include/linux/minmax.h:36:53: note: in expansion of macro '__is_signed'
36 | (__builtin_choose_expr(__is_constexpr(x) && __is_signed(x), x, -1) >= 0)
vim +248 arch/powerpc/kernel/paca.c
242
243 void __init allocate_paca_ptrs(void)
244 {
245 unsigned int cnt;
246
247 /* paca_ptrs should be big enough to hold boot cpu */
> 248 cnt = max((unsigned int)ALIGN(boot_cpuid + 1, threads_in_core), nr_cpu_ids);
249 paca_last_cpu_num = cnt;
250 paca_ptrs_size = sizeof(struct paca_struct *) * cnt;
251 paca_ptrs = memblock_alloc_raw(paca_ptrs_size, SMP_CACHE_BYTES);
252 if (!paca_ptrs)
253 panic("Failed to allocate %d bytes for paca pointers\n",
254 paca_ptrs_size);
255
256 memset(paca_ptrs, 0x88, paca_ptrs_size);
257 }
258
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-12-28 4:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 2:39 [PATCHv10 0/3] enable nr_cpus for powerpc without re-ordering cpu number Pingfan Liu
2023-12-27 2:39 ` Pingfan Liu
2023-12-27 2:39 ` [PATCHv10 1/3] powerpc/kernel: Remove check on paca_ptrs_size Pingfan Liu
2023-12-27 2:39 ` Pingfan Liu
2023-12-27 2:41 ` [PATCHv10 2/3] powerpc/kernel: Extend arrays' size to make room for a hole in cpu_possible_mask Pingfan Liu
2023-12-27 2:41 ` Pingfan Liu
2023-12-27 19:52 ` kernel test robot
2023-12-27 19:52 ` kernel test robot
2023-12-27 19:52 ` kernel test robot
2023-12-27 2:41 ` [PATCHv10 3/3] powerpc/smp: Allow hole in paca_ptrs to accommodate boot_cpu Pingfan Liu
2023-12-27 2:41 ` Pingfan Liu
2023-12-27 20:45 ` kernel test robot
2023-12-27 20:45 ` kernel test robot
2023-12-27 20:45 ` kernel test robot
2023-12-28 4:07 ` kernel test robot [this message]
2023-12-28 4:07 ` kernel test robot
2023-12-28 4:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312281100.39B8MAEU-lkp@intel.com \
--to=lkp@intel.com \
--cc=bhe@redhat.com \
--cc=hbathini@linux.ibm.com \
--cc=kernelfans@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=ming.lei@redhat.com \
--cc=npiggin@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=piliu@redhat.com \
--cc=sourabhjain@linux.ibm.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.