From: Stephen Hemminger <stephen@networkplumber.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] packet: Improve exception handling in fanout_add()
Date: Sun, 31 Dec 2023 14:44:21 -0800 [thread overview]
Message-ID: <20231231144421.13ba1d04@hermes.local> (raw)
In-Reply-To: <828bb442-29d0-4bb8-b90d-f200bdd4faf6@web.de>
On Sun, 31 Dec 2023 16:39:02 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 31 Dec 2023 16:30:51 +0100
>
> The kfree() function was called in some cases by the fanout_add() function
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
>
> Thus use another label.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
NAK
kfree of null is perfectly fine.
There is no need for this patch.
next prev parent reply other threads:[~2023-12-31 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 15:39 [PATCH] packet: Improve exception handling in fanout_add() Markus Elfring
2023-12-31 21:45 ` Willem de Bruijn
2024-01-01 9:46 ` Markus Elfring
2024-01-01 15:29 ` Willem de Bruijn
2024-01-01 16:33 ` David Laight
2024-01-01 18:12 ` Stephen Hemminger
2024-01-02 7:32 ` Markus Elfring
2023-12-31 22:44 ` Stephen Hemminger [this message]
2024-01-02 16:30 ` [PATCH] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231231144421.13ba1d04@hermes.local \
--to=stephen@networkplumber.org \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.