All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: packet: Improve exception handling in fanout_add()
Date: Mon, 1 Jan 2024 10:46:45 +0100	[thread overview]
Message-ID: <a69fce11-68c2-446c-9da8-b959bb3ba70f@web.de> (raw)
In-Reply-To: <6591e0fcb089f_21410c2946c@willemb.c.googlers.com.notmuch>

> It is fine to call kfree with a possible NULL pointer:
…
> 	 * If @object is NULL, no operation is performed.
> 	 */
> 	void kfree(const void *object)

Such a function call triggers an input parameter validation
with a corresponding immediate return, doesn't it?
Do you find such data processing really helpful for the desired error/exception handling?

Regards,
Markus

  reply	other threads:[~2024-01-01  9:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31 15:39 [PATCH] packet: Improve exception handling in fanout_add() Markus Elfring
2023-12-31 21:45 ` Willem de Bruijn
2024-01-01  9:46   ` Markus Elfring [this message]
2024-01-01 15:29     ` Willem de Bruijn
2024-01-01 16:33       ` David Laight
2024-01-01 18:12     ` Stephen Hemminger
2024-01-02  7:32       ` Markus Elfring
2023-12-31 22:44 ` [PATCH] " Stephen Hemminger
2024-01-02 16:30 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a69fce11-68c2-446c-9da8-b959bb3ba70f@web.de \
    --to=markus.elfring@web.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.