* Re: [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro
2013-04-09 4:54 [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro Kuninori Morimoto
@ 2013-04-09 17:07 ` Laurent Pinchart
2013-04-10 0:40 ` Simon Horman
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-04-09 17:07 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Monday 08 April 2013 21:54:18 Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>
> >> Laurent
>
> I guess this patch is correct on your macro idea ?
Yes it is.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 7ba1f21..53cf679 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -80,7 +80,7 @@
> #define _GP_PORT_ALL(bank, pin, name, sfx) name##_##sfx
>
> #define _GP_GPIO(bank, pin, _name, sfx) \
> - [(bank * 32) + pin] = { \
> + [RCAR_GP_PIN(bank, pin)] = { \
> .name = __stringify(_name), \
> .enum_id = _name##_DATA, \
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro
2013-04-09 4:54 [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro Kuninori Morimoto
2013-04-09 17:07 ` Laurent Pinchart
@ 2013-04-10 0:40 ` Simon Horman
2013-04-16 3:11 ` Simon Horman
2013-04-22 3:34 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-04-10 0:40 UTC (permalink / raw)
To: linux-sh
On Tue, Apr 09, 2013 at 07:07:40PM +0200, Laurent Pinchart wrote:
> Hi Morimoto-san,
>
> On Monday 08 April 2013 21:54:18 Kuninori Morimoto wrote:
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> >
> > >> Laurent
> >
> > I guess this patch is correct on your macro idea ?
>
> Yes it is.
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks. I'll apply this on top of your series if
it gets a positive review from Magnus.
If you end up reposting the series then it would be a tremendous
help to me if you could include this patch in the series.
>
> > drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> > b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 7ba1f21..53cf679 100644
> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> > @@ -80,7 +80,7 @@
> > #define _GP_PORT_ALL(bank, pin, name, sfx) name##_##sfx
> >
> > #define _GP_GPIO(bank, pin, _name, sfx) \
> > - [(bank * 32) + pin] = { \
> > + [RCAR_GP_PIN(bank, pin)] = { \
> > .name = __stringify(_name), \
> > .enum_id = _name##_DATA, \
> > }
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro
2013-04-09 4:54 [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro Kuninori Morimoto
2013-04-09 17:07 ` Laurent Pinchart
2013-04-10 0:40 ` Simon Horman
@ 2013-04-16 3:11 ` Simon Horman
2013-04-22 3:34 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-04-16 3:11 UTC (permalink / raw)
To: linux-sh
On Wed, Apr 10, 2013 at 09:40:41AM +0900, Simon Horman wrote:
> On Tue, Apr 09, 2013 at 07:07:40PM +0200, Laurent Pinchart wrote:
> > Hi Morimoto-san,
> >
> > On Monday 08 April 2013 21:54:18 Kuninori Morimoto wrote:
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > >
> > > >> Laurent
> > >
> > > I guess this patch is correct on your macro idea ?
> >
> > Yes it is.
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks. I'll apply this on top of your series if
> it gets a positive review from Magnus.
I have queued up this patch for v3.11 in the soc-r8a7779 branch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro
2013-04-09 4:54 [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro Kuninori Morimoto
` (2 preceding siblings ...)
2013-04-16 3:11 ` Simon Horman
@ 2013-04-22 3:34 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-04-22 3:34 UTC (permalink / raw)
To: linux-sh
On Tue, Apr 16, 2013 at 12:11:37PM +0900, Simon Horman wrote:
> On Wed, Apr 10, 2013 at 09:40:41AM +0900, Simon Horman wrote:
> > On Tue, Apr 09, 2013 at 07:07:40PM +0200, Laurent Pinchart wrote:
> > > Hi Morimoto-san,
> > >
> > > On Monday 08 April 2013 21:54:18 Kuninori Morimoto wrote:
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > ---
> > > >
> > > > >> Laurent
> > > >
> > > > I guess this patch is correct on your macro idea ?
> > >
> > > Yes it is.
> > >
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Thanks. I'll apply this on top of your series if
> > it gets a positive review from Magnus.
>
> I have queued up this patch for v3.11 in the soc-r8a7779 branch.
I have moved it to the pinmux branch as that seems to be an
appropriate location for an sh-pfc change.
^ permalink raw reply [flat|nested] 5+ messages in thread