From: Simon Horman <horms@kernel.org>
To: Jan Sokolowski <jan.sokolowski@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jan Glaza <jan.glaza@intel.com>,
Aniruddha Paul <aniruddha.paul@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors
Date: Thu, 4 Jan 2024 20:35:27 +0000 [thread overview]
Message-ID: <20240104203527.GM31813@kernel.org> (raw)
In-Reply-To: <20240103141115.9509-1-jan.sokolowski@intel.com>
On Wed, Jan 03, 2024 at 03:11:15PM +0100, Jan Sokolowski wrote:
> From: Aniruddha Paul <aniruddha.paul@intel.com>
>
> HW incorrectly reports EIPE errors on encapsulated packets
> with L2 padding inside inner packet. HW shows outer UDP/IPV4
> packet checksum errors as part of the EIPE flags of the
> Rx descriptor. These are reported only if checksum offload
> is enabled and L3/L4 parsed flag is valid in Rx descriptor.
>
> When that error is reported by HW, we don't act on it
> instead of incrementing main Rx errors statistic as it
> would normally happen.
>
> Add a new statistic to count these errors since we still want
> to print them.
>
> Signed-off-by: Aniruddha Paul <aniruddha.paul@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Jan Glaza <jan.glaza@intel.com>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jan Sokolowski <jan.sokolowski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Aniruddha Paul <aniruddha.paul@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jan Glaza <jan.glaza@intel.com>
Subject: Re: [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors
Date: Thu, 4 Jan 2024 20:35:27 +0000 [thread overview]
Message-ID: <20240104203527.GM31813@kernel.org> (raw)
In-Reply-To: <20240103141115.9509-1-jan.sokolowski@intel.com>
On Wed, Jan 03, 2024 at 03:11:15PM +0100, Jan Sokolowski wrote:
> From: Aniruddha Paul <aniruddha.paul@intel.com>
>
> HW incorrectly reports EIPE errors on encapsulated packets
> with L2 padding inside inner packet. HW shows outer UDP/IPV4
> packet checksum errors as part of the EIPE flags of the
> Rx descriptor. These are reported only if checksum offload
> is enabled and L3/L4 parsed flag is valid in Rx descriptor.
>
> When that error is reported by HW, we don't act on it
> instead of incrementing main Rx errors statistic as it
> would normally happen.
>
> Add a new statistic to count these errors since we still want
> to print them.
>
> Signed-off-by: Aniruddha Paul <aniruddha.paul@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Jan Glaza <jan.glaza@intel.com>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-01-04 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 14:11 [Intel-wired-lan] [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors Jan Sokolowski
2024-01-03 14:11 ` Jan Sokolowski
2024-01-04 20:35 ` Simon Horman [this message]
2024-01-04 20:35 ` Simon Horman
2024-01-08 4:40 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-08 4:40 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104203527.GM31813@kernel.org \
--to=horms@kernel.org \
--cc=aniruddha.paul@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.glaza@intel.com \
--cc=jan.sokolowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.