From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Stefan Eichenberger <eichest@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 net-next 1/5] net: phy: Add BaseT1 auto-negotiation constants
Date: Mon, 8 Jan 2024 15:25:11 +0100 [thread overview]
Message-ID: <20240108142511.GA36576@debian> (raw)
In-Reply-To: <c9ede0c2-ec37-48b1-9ce7-8a1543c828ba@lunn.ch>
Am Mon, Jan 08, 2024 at 02:49:02PM +0100 schrieb Andrew Lunn:
> On Mon, Jan 08, 2024 at 10:36:56AM +0100, Dimitri Fedrau wrote:
> > Added constants for advertising 100BT1 and 1000BT1 in register BASE-T1
> > auto-negotiation advertisement register [31:16] (Register 7.515)
> >
> > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Sorry, more nit-picking :-(
>
> Signed-off-by, Reviewed-by:, Fixes: etc should all be together. No
> blanks lines between them. And Signed-off-by: comes last.
>
I'm fine with it. :-) Will fix this in V5.
> Given the missing statics, it looks like you will need to repost in
> two weeks times.
>
That's okay. I will repost in two weeks when net-next is open. Do you
mind if I add further patches to the series ?
> Andrew
Best regards,
Dimitri
next prev parent reply other threads:[~2024-01-08 14:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 9:36 [PATCH v4 net-next 0/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-08 9:36 ` [PATCH v4 net-next 1/5] net: phy: Add BaseT1 auto-negotiation constants Dimitri Fedrau
2024-01-08 13:49 ` Andrew Lunn
2024-01-08 14:25 ` Dimitri Fedrau [this message]
2024-01-08 9:36 ` [PATCH v4 net-next 2/5] net: phy: Support 100/1000BT1 linkmode advertisements Dimitri Fedrau
2024-01-08 9:36 ` [PATCH v4 net-next 3/5] net: phy: c45: detect 100/1000BASE-T1 " Dimitri Fedrau
2024-01-08 9:36 ` [PATCH v4 net-next 4/5] net: phy: marvell-88q2xxx: fix typos Dimitri Fedrau
2024-01-08 14:02 ` Andrew Lunn
2024-01-08 14:31 ` Dimitri Fedrau
2024-01-08 14:05 ` Andrew Lunn
2024-01-08 9:37 ` [PATCH v4 net-next 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-08 11:08 ` Simon Horman
2024-01-08 11:16 ` Dimitri Fedrau
2024-01-11 13:49 ` kernel test robot
2024-01-08 11:18 ` [PATCH v4 net-next 0/5] " Heiner Kallweit
2024-01-08 11:24 ` Dimitri Fedrau
2024-01-08 11:28 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108142511.GA36576@debian \
--to=dima.fedrau@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.