From: Rob Herring <robh@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: peter.griffin@linaro.org, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org,
andi.shyti@kernel.org, alim.akhtar@samsung.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
s.nawrocki@samsung.com, tomasz.figa@gmail.com,
cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org,
andre.draszik@linaro.org, saravanak@google.com,
willmcvicker@google.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit
Date: Mon, 8 Jan 2024 21:03:15 -0700 [thread overview]
Message-ID: <20240109040315.GA2619804-robh@kernel.org> (raw)
In-Reply-To: <20231228125805.661725-2-tudor.ambarus@linaro.org>
On Thu, Dec 28, 2023 at 12:57:54PM +0000, Tudor Ambarus wrote:
> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0)
> clock management unit.
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> v2:
> - fix comments as per Sam's suggestion and collect his R-b tag
> - Rob's suggestion of renaming the clock-names to just "bus" and "ip"
> was not implemented as I felt it affects readability in the driver
> and consistency with other exynos clock drivers. I will happily update
> the names in the -rc phase if someone else has a stronger opinion than
> mine.
I'll defer to Krzysztof.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: peter.griffin@linaro.org, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org,
andi.shyti@kernel.org, alim.akhtar@samsung.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
s.nawrocki@samsung.com, tomasz.figa@gmail.com,
cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org,
andre.draszik@linaro.org, saravanak@google.com,
willmcvicker@google.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit
Date: Mon, 8 Jan 2024 21:03:15 -0700 [thread overview]
Message-ID: <20240109040315.GA2619804-robh@kernel.org> (raw)
In-Reply-To: <20231228125805.661725-2-tudor.ambarus@linaro.org>
On Thu, Dec 28, 2023 at 12:57:54PM +0000, Tudor Ambarus wrote:
> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0)
> clock management unit.
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> v2:
> - fix comments as per Sam's suggestion and collect his R-b tag
> - Rob's suggestion of renaming the clock-names to just "bus" and "ip"
> was not implemented as I felt it affects readability in the driver
> and consistency with other exynos clock drivers. I will happily update
> the names in the -rc phase if someone else has a stronger opinion than
> mine.
I'll defer to Krzysztof.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-09 4:03 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 12:57 [PATCH v2 00/12] GS101 Oriole: CMU_PERIC0 support and USI updates Tudor Ambarus
2023-12-28 12:57 ` Tudor Ambarus
2023-12-28 12:57 ` [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit Tudor Ambarus
2023-12-28 12:57 ` Tudor Ambarus
2024-01-08 14:18 ` Peter Griffin
2024-01-08 14:18 ` Peter Griffin
2024-01-09 4:08 ` Rob Herring
2024-01-09 4:08 ` Rob Herring
2024-01-09 4:03 ` Rob Herring [this message]
2024-01-09 4:03 ` Rob Herring
2024-01-09 11:09 ` Krzysztof Kozlowski
2024-01-09 11:09 ` Krzysztof Kozlowski
2024-01-09 11:58 ` Tudor Ambarus
2024-01-09 11:58 ` Tudor Ambarus
2024-01-09 15:01 ` Krzysztof Kozlowski
2024-01-09 15:01 ` Krzysztof Kozlowski
2024-01-09 16:12 ` Tudor Ambarus
2024-01-09 16:12 ` Tudor Ambarus
2024-01-09 18:38 ` Krzysztof Kozlowski
2024-01-09 18:38 ` Krzysztof Kozlowski
2024-01-10 7:25 ` Tudor Ambarus
2024-01-10 7:25 ` Tudor Ambarus
2023-12-28 12:57 ` [PATCH v2 02/12] dt-bindings: i2c: exynos5: add google,gs101-hsi2c compatible Tudor Ambarus
2023-12-28 12:57 ` Tudor Ambarus
2024-01-08 14:20 ` Peter Griffin
2024-01-08 14:20 ` Peter Griffin
2023-12-28 12:57 ` [PATCH v2 03/12] dt-bindings: serial: samsung: do not allow reg-io-width for gs101 Tudor Ambarus
2023-12-28 12:57 ` Tudor Ambarus
2024-01-08 14:25 ` Peter Griffin
2024-01-08 14:25 ` Peter Griffin
2023-12-28 12:57 ` [PATCH v2 04/12] tty: serial: samsung: prepare for different IO types Tudor Ambarus
2023-12-28 12:57 ` Tudor Ambarus
2024-01-04 15:32 ` Greg KH
2024-01-04 15:32 ` Greg KH
2024-01-04 15:41 ` Tudor Ambarus
2024-01-04 15:41 ` Tudor Ambarus
2024-01-04 15:56 ` Greg KH
2024-01-04 15:56 ` Greg KH
2024-01-05 10:22 ` Tudor Ambarus
2024-01-05 10:22 ` Tudor Ambarus
2023-12-28 12:57 ` [PATCH v2 05/12] tty: serial: samsung: set UPIO_MEM32 iotype for gs101 Tudor Ambarus
2023-12-28 12:57 ` Tudor Ambarus
2024-01-08 14:29 ` Peter Griffin
2024-01-08 14:29 ` Peter Griffin
2023-12-28 12:57 ` [PATCH v2 06/12] tty: serial: samsung: add gs101 earlycon support Tudor Ambarus
2023-12-28 12:57 ` Tudor Ambarus
2024-01-08 14:34 ` Peter Griffin
2024-01-08 14:34 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 07/12] clk: samsung: gs101: add support for cmu_peric0 Tudor Ambarus
2023-12-28 12:58 ` Tudor Ambarus
2024-01-08 14:52 ` Peter Griffin
2024-01-08 14:52 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 08/12] arm64: dts: exynos: gs101: remove reg-io-width from serial Tudor Ambarus
2023-12-28 12:58 ` Tudor Ambarus
2024-01-08 15:30 ` Peter Griffin
2024-01-08 15:30 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 09/12] arm64: dts: exynos: gs101: enable cmu-peric0 clock controller Tudor Ambarus
2023-12-28 12:58 ` Tudor Ambarus
2024-01-08 15:36 ` Peter Griffin
2024-01-08 15:36 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 10/12] arm64: dts: exynos: gs101: update USI UART to use peric0 clocks Tudor Ambarus
2023-12-28 12:58 ` Tudor Ambarus
2023-12-28 14:22 ` André Draszik
2023-12-28 14:22 ` André Draszik
2023-12-29 8:26 ` Tudor Ambarus
2023-12-29 8:26 ` Tudor Ambarus
2023-12-28 12:58 ` [PATCH v2 11/12] arm64: dts: exynos: gs101: define USI8 with I2C configuration Tudor Ambarus
2023-12-28 12:58 ` Tudor Ambarus
2023-12-28 14:04 ` André Draszik
2023-12-28 14:04 ` André Draszik
2023-12-29 8:04 ` Tudor Ambarus
2023-12-29 8:04 ` Tudor Ambarus
2023-12-29 14:21 ` Tudor Ambarus
2023-12-29 14:21 ` Tudor Ambarus
2023-12-28 12:58 ` [PATCH v2 12/12] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole Tudor Ambarus
2023-12-28 12:58 ` Tudor Ambarus
2024-01-08 16:15 ` Peter Griffin
2024-01-08 16:15 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109040315.GA2619804-robh@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.