From: Petr Vorel <pvorel@suse.cz>
To: Su Yue <l@damenly.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
ltp@lists.linux.it, Cyril Hrubis <chrubis@suse.cz>,
Li Wang <liwang@redhat.com>,
Richard Palethorpe <rpalethorpe@suse.com>,
Jan Stancek <jstancek@redhat.com>,
Xiao Yang <yangx.jy@fujitsu.com>,
Yang Xu <xuyang2018.jy@fujitsu.com>,
Brian Foster <bfoster@redhat.com>,
linux-bcachefs@vger.kernel.org, fstests@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v2 1/3] lib: Add Bcachefs magic
Date: Fri, 12 Jan 2024 14:58:38 +0100 [thread overview]
Message-ID: <20240112135838.GA2009596@pevik> (raw)
In-Reply-To: <frz27k44.fsf@damenly.org>
Hi all,
> On Thu 07 Dec 2023 at 20:40, Petr Vorel <pvorel@suse.cz> wrote:
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > New in v2
> > include/tst_fs.h | 3 +++
> > lib/tst_fs_type.c | 2 ++
> > 2 files changed, 5 insertions(+)
> > diff --git a/include/tst_fs.h b/include/tst_fs.h
> > index eb9841165..06f5be896 100644
> > --- a/include/tst_fs.h
> > +++ b/include/tst_fs.h
> > @@ -34,6 +34,9 @@
> > #define TST_VFAT_MAGIC 0x4d44 /* AKA MSDOS */
> > #define TST_EXFAT_MAGIC 0x2011BAB0UL
> > +/* fs/bcachefs/bcachefs_format.h */
> > +#define TST_BCACHE_MAGIC 0xca451a4e
> > +
> Not object to the patch. There are three MAGIC values in
> bcachefs_format.h: BCACHE_MAGIC, BCHFS_MAGIC, BCACHEFS_STATFS_MAGIC.
> IIUC, BCACHE_MAGIC is the older one in superblock, BCHFS_MAGIC is the
> new one. BCACHEFS_STATFS_MAGIC is for statfs.
> Kent,
> Would you please export needed magic values to include/uapi/linux/magic.h?
+1, very good idea.
Kind regards,
Petr
> Since you are the maintainer also I'm confused about variables to be named.
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Su Yue <l@damenly.org>
Cc: Brian Foster <bfoster@redhat.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
fstests@vger.kernel.org,
Richard Palethorpe <rpalethorpe@suse.com>,
linux-bcachefs@vger.kernel.org, Jan Kara <jack@suse.cz>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/3] lib: Add Bcachefs magic
Date: Fri, 12 Jan 2024 14:58:38 +0100 [thread overview]
Message-ID: <20240112135838.GA2009596@pevik> (raw)
In-Reply-To: <frz27k44.fsf@damenly.org>
Hi all,
> On Thu 07 Dec 2023 at 20:40, Petr Vorel <pvorel@suse.cz> wrote:
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > New in v2
> > include/tst_fs.h | 3 +++
> > lib/tst_fs_type.c | 2 ++
> > 2 files changed, 5 insertions(+)
> > diff --git a/include/tst_fs.h b/include/tst_fs.h
> > index eb9841165..06f5be896 100644
> > --- a/include/tst_fs.h
> > +++ b/include/tst_fs.h
> > @@ -34,6 +34,9 @@
> > #define TST_VFAT_MAGIC 0x4d44 /* AKA MSDOS */
> > #define TST_EXFAT_MAGIC 0x2011BAB0UL
> > +/* fs/bcachefs/bcachefs_format.h */
> > +#define TST_BCACHE_MAGIC 0xca451a4e
> > +
> Not object to the patch. There are three MAGIC values in
> bcachefs_format.h: BCACHE_MAGIC, BCHFS_MAGIC, BCACHEFS_STATFS_MAGIC.
> IIUC, BCACHE_MAGIC is the older one in superblock, BCHFS_MAGIC is the
> new one. BCACHEFS_STATFS_MAGIC is for statfs.
> Kent,
> Would you please export needed magic values to include/uapi/linux/magic.h?
+1, very good idea.
Kind regards,
Petr
> Since you are the maintainer also I'm confused about variables to be named.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-01-12 13:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 19:40 [PATCH v2 0/3] Add support bcachefs filesystem Petr Vorel
2023-12-07 19:40 ` [LTP] " Petr Vorel
2023-12-07 19:40 ` [PATCH v2 1/3] lib: Add Bcachefs magic Petr Vorel
2023-12-07 19:40 ` [LTP] " Petr Vorel
2024-01-12 13:18 ` Su Yue
2024-01-12 13:18 ` [LTP] " Su Yue
2024-01-12 13:58 ` Petr Vorel [this message]
2024-01-12 13:58 ` Petr Vorel
2023-12-07 19:40 ` [PATCH v2 2/3] lib: Add support bcachefs filesystem to .all_filesystems Petr Vorel
2023-12-07 19:40 ` [LTP] " Petr Vorel
2023-12-07 19:40 ` [PATCH v2 3/3] statx04: Skip STATX_ATTR_COMPRESSED on Bcachefs Petr Vorel
2023-12-07 19:40 ` [LTP] " Petr Vorel
2023-12-13 2:46 ` Kent Overstreet
2024-01-04 3:32 ` [LTP] " Li Wang
2024-01-08 10:01 ` Cyril Hrubis
2024-01-08 10:01 ` [LTP] " Cyril Hrubis
2024-01-08 20:54 ` Kent Overstreet
2024-01-08 20:54 ` [LTP] " Kent Overstreet
2024-01-09 10:32 ` Cyril Hrubis
2024-01-09 10:32 ` [LTP] " Cyril Hrubis
2024-04-19 13:11 ` Cyril Hrubis
2024-04-19 13:11 ` Cyril Hrubis
2024-05-07 8:18 ` Petr Vorel
2024-05-07 8:18 ` Petr Vorel
2024-05-07 14:16 ` Kent Overstreet
2024-05-07 14:16 ` Kent Overstreet
2024-05-07 17:03 ` Petr Vorel
2024-05-07 17:03 ` Petr Vorel
2023-12-12 14:48 ` [PATCH v2 0/3] Add support bcachefs filesystem Jan Kara
2023-12-12 14:48 ` [LTP] " Jan Kara
2023-12-13 16:51 ` Jan Kara
2023-12-13 16:51 ` [LTP] " Jan Kara
2024-01-08 10:14 ` Cyril Hrubis
2024-01-08 10:14 ` [LTP] " Cyril Hrubis
2024-01-08 20:04 ` Petr Vorel
2024-01-08 20:04 ` [LTP] " Petr Vorel
2024-01-11 14:05 ` ENODEV on bcachefs on kernel < 6.7 [was: Re: [PATCH v2 0/3] Add support bcachefs filesystem] pvorel
2024-01-11 14:05 ` [LTP] " pvorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112135838.GA2009596@pevik \
--to=pvorel@suse.cz \
--cc=amir73il@gmail.com \
--cc=bfoster@redhat.com \
--cc=chrubis@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=jstancek@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=l@damenly.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
--cc=xuyang2018.jy@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.