From: Subramanya Swamy <subramanya.swamy.linux@gmail.com>
To: ltp@lists.linux.it
Cc: Subramanya Swamy <subramanya.swamy.linux@gmail.com>
Subject: [LTP] [PATCH v1] isofs.sh:Use genisoimage/xorrisofs instead of mkisofs
Date: Mon, 15 Jan 2024 10:59:36 -0500 [thread overview]
Message-ID: <20240115155936.3235-1-subramanya.swamy.linux@gmail.com> (raw)
Debain uses genisoimage/xorrisofs and Centos uses xorrisofs
both genisoimage & xorrisofs have symlinks to mkisofs
xorrisofs doesn't support -hfs option & supports only -hfsplus option
genisoimage supports both -hfs & -hfsplus options
Signed-off-by: Subramanya Swamy <subramanya.swamy.linux@gmail.com>
---
testcases/kernel/fs/iso9660/isofs.sh | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/fs/iso9660/isofs.sh b/testcases/kernel/fs/iso9660/isofs.sh
index dfa4ac73d..392e1a764 100755
--- a/testcases/kernel/fs/iso9660/isofs.sh
+++ b/testcases/kernel/fs/iso9660/isofs.sh
@@ -19,12 +19,14 @@ MAX_DIRS=4
setup()
{
- if tst_cmd_available mkisofs; then
- MKISOFS_CMD="mkisofs"
+ if tst_cmd_available xorrisofs; then
+ MKISOFS_CMD="xorrisofs"
+ HFSOPT="-hfsplus -D"
elif tst_cmd_available genisoimage; then
MKISOFS_CMD="genisoimage"
+ HFSOPT="-hfsplus -D -hfs -D"
else
- tst_brk TCONF "please install mkisofs or genisoimage"
+ tst_brk TCONF "please install xorrisofs or genisoimage"
fi
}
@@ -62,7 +64,7 @@ do_test()
for mkisofs_opt in \
" " \
"-J" \
- "-hfs -D" \
+ $HFSOPT \
" -R " \
"-R -J" \
"-f -l -D -J -allow-leading-dots -R" \
--
2.39.3
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2024-01-15 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 15:59 Subramanya Swamy [this message]
2024-01-16 16:28 ` [LTP] [PATCH v1] isofs.sh:Use genisoimage/xorrisofs instead of mkisofs Petr Vorel
2024-01-20 18:52 ` Subramanya Swamy
2024-01-21 19:55 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115155936.3235-1-subramanya.swamy.linux@gmail.com \
--to=subramanya.swamy.linux@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.