All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Subramanya Swamy <subramanya.swamy.linux@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] isofs.sh:Use genisoimage/xorrisofs instead of mkisofs
Date: Tue, 16 Jan 2024 17:28:22 +0100	[thread overview]
Message-ID: <20240116162822.GB2606232@pevik> (raw)
In-Reply-To: <20240115155936.3235-1-subramanya.swamy.linux@gmail.com>

Hi Subramanya,

> Debain uses genisoimage/xorrisofs and Centos uses xorrisofs
> both genisoimage & xorrisofs have symlinks to mkisofs
> xorrisofs doesn't support -hfs option & supports only -hfsplus option
> genisoimage supports both -hfs & -hfsplus options

Well, there are 3 tools (although not all in all distros):

* Debian
for i in mkisofs genisoimage xorriso; do echo "=== $i ==="; $i; echo; done
=== mkisofs ===
genisoimage: Missing pathspec.
Usage: genisoimage [options] -o file directory ...

Use genisoimage -help
to get a list of valid options.

Report problems to debburn-devel@lists.alioth.debian.org.

=== genisoimage ===
genisoimage: Missing pathspec.
Usage: genisoimage [options] -o file directory ...

Use genisoimage -help
to get a list of valid options.

Report problems to debburn-devel@lists.alioth.debian.org.

=== xorriso ===
xorriso 1.5.2 : RockRidge filesystem manipulator, libburnia project.

usage : xorriso [commands]
        More is told by command -help
=> Debian has genisoimage and xorriso

* openSUSE Tumbleweed

$ for i in mkisofs genisoimage xorriso; do echo "=== $i ==="; $i; echo; done
=== mkisofs ===
mkisofs: Missing pathspec.
Usage: mkisofs [options] [-find] file... [find expression]

Use mkisofs -help
to get a list all of valid options.

Use mkisofs -find -help
to get a list of all valid -find options.

Most important Options:
	-posix-H		Follow sylinks encountered on command line
	-posix-L		Follow all symlinks
	-posix-P		Do not follow symlinks (default)
	-o FILE, -output FILE	Set output file name
	-R, -rock		Generate Rock Ridge directory information
	-r, -rational-rock	Generate rationalized Rock Ridge directory info
	-J, -joliet		Generate Joliet directory information
	-print-size		Print estimated filesystem size and exit
	-UDF			Generate UDF file system
	-dvd-audio		Generate DVD-Audio compliant UDF file system
	-dvd-video		Generate DVD-Video compliant UDF file system
	-dvd-hybrid		Generate a hybrid (DVD-Audio/DVD-Video) compliant UDF file system
	-iso-level LEVEL	Set ISO9660 level (1..3) or 4 for ISO9660 v 2
	-V ID, -volid ID	Set Volume ID
	-graft-points		Allow to use graft points for filenames
	-M FILE, -prev-session FILE	Set path to previous session to merge

=== genisoimage ===
 genisoimage: command not found

=== xorriso ===
xorriso 1.5.6 : RockRidge filesystem manipulator, libburnia project.

usage : xorriso [commands]
        More is told by command -help

=> openSUSE Tumbleweed has mkisofs and xorriso (genisoimage is not officially
supported)

How about to run test 3x - for mkisofs, genisoimage and xorriso. There would be
TCONF when file does not exist. And also detection if the binary is the expected
one? Something like this:

TST_TESTFUNC=do_test
TST_CNT=3

do_test()
{
	case $1 in
	1) MKISOFS_CMD="mkisofs";;
	2) MKISOFS_CMD="genisoimage"
	   HFSOPT="-hfsplus -D -hfs -D";;
	3) MKISOFS_CMD="xorriso"
	   HFSOPT="-hfsplus -D";;
	esac

	if ! tst_cmd_available $MKISOFS_CMD; then
		tst_res TCONF "Missing '$MKISOFS_CMD'"
		return
	fi

	if ! $CMD 2>&1 | grep -q "$MKISOFS_CMD"; then
		tst_res TCONF "'$MKISOFS_CMD' is a symlink to another tool"
		return
	fi

	... (rest of original do_test + $HFSOPT use)
}

Does it make sense to you?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-01-16 16:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 15:59 [LTP] [PATCH v1] isofs.sh:Use genisoimage/xorrisofs instead of mkisofs Subramanya Swamy
2024-01-16 16:28 ` Petr Vorel [this message]
2024-01-20 18:52   ` Subramanya Swamy
2024-01-21 19:55     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116162822.GB2606232@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=subramanya.swamy.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.