All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Emil Velikov <emil.velikov@collabora.com>
Subject: [PATCH BlueZ 7/8] bluetoothd: don't export internal API
Date: Tue, 16 Jan 2024 14:18:59 +0000	[thread overview]
Message-ID: <20240116-rm-ext-plugins-v1-7-62990fb07369@gmail.com> (raw)
In-Reply-To: <20240116-rm-ext-plugins-v1-0-62990fb07369@gmail.com>

From: Emil Velikov <emil.velikov@collabora.com>

With the final external plugin gone, we can keep the API internal.
---
 Makefile.am       |  3 ---
 src/bluetooth.ver | 20 --------------------
 2 files changed, 23 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 4db3a2953..c421f53c4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -291,7 +291,6 @@ pkglibexec_PROGRAMS += src/bluetoothd
 
 src_bluetoothd_SOURCES = $(builtin_sources) \
 			$(attrib_sources) $(btio_sources) \
-			src/bluetooth.ver \
 			src/main.c src/log.h src/log.c \
 			src/backtrace.h src/backtrace.c \
 			src/rfkill.c src/btd.h src/sdpd.h \
@@ -323,8 +322,6 @@ src_bluetoothd_LDADD = lib/libbluetooth-internal.la \
 			src/libshared-glib.la \
 			$(BACKTRACE_LIBS) $(GLIB_LIBS) $(DBUS_LIBS) -ldl -lrt \
 			$(builtin_ldadd)
-src_bluetoothd_LDFLAGS = $(AM_LDFLAGS) -Wl,--export-dynamic \
-				-Wl,--version-script=$(srcdir)/src/bluetooth.ver
 
 src_bluetoothd_DEPENDENCIES = lib/libbluetooth-internal.la \
 				gdbus/libgdbus-internal.la \
diff --git a/src/bluetooth.ver b/src/bluetooth.ver
deleted file mode 100644
index a96fda2a1..000000000
--- a/src/bluetooth.ver
+++ /dev/null
@@ -1,20 +0,0 @@
-{
-	global:
-		btd_*;
-		g_dbus_*;
-		info;
-		error;
-		debug;
-		baswap;
-		ba2str;
-		/* Don't break LLVM sanitizers */
-		__asan*;
-		__dfsan*;
-		__lsan*;
-		__msan*;
-		__sanitizer*;
-		__tsan*;
-		__ubsan*;
-	local:
-		*;
-};

-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@kernel.org>
To: linux-bluetooth@vger.kernel.org
Cc: Emil Velikov <emil.velikov@collabora.com>
Subject: [PATCH BlueZ 7/8] bluetoothd: don't export internal API
Date: Tue, 16 Jan 2024 14:18:59 +0000	[thread overview]
Message-ID: <20240116-rm-ext-plugins-v1-7-62990fb07369@gmail.com> (raw)
In-Reply-To: <20240116-rm-ext-plugins-v1-0-62990fb07369@gmail.com>

From: Emil Velikov <emil.velikov@collabora.com>

With the final external plugin gone, we can keep the API internal.
---
 Makefile.am       |  3 ---
 src/bluetooth.ver | 20 --------------------
 2 files changed, 23 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 4db3a2953..c421f53c4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -291,7 +291,6 @@ pkglibexec_PROGRAMS += src/bluetoothd
 
 src_bluetoothd_SOURCES = $(builtin_sources) \
 			$(attrib_sources) $(btio_sources) \
-			src/bluetooth.ver \
 			src/main.c src/log.h src/log.c \
 			src/backtrace.h src/backtrace.c \
 			src/rfkill.c src/btd.h src/sdpd.h \
@@ -323,8 +322,6 @@ src_bluetoothd_LDADD = lib/libbluetooth-internal.la \
 			src/libshared-glib.la \
 			$(BACKTRACE_LIBS) $(GLIB_LIBS) $(DBUS_LIBS) -ldl -lrt \
 			$(builtin_ldadd)
-src_bluetoothd_LDFLAGS = $(AM_LDFLAGS) -Wl,--export-dynamic \
-				-Wl,--version-script=$(srcdir)/src/bluetooth.ver
 
 src_bluetoothd_DEPENDENCIES = lib/libbluetooth-internal.la \
 				gdbus/libgdbus-internal.la \
diff --git a/src/bluetooth.ver b/src/bluetooth.ver
deleted file mode 100644
index a96fda2a1..000000000
--- a/src/bluetooth.ver
+++ /dev/null
@@ -1,20 +0,0 @@
-{
-	global:
-		btd_*;
-		g_dbus_*;
-		info;
-		error;
-		debug;
-		baswap;
-		ba2str;
-		/* Don't break LLVM sanitizers */
-		__asan*;
-		__dfsan*;
-		__lsan*;
-		__msan*;
-		__sanitizer*;
-		__tsan*;
-		__ubsan*;
-	local:
-		*;
-};

-- 
2.43.0


  parent reply	other threads:[~2024-01-16 14:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16 14:18 [PATCH BlueZ 0/8] Remove support for external plugins Emil Velikov
2024-01-16 14:18 ` Emil Velikov via B4 Relay
2024-01-16 14:18 ` [PATCH BlueZ 1/8] obexd: remove " Emil Velikov
2024-01-16 14:18   ` Emil Velikov via B4 Relay
2024-01-16 16:47   ` Remove " bluez.test.bot
2024-01-16 14:18 ` [PATCH BlueZ 2/8] build: don't export internal obexd API Emil Velikov
2024-01-16 14:18   ` Emil Velikov via B4 Relay
2024-01-16 14:18 ` [PATCH BlueZ 3/8] plugins: remove external-dummy Emil Velikov
2024-01-16 14:18   ` Emil Velikov via B4 Relay
2024-01-16 14:18 ` [PATCH BlueZ 4/8] plugins: convert external sixaxis plugin to builtin Emil Velikov
2024-01-16 14:18   ` Emil Velikov via B4 Relay
2024-01-16 14:18 ` [PATCH BlueZ 5/8] bluetoothd: remove support for external plugins Emil Velikov
2024-01-16 14:18   ` Emil Velikov via B4 Relay
2024-01-16 14:18 ` [PATCH BlueZ 6/8] bluetoothd: remove debug " Emil Velikov
2024-01-16 14:18   ` Emil Velikov via B4 Relay
2024-01-16 14:18 ` Emil Velikov [this message]
2024-01-16 14:18   ` [PATCH BlueZ 7/8] bluetoothd: don't export internal API Emil Velikov via B4 Relay
2024-01-16 14:19 ` [PATCH BlueZ 8/8] android: export only (android) entrypoint from the modules Emil Velikov
2024-01-16 14:19   ` Emil Velikov via B4 Relay
2024-01-22 18:34 ` [PATCH BlueZ 0/8] Remove support for external plugins Luiz Augusto von Dentz
2024-01-23 13:54   ` Emil Velikov
2024-01-23 13:59     ` Luiz Augusto von Dentz
2024-01-23 15:09       ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116-rm-ext-plugins-v1-7-62990fb07369@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=emil.velikov@collabora.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.